Skip to content
Snippets Groups Projects

Change GaudiConfig2 default semantics to use deepcopy of the default

Merged Marco Clemencic requested to merge 114-config2-default-value-change into master
All threads resolved!

This merge request changes the GaudiConfig2 DefaultSemantics so that it makes a deep copy of the default value.

This fixes the problem described in #114 (closed), but if a property with a non trivial type is only modified via its methods, we can only detect changes by comparing the default value with the stored value. Note that we still detect if the property is set to a new value equivalent to the default and handle the case correctly.

Closes #114 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marco Clemencic added 2 commits

    added 2 commits

    • 37ab536c - fix test coverage
    • 315f8fa3 - use nose --cover-min-percentage for GaudiConfig2 tests

    Compare with previous version

  • Marco Clemencic added 2 commits

    added 2 commits

    • 92661b9c - change GaudiConfig2 default semantics to use deepcopy of the default
    • 35d903bb - use nose --cover-min-percentage for GaudiConfig2 tests

    Compare with previous version

  • Marco Clemencic resolved all threads

    resolved all threads

  • Edited by Software for LHCb
  • I checked the ATLAS gaudi-head build that includes this MR and all looks good from our side. I also confirm that it fixes the cases where we saw that default values were being modified accidentally.

  • Frank Winklmeier approved this merge request

    approved this merge request

  • Marco Clemencic mentioned in commit 7fe46a1d

    mentioned in commit 7fe46a1d

  • Please register or sign in to reply
    Loading