Skip to content
Snippets Groups Projects

Fix spurious / irrelevant data race in DataObjectHandle and remove unused state

Merged Gerhard Raven requested to merge fix-spurious-datarace into master

Fix a data race flagged by helgrind which swamps any helgrind log -- the actual race is itself is harmless: it could lead to rare spurious double work, but without observable effect other than spending some cycles. The fix does imply an additional atomic bool, which may have a bigger performance impact, but is presumably small enough to also not have an observable difference...

Edited by Gerhard Raven

Merge request reports

Pipeline #3680598 passed

Pipeline passed for 81b3311b on fix-spurious-datarace

Approved by

Merged by Marco ClemencicMarco Clemencic 3 years ago (Mar 25, 2022 10:49am UTC)

Merge details

  • Changes merged into master with aab42633.
  • Deleted the source branch.

Pipeline #3758858 canceled

Pipeline canceled for aab42633 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading