Extend IFileAccess interface with a `read` function

IFileAccess;:read returns an optional<string> with the content of the requested file -- if it can be read. Otherwise it returns an 'empty' optional.

mentioned in merge request lhcb/LHCb!3461 (merged)

@clemenci: as discussed yesterday...

added 1 commit

• b25dab9e - Extend IFileAccess interface with a `read` function

Compare with previous version

mentioned in merge request lhcb/Rec!2783 (merged)

changed milestone to %v36r5

added lhcb-gaudi-head label

assigned to @clemenci

• [2022-03-24 00:04] Validation started with lhcb-gaudi-head#3196
• [2022-03-24 00:34] Validation started with lhcb-run2-gaudi-head#295
• [2022-03-25 00:06] Validation started with lhcb-gaudi-head#3197
• [2022-03-25 00:39] Validation started with lhcb-run2-gaudi-head#296

resolved all threads

approved this merge request

merged

mentioned in commit 6adec3a7

Any chance this error is related to this MR? (I'm trying to revert it locally to check)

ToolSvc.GitDDDB      INFO opening Git repository '/cvmfs/lhcb.cern.ch/lib/lhcb/git-conddb/DDDB.git'
ToolSvc.GitDDDB      INFO using commit 'upgrade/dddb-20220323' corresponding to b8c14122084e772ab1e6d280de8dffc0e5a3d3f3
ToolSvc.GitSIMCOND   INFO opening Git repository '/cvmfs/lhcb.cern.ch/lib/lhcb/git-conddb/SIMCOND.git'
ToolSvc.GitSIMCOND   INFO using commit 'upgrade/sim-20220324-vc-md100' corresponding to 5f9e05d598ddb9a86a4408a2f5fa6f5d3f396fd2
DetectorDataSvc   SUCCESS Detector description database: git:/lhcb.xml
VFSSvc              ERROR GitEntityResolver/GitDDDB does not implement IFileAccess
ServiceManager      ERROR Unable to initialize service "VFSSvc"
LHCb::ParticleP...  ERROR ServiceLocatorHelper::service: can not locate service VFSSvc
LHCb::ParticleP...  ERROR Unable to locate IFileAccess('VFSSvc') service
LHCb::ParticleP...  ERROR  Unable to initialize the internal structures
ServiceManager      ERROR Unable to initialize Service: LHCb::ParticlePropertySvc
ApplicationMgr      ERROR Application Manager Terminated with error code 1

Edit: yes, reverting it fixes the problem (in the Rec functor cache "compilation"). FWIW, this happens online, but seemingly not in the nightlies, so I'm a bit puzzled

What happens if instead of reverting the entire commit, just revert the single line which increments the minor version of the interface ID: i.e. this one: !1317 (diffs)

The MR was tested in the nightlies and didn't show problems. @rmatev, can you tell me how to reproduce it?

I can't reproduce it anymore. After purging and building from scratch (as in the nighlies) there is no issue.

that points to the build system not rebuilding something when a header it uses has been updated. Not sure whether that actually makes me more comfortable...