Changes to the `Configurable` method `merge`
The changes applied to the merge
method
were made as a result of code profiling
and result in a roughly 20-30s improvement
in some ATLAS trigger jobs.
An new test was added in
test_configurables_merge.py
as a result of changes made to merge
in order
to increase test coverage.
Merge request reports
Activity
- Resolved by Frank Winklmeier
Thanks @ktopolni. In addition to fixing the formatting issue, could you also please rewrite your commit history? Just squash all commits into one and then please also update the commit message to clearly say what has been changed. E.g. your changes only apply to the merge method. So that's more useful information than just saying "improve configuration time". Also explain why your changes result in an improvement (looks like it avoids unnecessary comparisons and maybe some reduction in function calls?). Also no need to reference an ATLAS-internal command. Just say that these changes result in a 20-30s reduction in configuration time in some ATLAS trigger jobs.
added 1 commit
- e8d80311 - Changes to the `Configurable` method `merge`
changed milestone to %v36r5
added lhcb-gaudi-head label
assigned to @clemenci
- [2022-03-24 00:04] Validation started with lhcb-gaudi-head#3196
- [2022-03-24 00:34] Validation started with lhcb-run2-gaudi-head#295
- [2022-03-25 00:06] Validation started with lhcb-gaudi-head#3197
- [2022-03-25 00:39] Validation started with lhcb-run2-gaudi-head#296
Edited by Software for LHCbmentioned in commit a926b34a