Skip to content
Snippets Groups Projects

Draft: Fix output for new histograms in JSON and MessageSvc sinks

Open Draft: Fix output for new histograms in JSON and MessageSvc sinks
rmatev/Gaudi:rm-fix-histo-output into master
2 unresolved threads
Open Rosen Matev requested to merge rmatev/Gaudi:rm-fix-histo-output into master
2 unresolved threads

Draft because I'd like to address the calculation and propagation of statistics as mentioned in #198 (closed)

/cc @sponce

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rosen Matev added 1 commit

    added 1 commit

    • 57a211cf - Name type for axes specification and use in examples

    Compare with previous version

  • Rosen Matev
    Rosen Matev @rmatev started a thread on an old version of the diff
    • GaudiExamples/src/Histograms/CounterHistos.cpp
    73 73 public:
    74 74 using Gaudi::Algorithm::Algorithm;
    75 75
    76 StatusCode initialize() override {
    77 const StatusCode sc = Algorithm::initialize();
    78 if ( sc.isFailure() ) return sc;
    79
    80 for ( int i : { 1, 2, 3 } ) {
    81 using AxesSpecType = decltype( m_map_prof_gauss_init )::mapped_type::AxesSpecType;
    82 m_map_prof_gauss_init.emplace( std::piecewise_construct, std::forward_as_tuple( i ),
    83 std::forward_as_tuple( this, "MapGaussInit" + std::to_string( i ),
    84 "Gaussian mean=0, sigma=1, atomic",
    85 AxesSpecType( { 50, -5, 5 }, { 50, -5, 5 } ) ) );
    86 }
    • Comment on lines +80 to +86
      Rosen Matev
      Rosen Matev @rmatev ·
      Author Developer

      Any suggestions how to hide this boilerplate from user code? As far as I can tell, that is the only one way to construct the histograms in place, and if you get it wrong (e.g. assume they can be copied), GCC spits a lot of "template argument deduction/substitution failed" and gives you absolutely no useful hints as to what is the correct solution.

    • S
      Sebastien Ponce @sponce ·
      Developer

      The first std::forward_as_tuple can be dropped as your key is an int. For the second one, I do not really see a nice way. Some would use a macro of course, but please, please don't !

    • Rosen Matev changed this line in version 5 of the diff

      changed this line in version 5 of the diff

    • Please register or sign in to reply
  • Sebastien Ponce @sponce started a thread on an old version of the diff
    • GaudiExamples/src/Histograms/CounterHistos.cpp
    73 73 public:
    74 74 using Gaudi::Algorithm::Algorithm;
    75 75
    76 StatusCode initialize() override {
    77 const StatusCode sc = Algorithm::initialize();
    78 if ( sc.isFailure() ) return sc;
  • Rosen Matev added 10 commits

    added 10 commits

    • 57a211cf...6abea6b4 - 7 commits from branch gaudi:master
    • cc684a77 - Fix output for new histograms in JSON and MessageSvc sinks
    • e8867fde - Add examples for maps of histograms
    • bdee4443 - Name type for axes specification and use in examples

    Compare with previous version

    Toggle commit list
  • Rosen Matev mentioned in merge request !1353 (merged)

    mentioned in merge request !1353 (merged)

  • Rosen Matev mentioned in merge request !1362 (merged)

    mentioned in merge request !1362 (merged)

  • Rosen Matev mentioned in issue lhcb/LHCb#251

    mentioned in issue lhcb/LHCb#251

    • Please register or sign in to reply