Use actual counter type when registering to monitoring

Having the counters delegate to BufferableCounter constructor for self registration to monitoring was hiding the actual type of counter to Entity so part of the customizations were lost (in particular the merge from JSON).

This MR changes BufferableCounter constructor signature to allow propagation of the final counter type to the Entity constructor. It also extends the unit tests to expose the problem (and validates the fix) of Counter not being recognized as mergeable from JSON.

The drawback is that specializations of BufferableCounter must have a typeString static data member.

Making the self registration constructor protected also prevents issues like that fixed in lhcb/LHCb!3830 (merged).

/cc @sponce

mentioned in merge request lhcb/LHCb!3796 (merged)

mentioned in merge request lhcb/LHCb!3830 (merged)

changed milestone to %v36r9

added lhcb-gaudi-head label

assigned to @clemenci

• [2022-11-08 14:22] Validation started with lhcb-gaudi-head#3388
• [2022-11-09 00:02] Validation started with lhcb-gaudi-head#3389
• [2022-11-09 00:22] Validation started with lhcb-run2-gaudi-head#413
• [2022-11-09 15:44] Validation started with lhcb-gaudi-head#3390
• [2022-11-09 16:10] Validation started with lhcb-gaudi-head#3391
• [2022-11-09 18:02] Validation started with lhcb-gaudi-head#3392
• [2022-11-10 00:02] Validation started with lhcb-gaudi-head#3393
• [2022-11-10 00:18] Validation started with lhcb-run2-gaudi-head#414
• [2022-11-11 00:03] Validation started with lhcb-gaudi-head#3394
• [2022-11-11 00:23] Validation started with lhcb-run2-gaudi-head#415
• [2022-11-12 00:05] Validation started with lhcb-gaudi-head#3395
• [2022-11-12 00:31] Validation started with lhcb-run2-gaudi-head#416
• [2022-11-13 00:04] Validation started with lhcb-gaudi-head#3396
• [2022-11-14 00:02] Validation started with lhcb-gaudi-head#3397

approved this merge request

mentioned in commit e2b07cf0

merged