Fix gcc12 warnings

I'm getting a few weird warnings when building Gaudi in optimized mode with gcc 12:

• maybe-uninitialized when passing an r-value reference to to std::make_unique (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107138#c4)
• dangling-pointer to an object on the stack of which I'm never trying to access the address

For the first case I decided to hide the warning (432b2972) and for the second I refactored slightly the code (de9ab00c).

changed milestone to %v36r10

added lhcb-gaudi-head lhcb-head-2 labels

assigned to @clemenci

• [2022-11-29 00:02] Validation started with lhcb-gaudi-head#3411
• [2022-11-29 00:17] Validation started with lhcb-run2-gaudi-head#424
• [2022-11-30 00:02] Validation started with lhcb-gaudi-head#3412
• [2022-11-30 00:22] Validation started with lhcb-run2-gaudi-head#425
• [2022-12-01 00:02] Validation started with lhcb-gaudi-head#3413
• [2022-12-02 00:03] Validation started with lhcb-gaudi-head#3414
• [2022-12-03 00:05] Validation started with lhcb-gaudi-head#3415
• [2022-12-04 00:02] Validation started with lhcb-gaudi-head#3416
• [2022-12-05 00:02] Validation started with lhcb-gaudi-head#3417
• [2022-12-06 00:02] Validation started with lhcb-gaudi-head#3418
• [2022-12-06 00:24] Validation started with lhcb-run2-gaudi-head#426
• [2022-12-07 00:03] Validation started with lhcb-gaudi-head#3419
• [2022-12-09 00:03] Validation started with lhcb-gaudi-head#3420
• [2022-12-10 00:02] Validation started with lhcb-gaudi-head#3421
• [2022-12-11 00:02] Validation started with lhcb-gaudi-head#3422
• [2022-12-11 00:27] Validation started with lhcb-run2-gaudi-head#427
• [2022-12-13 00:03] Validation started with lhcb-gaudi-head#3423
• [2022-12-13 00:19] Validation started with lhcb-run2-gaudi-head#428
• [2022-12-14 00:03] Validation started with lhcb-gaudi-head#3424
• [2022-12-15 00:03] Validation started with lhcb-gaudi-head#3425
• [2022-12-15 00:26] Validation started with lhcb-run2-gaudi-head#429
• [2022-12-16 00:13] Validation started with lhcb-gaudi-head#3426
• [2022-12-17 00:03] Validation started with lhcb-gaudi-head#3427
• [2022-12-17 00:20] Validation started with lhcb-run2-gaudi-head#430
• [2022-12-18 00:02] Validation started with lhcb-gaudi-head#3428
• [2022-12-20 00:04] Validation started with lhcb-gaudi-head#3429
• [2022-12-21 00:03] Validation started with lhcb-gaudi-head#3430
• [2022-12-22 00:03] Validation started with lhcb-gaudi-head#3431
• [2022-12-24 00:05] Validation started with lhcb-run2-gaudi-head#431
• [2022-12-25 00:02] Validation started with lhcb-gaudi-head#3432
• [2022-12-26 00:02] Validation started with lhcb-gaudi-head#3433
• [2022-12-27 00:02] Validation started with lhcb-gaudi-head#3434
• [2022-12-28 00:02] Validation started with lhcb-gaudi-head#3435
• [2022-12-29 00:02] Validation started with lhcb-gaudi-head#3436
• [2022-12-31 00:06] Validation started with lhcb-run2-gaudi-head#432
• [2023-01-04 00:02] Validation started with lhcb-gaudi-head#3437
• [2023-01-06 00:02] Validation started with lhcb-gaudi-head#3438
• [2023-01-06 00:16] Validation started with lhcb-run2-gaudi-head#433
• [2023-01-06 11:52] Validation started with lhcb-gaudi-head#3439

approved this merge request

merged

mentioned in commit 935101ee