Skip to content
Snippets Groups Projects

Remove TWebFile access for http(s) TURLs and use default TFile::Open via davix instead

Merged Johannes Elmsheuser requested to merge elmsheus/Gaudi:https_20230213 into master
All threads resolved!

Remove the old TWebFile access for http(s) TURLs in GaudiSvc/src/FileMgr/RootFileHandler.cpp. Use the default TFile::Open method that triggers the proper davix usage instead.

There was not objection within ATLAS and I am not sure if there is actually a remaining use-case for the current TWebFile method in this case, so I using this MR to find out.

Tagging @leggett, @ssnyder, @akraszna, @mnowak for info.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Johannes Elmsheuser

      I guess the following CI test failure is unrelated ?

      [INFO] This may take a few minutes...
      73An unexpected error has occurred: CalledProcessError: command: ('/builds/elmsheus/Gaudi/.cache/pre-commit/repo9k0xb2fp/py_env-python3/bin/python', '-mpip', 'install', '.')
      74return code: 1
      75stdout:
      76    Processing /builds/elmsheus/Gaudi/.cache/pre-commit/repo9k0xb2fp
      77      Installing build dependencies: started
      78      Installing build dependencies: finished with status 'done'
      79      Getting requirements to build wheel: started
      80      Getting requirements to build wheel: finished with status 'done'
      81      Preparing metadata (pyproject.toml): started
      82      Preparing metadata (pyproject.toml): finished with status 'error'
      83    
      84stderr:
      85      error: subprocess-exited-with-error
      86      
      87      × Preparing metadata (pyproject.toml) did not run successfully.
      88      │ exit code: 1
      89      ╰─> [14 lines of output]
      90          Traceback (most recent call last):
      91            File "/builds/elmsheus/Gaudi/.cache/pre-commit/repo9k0xb2fp/py_env-python3/lib/python3.8/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
      92              main()
      93            File "/builds/elmsheus/Gaudi/.cache/pre-commit/repo9k0xb2fp/py_env-python3/lib/python3.8/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
      94              json_out['return_val'] = hook(**hook_input['kwargs'])
      95            File "/builds/elmsheus/Gaudi/.cache/pre-commit/repo9k0xb2fp/py_env-python3/lib/python3.8/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
      96              return hook(metadata_directory, config_settings)
      97            File "/tmp/pip-build-env-ip13y2bo/overlay/lib/python3.8/site-packages/poetry/core/masonry/api.py", line 40, in prepare_metadata_for_build_wheel
      98              poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
      99            File "/tmp/pip-build-env-ip13y2bo/overlay/lib/python3.8/site-packages/poetry/core/factory.py", line 57, in create_poetry
      100              raise RuntimeError("The Poetry configuration is invalid:\n" + message)
      101          RuntimeError: The Poetry configuration is invalid:
      102            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'
      103          
      104          [end of output]
      105      
      106      note: This error originates from a subprocess, and is likely not a problem with pip.
      107    error: metadata-generation-failed
      108    
      109    × Encountered error while generating package metadata.
      110    ╰─> See above for output.
      111    
      112    note: This is an issue with the package mentioned above, not pip.
      113    hint: See above for details.
      114    
      115Check the log at /builds/elmsheus/Gaudi/.cache/pre-commit/pre-commit.log
      116
  • Marco Clemencic changed milestone to %v36r11

    changed milestone to %v36r11

  • added 10 commits

    • c54c686a...3209a00e - 9 commits from branch gaudi:master
    • 31c38da8 - Remove TWebFile access for http(s) TURLs and use default TFile::Open via davix instead

    Compare with previous version

  • Johannes Elmsheuser resolved all threads

    resolved all threads

  • Edited by Software for LHCb
  • Marco Clemencic approved this merge request

    approved this merge request

  • Marco Clemencic mentioned in commit 8d5cbd71

    mentioned in commit 8d5cbd71

Please register or sign in to reply
Loading