Skip to content
Snippets Groups Projects

macos: use GAUDI_LIBRARY_PATH instead of LD_...

Merged Valentin Volkl requested to merge vavolkl/Gaudi:macos_ld_lib_fix3 into master
All threads resolved!

This is a quick, macOS-only implementation of the suggestion in #251 , finally fixing Gaudi on macOS for me (after setting export GAUDI_LIBRARY_PATH=$LD_LIBRARY_PATH)

Should be safe to merge as the changes are only inside APPLE ifdefs, but does make the code a bit more complicated.

Edited by Valentin Volkl

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • It looks mostly OK to me, apart from a couple of minor changes.

    I'm not too convinced of the relative RPATH, but I have to think a bit more about it.

  • Marco Clemencic changed milestone to %v36r13

    changed milestone to %v36r13

    • Resolved by Marco Clemencic

      I was thinking that we may use the same logic on all platforms, may be calling the environment variable GAUDI_PLUGIN_PATH. If the library cannot be found in one of the directories listed there, then we can fallback on LD_LIBRARY_PATH.

  • Edited by Software for LHCb
  • Valentin Volkl resolved all threads

    resolved all threads

  • Valentin Volkl resolved all threads

    resolved all threads

  • Valentin Volkl added 1 commit

    added 1 commit

    • 87026e0c - Apply 2 suggestion(s) to 2 file(s)

    Compare with previous version

  • Valentin Volkl added 1 commit

    added 1 commit

    • 7c249859 - use naming GAUDI_PLUGIN_PATH instead

    Compare with previous version

  • Marco Clemencic resolved all threads

    resolved all threads

  • Marco Clemencic mentioned in issue #267

    mentioned in issue #267

  • Marco Clemencic approved this merge request

    approved this merge request

  • Marco Clemencic mentioned in commit 70fe70b5

    mentioned in commit 70fe70b5

  • Please register or sign in to reply
    Loading