New version of PartProp service

This is a port of the LHCb PartProp service into Gaudi.

Namespace for the service is updated to be part of Gaudi. Various examples and tests are all ported. Copyright and license are updatded to match Gaudi. Test algorithm is converted to a plain Algorithm and not a GaudiAlgorithm. Considerable clean-up of Python parts to improve flake8 and pylint compliance. (There are some import statements that have side effects, which are excepted from tests, F401.)

Use of PartProp service from Gaudi is necessary to have Gaussino fully experiment independent.

changed milestone to %v37r1

changed milestone to %v38r0

added 89 commits

• a834b014...bab27eb2 - 88 commits from branch gaudi:master
• 1e84bb02 - New version of PartProp service

Compare with previous version

added 1 commit

• 056359e7 - New version of PartProp service

Compare with previous version

added 4 commits

• 35335caa - Fix files permissions
• 92e626e9 - Ported GaudiPartProp to new convention on headers and namespaces
• f8d9a139 - Move utility class SynchronizedValue to GaudiKernel
• efdd5c1d - remove useless comments and minor clean up

Compare with previous version

I rebased to fix the conflict and took some time clean up the code and refactor to match new conventions.

marked this merge request as ready

added lhcb-gaudi-head label

assigned to @clemenci

• [2023-12-19 19:33] Validation started with lhcb-gaudi-head#3771
• [2023-12-19 19:39] Validation started with lhcb-gaudi-head#3771
• [2023-12-19 19:43] Validation started with lhcb-gaudi-head#3771
• [2023-12-20 00:04] Validation started with lhcb-gaudi-head#3772
• [2023-12-20 00:23] Validation started with lhcb-run2-gaudi-head#670
• [2023-12-20 00:31] Validation started with lhcb-sim10-gaudi-head#443
• [2023-12-20 06:56] Validation started with lhcb-gaudi-head#3773
• [2023-12-20 06:56] Validation started with lhcb-sim10-gaudi-head#444
• [2023-12-20 07:00] Validation started with lhcb-run2-gaudi-head#671
• [2023-12-20 14:42] Validation started with lhcb-gaudi-head#3774
• [2023-12-20 14:56] Validation started with lhcb-master-mr#9984
• [2024-01-19 18:18] Validation started with lhcb-master-mr#10183
• [2024-01-23 13:14] Validation started with lhcb-master-mr#10217
• [2024-01-23 14:24] Validation started with lhcb-gaudi-head#3798
• [2024-01-24 00:04] Validation started with lhcb-gaudi-head#3799
• [2024-01-24 00:25] Validation started with lhcb-run2-gaudi-head#689
• [2024-01-24 09:58] Validation started with lhcb-master-mr#10231

removed lhcb-gaudi-head label

marked this merge request as draft

added lhcb-gaudi-head label

added 3 commits

• ac36e1c7 - Ported GaudiPartProp to new convention on headers and namespaces
• 375ef274 - Move utility class SynchronizedValue to GaudiKernel
• fc7e33a8 - Remove useless comments and minor clean up

Compare with previous version

added 2 commits

• 8c661061 - Remove obsolete headers and classes
• b4ec2eb6 - Backward compatibility for users of GaudiKernel/ParticleProperty.h

Compare with previous version

/ci-test

After some more clean up and modernization, I think this is ready to go after some more testing in LHCb.

added 1 commit

• e25daed1 - Avoid clash of target names with LHCb

Compare with previous version

This is not ready yet... at least with 8c661061 and b4ec2eb6.

The inclusion in Gaudi of helper headers like Digit.h and TypeWrapper.h clash with the copies in LHCb (that happen to use the Gaudi namespace instead of LHCb).

I have to see if they can be dropped (I do not want to mess to much with LHCb code yet).

removed lhcb-gaudi-head label

I managed to progress a bit (locally) with some more clean up, but I need to see with some experts what of those utility classes are actually needed.

Digit.h, Lomont.h, etc. definitely not, but Decays.h and related ones seem more useful.

I'll resume the work in January.

added 41 commits

• e25daed1...87339293 - 30 commits from branch gaudi:master
• 24e37ad8 - 1 earlier commit
• 18a84b38 - Fix files permissions
• d086fb03 - Ported GaudiPartProp to new convention on headers and namespaces
• aa3320a1 - Move utility class SynchronizedValue to GaudiKernel
• ccdf3551 - Remove useless comments and minor clean up
• dbd5d35e - Remove obsolete headers and classes
• c5b3e0da - Backward compatibility for users of GaudiKernel/ParticleProperty.h
• cfda6b10 - Avoid clash of target names with LHCb
• 5af7bbb0 - Drop unneeded Digit.h and connected headers
• c0827d21 - Replace Lomont with simpler floating point comparison
• 25746d95 - Move Decays namespace into Gaudi namespace

Compare with previous version

/ci-test

mentioned in merge request atlas/atlasexternals!1099 (merged)

I know this question comes super late, but who is going to be the client of this outside of LHCb? If EIC, or somebody else is actively wishing for this, then of course fine. But I'm not aware of ATLAS waiting for this code. (Though even on that, maybe I'm wrong. @leggett, @fwinkl, do you two know more about this?)

This is needed so that Gaussino can be fully LHCb independent and used in Key4hep.

mentioned in merge request lhcb/LHCb!4420 (merged)

mentioned in merge request lhcb/Rec!3723 (merged)

added 23 commits

• 25746d95...52b20f79 - 11 commits from branch gaudi:master
• 52b20f79...bcb0d2ad - 2 earlier commits
• 3ab0055e - Ported GaudiPartProp to new convention on headers and namespaces
• 741793ef - Move utility class SynchronizedValue to GaudiKernel
• 108f09fb - Remove useless comments and minor clean up
• 380058e1 - Remove obsolete headers and classes
• a5e491cc - Backward compatibility for users of GaudiKernel/ParticleProperty.h
• 48078758 - Drop unneeded Digit.h and connected headers
• aea4b74b - Replace Lomont with simpler floating point comparison
• d67f3e26 - Move Decays namespace into Gaudi namespace
• cd2d429d - Avoid name clashes with LHCb
• c4a3790a - Make GaudiPartProp optional

Compare with previous version

added lhcb-gaudi-head label

/ci-test --platforms x86_64_v2-centos7-gcc12-opt,x86_64_v2-centos7-gcc12+detdesc-opt lhcb/LHCb!4420 (merged) lhcb/Rec!3723 (merged)

resolved all threads

added 5 commits

• 65c2e860 - Drop unneeded Digit.h and connected headers
• f7ed076f - Replace Lomont with simpler floating point comparison
• 6acff657 - Move Decays namespace into Gaudi namespace
• 6095b845 - Avoid name clashes with LHCb
• 38f460cf - Make GaudiPartProp optional

Compare with previous version

marked this merge request as ready

approved this merge request

/ci-test --platforms x86_64_v2-centos7-gcc12-opt,x86_64_v2-centos7-gcc12+detdesc-opt lhcb/LHCb!4420 (merged) lhcb/Rec!3723 (merged)

resolved all threads

mentioned in commit 6586235b

merged