Fixes for gcc 13, clang 16 and C++20

• Fix warning about implicit capture of this (deprecated in C++20)
• Hide maybe-uninitialized warnings from ROOT dictionaries
• Remove unused variables
• Fix implicit copy constructor/assignment deprecation warning
• Avoid warning: ittptmark64.o: missing .note.GNU-stack section implies executable stack
• Avoid ambiguity in NamedRange_{} == NamedRange_{}

About the warnings from the dictionaries, I managed to produce a test case that show how the warning pops up: https://godbolt.org/z/je7dE3vr1 The problem only appears with the optimization level -Og (used by LHCb in debug builds), so I'm not too worried. In any case I'll report the issue to ROOT ASAP.

Without NamedRange_::operator==, in the comparison between two NamedRange_ instances nr1 and nr2 C++20 would not be able to choose between (Range_&)nr1 == nr2 and (Range_&)nr2 == nr1.

added lhcb-gaudi-head label

added 1 commit

• 5c931222 - Hide maybe-uninitialized warnings in GaudiKernelDict.cxx

Compare with previous version

• [2023-10-13 00:03] Validation started with lhcb-gaudi-head#3709
• [2023-10-13 00:12] Validation started with lhcb-run2-gaudi-head#629
• [2023-10-13 00:18] Validation started with lhcb-sim10-gaudi-head#408
• [2023-10-13 12:01] Validation started with lhcb-gaudi-head#3710
• [2023-10-14 00:09] Validation started with lhcb-run2-gaudi-head#630
• [2023-10-14 00:19] Validation started with lhcb-gaudi-head#3711
• [2023-10-14 00:19] Validation started with lhcb-sim10-gaudi-head#409
• [2023-10-14 08:22] Validation started with lhcb-gaudi-head#3712
• [2023-10-15 00:03] Validation started with lhcb-gaudi-head#3713
• [2023-10-15 00:13] Validation started with lhcb-run2-gaudi-head#631
• [2023-10-15 00:18] Validation started with lhcb-sim10-gaudi-head#410
• [2023-10-16 00:03] Validation started with lhcb-sim10-gaudi-head#411
• [2023-10-17 00:03] Validation started with lhcb-gaudi-head#3714
• [2023-10-17 00:13] Validation started with lhcb-run2-gaudi-head#632
• [2023-10-17 00:19] Validation started with lhcb-sim10-gaudi-head#412
• [2023-10-17 12:05] Validation started with lhcb-gaudi-head#3715
• [2023-10-18 00:24] Validation started with lhcb-run2-gaudi-head#633
• [2023-10-18 00:30] Validation started with lhcb-sim10-gaudi-head#413
• [2023-10-18 00:34] Validation started with lhcb-gaudi-head#3716
• [2023-10-18 07:06] Validation started with lhcb-gaudi-head#3717
• [2023-10-19 00:03] Validation started with lhcb-gaudi-head#3718
• [2023-10-19 00:12] Validation started with lhcb-run2-gaudi-head#634
• [2023-10-19 00:24] Validation started with lhcb-sim10-gaudi-head#414
• [2023-10-19 00:35] Validation started with lhcb-gaudi-head#3718
• [2023-10-19 07:16] Validation started with lhcb-gaudi-head#3719
• [2023-10-19 11:35] Validation started with lhcb-gaudi-head#3720
• [2023-10-20 00:03] Validation started with lhcb-gaudi-head#3721
• [2023-10-20 00:12] Validation started with lhcb-run2-gaudi-head#635
• [2023-10-20 00:21] Validation started with lhcb-sim10-gaudi-head#415
• [2023-10-20 00:36] Validation started with lhcb-gaudi-head#3721
• [2023-10-21 00:03] Validation started with lhcb-gaudi-head#3722
• [2023-10-21 00:09] Validation started with lhcb-run2-gaudi-head#636
• [2023-10-21 00:21] Validation started with lhcb-sim10-gaudi-head#416
• [2023-10-22 00:03] Validation started with lhcb-gaudi-head#3723
• [2023-10-24 00:03] Validation started with lhcb-gaudi-head#3724
• [2023-10-25 00:03] Validation started with lhcb-gaudi-head#3725

added 1 commit

• 0efce187 - Hide maybe-uninitialized warnings in ROOT dictionaries

Compare with previous version

changed title from Draft: Fixes for gcc13 to Draft: Fixes for gcc13 and C++20

mentioned in merge request lhcb/LHCb!4322 (merged)

mentioned in merge request lhcb/Rec!3626 (merged)

added 2 commits

• b8cb9a3d - Remove unused variables
• 60972eea - Fix implicit copy constructor/assignment deprecation warning

Compare with previous version

approved this merge request

added 2 commits

• 44f2389c - Remove unused variables
• 7ace9b94 - Fix implicit copy constructor/assignment deprecation warning

Compare with previous version

added 1 commit

• 02cc85bc - Avoid warning: ittptmark64.o: missing .note.GNU-stack section implies executable stack

Compare with previous version

added 1 commit

• 3fab816e - Avoid ambiguity in "NamedRange_ == NamedRange_"

Compare with previous version

changed title from Draft: Fixes for gcc13 and C++20 to Draft: Fixes for gcc 13, clang 16 and C++20

changed the description

changed milestone to %v37r1

added 4 commits

• 1f309c1c - Remove unused variables
• fcc9b0f8 - Fix implicit copy constructor/assignment deprecation warning
• b7b755e0 - Avoid warning: ittptmark64.o: missing .note.GNU-stack section implies executable stack
• 008383dd - Avoid ambiguity in "NamedRange_ == NamedRange_"

Compare with previous version

resolved all threads

marked this merge request as ready