Skip to content

genconf: remove property type comment from Conf files

Frank Winklmeier requested to merge fwinkl/Gaudi:conftype into master

Remove the property type added as a comment to the Conf.py files. It was entirely cosmetic and often wrong (e.g. maps and other "unknown" types were annotated as # list).

E.g. this changes (only some lines shown):

class ExtendedProperties( ConfigurableAlgorithm ) :
  __slots__ = { 
    'ExtraInputs' : [], # list
    'OutputLevel' : 0, # int
    'Enable' : True, # bool
    'PairDD' : ( 0.0000000 , 0.0000000 ), # list
    'VectorOfPairsDD' : [  ], # list
    'MapIntDouble' : {  }, # list
    'TupleString' :  ( '' , ) , # list
    'GaudiMapSS' : {  }, # list
  }

to

class ExtendedProperties( ConfigurableAlgorithm ) :
  __slots__ = { 
    'ExtraInputs' : [],
    'OutputLevel' : 0,
    'Enable' : True,
    'PairDD' : ( 0.0000000 , 0.0000000 ),
    'VectorOfPairsDD' : [  ],
    'MapIntDouble' : {  },
    'TupleString' :  ( '' , ) ,
    'GaudiMapSS' : {  },
  }

Relates to issue #219 where this was commented on. But rather than trying to add the proper type, we can just remove that information entirely (we do have better type support in GaudiConfig2 already).

Merge request reports

Loading