Correctly detect and report a special case of corrupted ROOT file

I included a test that exposes #301 (closed) and changed the code to properly handle the failure arising from the special corruption.

Closes #301 (closed)

changed milestone to %v38r2

added lhcb-gaudi-head label

mentioned in issue #301 (closed)

• [2024-03-23 00:03] Validation started with lhcb-gaudi-head#3862
• [2024-03-23 00:08] Validation started with lhcb-run2-gaudi-head#729
• [2024-03-24 00:03] Validation started with lhcb-gaudi-head#3863
• [2024-03-25 00:03] Validation started with lhcb-gaudi-head#3864
• [2024-03-26 00:04] Validation started with lhcb-gaudi-head#3865
• [2024-03-26 00:08] Validation started with lhcb-run2-gaudi-head#730
• [2024-03-28 00:03] Validation started with lhcb-gaudi-head#3867
• [2024-03-28 00:16] Validation started with lhcb-run2-gaudi-head#732
• [2024-03-29 00:03] Validation started with lhcb-gaudi-head#3868
• [2024-03-29 00:36] Validation started with lhcb-gaudi-head#3868
• [2024-03-30 00:04] Validation started with lhcb-gaudi-head#3869
• [2024-03-31 00:03] Validation started with lhcb-gaudi-head#3870
• [2024-04-02 00:04] Validation started with lhcb-gaudi-head#3871
• [2024-04-02 00:16] Validation started with lhcb-run2-gaudi-head#733
• [2024-04-02 14:52] Validation started with lhcb-gaudi-head#3872
• [2024-04-03 00:03] Validation started with lhcb-gaudi-head#3873
• [2024-04-03 00:08] Validation started with lhcb-run2-gaudi-head#734
• [2024-04-04 00:04] Validation started with lhcb-gaudi-head#3874
• [2024-04-04 00:19] Validation started with lhcb-run2-gaudi-head#735
• [2024-04-05 00:03] Validation started with lhcb-gaudi-head#3875
• [2024-04-06 00:04] Validation started with lhcb-gaudi-head#3876
• [2024-04-06 00:09] Validation started with lhcb-run2-gaudi-head#736
• [2024-04-06 00:35] Validation started with lhcb-gaudi-head#3876
• [2024-04-07 00:03] Validation started with lhcb-gaudi-head#3877
• [2024-04-08 00:03] Validation started with lhcb-gaudi-head#3878
• [2024-04-09 00:04] Validation started with lhcb-gaudi-head#3879
• [2024-04-09 00:08] Validation started with lhcb-run2-gaudi-head#737
• [2024-04-10 00:06] Validation started with lhcb-gaudi-head#3880
• [2024-04-10 00:19] Validation started with lhcb-run2-gaudi-head#738
• [2024-04-11 00:04] Validation started with lhcb-gaudi-head#3881
• [2024-04-11 00:36] Validation started with lhcb-gaudi-head#3881
• [2024-04-12 00:03] Validation started with lhcb-gaudi-head#3882
• [2024-04-12 00:36] Validation started with lhcb-gaudi-head#3882
• [2024-04-13 00:03] Validation started with lhcb-gaudi-head#3883
• [2024-04-13 00:36] Validation started with lhcb-gaudi-head#3883
• [2024-04-16 00:04] Validation started with lhcb-gaudi-head#3884
• [2024-04-16 00:24] Validation started with lhcb-run2-gaudi-head#739
• [2024-04-17 00:04] Validation started with lhcb-gaudi-head#3885
• [2024-04-17 00:09] Validation started with lhcb-run2-gaudi-head#740
• [2024-04-18 00:04] Validation started with lhcb-gaudi-head#3886
• [2024-04-18 00:08] Validation started with lhcb-run2-gaudi-head#741
• [2024-04-19 00:04] Validation started with lhcb-gaudi-head#3887
• [2024-04-19 00:20] Validation started with lhcb-run2-gaudi-head#742
• [2024-04-20 00:04] Validation started with lhcb-gaudi-head#3888
• [2024-04-20 00:21] Validation started with lhcb-run2-gaudi-head#743
• [2024-04-22 00:04] Validation started with lhcb-gaudi-head#3889
• [2024-04-22 00:19] Validation started with lhcb-run2-gaudi-head#744

mentioned in issue lhcb/DaVinci#183 (closed)

This change is not good enough. It correctly detects when the main branch of the TTree cannot be retrieved, but it does not distinguish between between a corruption and the branche genuinely missing.

Unfortunately, as demonstrated by a few test in LHCb, it is valid to have a file without the main branch, meaning that no event were recorded.

removed lhcb-gaudi-head label

added 1 commit

• ae7df0c8 - Flag a file as corrupted if we cannot retrive the main TTree object

Compare with previous version

I changed where I detect we cannot retrieve an expected object so that we can detect better the corruption.

added lhcb-gaudi-head label

added 1 commit

• 7c322c98 - Flag a file as corrupted if we cannot retrive the main TTree object

Compare with previous version

assigned to @clemenci

approved this merge request

merged

mentioned in commit b3e26a7a

mentioned in issue lhcb/Moore#767 (closed)