Resolve "AlgContextSvc may dereference a nullptr"

Return a static empty instance if the thread local instance of the list of algorithms was never created.

I took the occasion to clean up a bit (merge .h and .cpp, remove pointless comments, ...) and add a basic unit test to validate the implementation.

Closes #304 (closed)

changed milestone to %v38r2

assigned to @clemenci

added 1 commit

• d94cab43 - Prevent segfaults in AlgContextSvc::algorithms()

Compare with previous version

marked this merge request as ready

added lhcb-gaudi-head label

changed the description

added 1 commit

• abbc2729 - Add unit test for AlgContextSvc

Compare with previous version

changed the description

For the future, can I suggest to split bug fixes and re-factoring into separate commits please? It's very painful to review this and see where the actual bug fix is.

added 3 commits

• b888947c - Prevent segfaults in AlgContextSvc::algorithms()
• 6f14ef74 - Small refactoring of AlgContextSvc
• d2f64119 - Add unit test for AlgContextSvc

Compare with previous version

resolved all threads

• [2024-05-03 00:04] Automatic merge failed in [lhcb-gaudi-head#3898](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaudi-head/3898/Gaudi/checkout
• [2024-05-03 00:19] Automatic merge failed in [lhcb-run2-gaudi-head#752](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run2-gaudi-head/752/Gaudi/checkout
• [2024-05-03 11:35] Validation started with lhcb-gaudi-head#3899
• [2024-05-04 00:04] Validation started with lhcb-gaudi-head#3900
• [2024-05-04 00:09] Validation started with lhcb-run2-gaudi-head#753
• [2024-05-04 00:37] Validation started with lhcb-gaudi-head#3900
• [2024-05-06 00:04] Validation started with lhcb-gaudi-head#3901
• [2024-05-06 00:19] Validation started with lhcb-run2-gaudi-head#754
• [2024-05-07 00:04] Validation started with lhcb-gaudi-head#3902
• [2024-05-07 00:08] Validation started with lhcb-run2-gaudi-head#755
• [2024-05-07 00:36] Validation started with lhcb-gaudi-head#3902

approved this merge request

merged

mentioned in commit 68e128f2