Use throw_format_error instead of deprecated error_handler
All threads resolved!
All threads resolved!
Closes #328 (closed)
Merge request reports
Activity
changed milestone to %v39r0
added lhcb-gaudi-head label
mentioned in issue #328 (closed)
- Resolved by Marco Clemencic
fmt v11.0.2 seems to be a bit less lenient around constness. I need an additional
const
in this linehttps://gitlab.cern.ch/gaudi/Gaudi/-/blob/master/GaudiCoreSvc/src/MessageSvc/MessageSvcSink.cpp#L94
i.e.
auto format( const json_fmt_arg& json_arg, FormatContext& ctx ) const {
With those changes in as well, I can build Gaudi against fmt v11.0.
I tested this with fmt v8 and fmt v10, both work with these changes (I would assume it's the same for v9, but I haven't tested).
Depending on how far you jump after #268 (closed) you could consider dropping the
detail::
sincethrow_format_error
is exposed from fmt v10.1.0 (this commit specifically).Edited by Thomas Madlener
- [2024-09-06 00:03] Validation started with lhcb-gaudi-head#3987
- [2024-09-06 00:08] Validation started with lhcb-run2-gaudi-head#819
- [2024-09-07 00:03] Validation started with lhcb-gaudi-head#3988
- [2024-09-07 00:13] Validation started with lhcb-run2-gaudi-head#820
- [2024-09-10 00:03] Validation started with lhcb-gaudi-head#3989
- [2024-09-10 00:07] Validation started with lhcb-run2-gaudi-head#821
Edited by Software for LHCbmentioned in commit 8dcdd929
Please register or sign in to reply