Fix tests when CMAKE_BUILD_TYPE is not set

As agreed in #326 (closed), I modified the logic used to select the needed reference file variant so that an empty CMAKE_BUILD_TYPE picks up the reference file used for Debug builds (because it is most likely that the difference in the out put comes from the presence or not of -DNDEBUG on the compiler command line).

I also fixed a small bug in !1605 (merged): we were not recording correctly the actual reference file used for the test (done by means of a pytest fixture to avoid duplication).

While fixing the behavior of the tests I realized that a test was enabled for Debug builds, because it depends on NDEBUG. Now it is enabled for empty CMAKE_BUILD_TYPE too.

Closes #326 (closed)

changed milestone to %v39r0

added bug build system labels

added 25 commits

• a70ff52f...07fe62d2 - 23 commits from branch master
• 10a4ca28 - temporary! do not set CMAKE_BUILD_TYPE in lcg-view CI job to demonstrate #326 (closed)
• 9dae8252 - Map empty build type to debug test reference files

Compare with previous version

The latest commit fixes the issue are agreed in #326 (comment 8430634), but I noticed a small issue form !1605 (merged) that I want to fix here (plus some polishing).

I'll finish on Monday.

added 8 commits

• 9dae8252...000171c7 - 4 commits from branch master
• 4d16bc5b - Use a fixture to resolve the test reference file name
• 8ca1fd13 - Map empty build type to debug test reference files
• c8276378 - Better comments describing build types meanings
• 73f8365e - Enable test_gaudi_1174 for empty build type

Compare with previous version

marked this merge request as ready

changed the description

added lhcb-gaudi-head label

I removed 10a4ca28 from this MR because I think it was not really appropriate (apart for a temporary test).

• [2024-09-17 00:03] Validation started with lhcb-gaudi-head#3994
• [2024-09-17 00:21] Validation started with lhcb-run2-gaudi-head#825
• [2024-09-18 00:03] Validation started with lhcb-gaudi-head#3995
• [2024-09-18 00:08] Validation started with lhcb-run2-gaudi-head#826

changed title from Set default CMAKE_BUILD_TYPE to Release to Fix tests when CMAKE_BUILD_TYPE is not set

approved this merge request

merged

mentioned in commit 03984d2e