add NtupleSvc basketsize property and forward in RCWNTupleCnv Branch creation
The goal of the change is to be able to control the basketsize call in RCWNTupleCnv.cpp by configuring the NTupleSvc property.
It has been observed that for most use cases of FunTuple
controlling the basket size can reduce significantly by more than 30-40% the memory consumption in case many TTrees are created in a single job. More tests will be documented here.
Since RCWNTupleCnv
has as private a INTupleSvc, a new virtual function is defined for INTupleSvc
FYI: @clemenci , @sponce , let me know if this is what you had in mind as change and if the target branch is fine.
MR is in draft , since i am testing changes in LHCb to be sure this can be controlled from option file.
Comes together with lhcb/LHCb!4697 (merged)
Merge request reports
Activity
mentioned in merge request lhcb/LHCb!4697 (merged)
- Resolved by Renato Quagliani
- Resolved by Renato Quagliani
I have two comments.
First, when you modify an interface you should update the line
DeclareInterfaceID
Second,
INTupleSvc
is, in principle, technology agnostic, so it doesn't make much sense to add a technology specific method. This holds for the property I suggested to add toNTupleSvc
too, but the property can be optional and inRCWNTupleCnv.cpp
you can check if the property exists and use it if it is the case.OTOH, at the moment we only support one backend in
NTUpleSvc
(ROOT) and, for me,NTupleSvc
is dead and should be removed in favour of the new thread-safe NTuple writer introduced with !1577 (merged) (@staider is working on a port of LHCb's FunTuple to the new NTuple writer), so the refactoring I'm suggesting is not really a blocker.
- Resolved by Renato Quagliani
added 1 commit
- 3c3e02ee - remove warning message, tested to load the option from lbexec
If there are tests to update, what would be the way to do it?
I think if a new DaVinci release is planned soon maybe it would be good to include this MR and the associated one in LHCb?
Edited by Renato Quaglianiadded 2 commits
assigned to @clemenci
- [2024-10-14 14:34] Validation started with lhcb-2024-patches-mr#1647
- [2024-10-15 10:24] Validation started with lhcb-2024-patches-mr#1656
Edited by Software for LHCbmentioned in merge request lhcb-core/LHCbNightlyConf!1263 (merged)
mentioned in issue lhcb/Moore#866 (closed)
mentioned in commit f79560e3