Modernize GaudiGSL

• move singleton declaration out of .h into .cpp
• prefer struct over class if only public data
• make binary operators symmetric wrt. promotion by making them friend functions
• use std::tie to implement operator<
• prefer inheritance from extend_interfaces over virtual inheritance from IFace
• prefer implicit destructors
• prefer implicit copy constructors
• prefer boost::variant over equivalent 'raw' code
• prefer std::vector over std::unique_ptr<T[]>
• prefer std::unique_ptr with custom deleter over explicit code
• prefer CommonMessaging
• prefer inherited constructors
• add final
• avoid unnecessary temporay vectors
• prefer switch over cascading if statements
• prefer cmath over math.c, cstdio over stdio.h
• prefer '\n' over std::endl
• do not call exit(0) when it is not necessary
• add support for Gaudi::Property<GaudiMath::Interpolation::Type>

@ibelyaev: FYI

• [2017-05-20 15:57] Validation started with lhcb-gaudi-merge#141
• [2017-05-21 00:02] Validation started with lhcb-future#403
• [2017-05-21 00:02] Validation started with lhcb-future-clang#196
• [2017-05-22 00:02] Validation started with lhcb-future#404
• [2017-05-22 00:02] Validation started with lhcb-future-clang#197
• [2017-05-23 00:01] Validation started with lhcb-future#405
• [2017-05-23 00:02] Validation started with lhcb-future-clang#198
• [2017-05-24 00:01] Validation started with lhcb-future-clang#199
• [2017-05-24 00:02] Validation started with lhcb-future#406
• [2017-05-25 00:02] Validation started with lhcb-future-clang#200
• [2017-05-25 00:02] Validation started with lhcb-future#407
• [2017-05-26 00:01] Validation started with lhcb-future#408
• [2017-05-26 00:01] Validation started with lhcb-future-clang#201
• [2017-05-26 10:44] Validation started with lhcb-future#409
• [2017-05-27 00:02] Validation started with lhcb-future#410
• [2017-05-27 00:02] Validation started with lhcb-future-clang#202
• [2017-05-28 00:01] Validation started with lhcb-future#411
• [2017-05-28 00:02] Validation started with lhcb-future-clang#203
• [2017-05-29 00:02] Validation started with lhcb-future-clang#204
• [2017-05-29 00:02] Validation started with lhcb-future#412
• [2017-05-30 00:02] Validation started with lhcb-future#413
• [2017-05-30 00:02] Validation started with lhcb-future-clang#205
• [2017-05-31 10:06] Validation started with lhcb-future#414
• [2017-06-01 00:02] Validation started with lhcb-future#415
• [2017-06-01 00:02] Validation started with lhcb-future-clang#206
• [2017-06-02 00:01] Validation started with lhcb-future#416
• [2017-06-02 00:02] Validation started with lhcb-future-clang#207
• [2017-06-03 00:01] Validation started with lhcb-future#417
• [2017-06-03 00:01] Validation started with lhcb-future-clang#208
• [2017-06-04 00:02] Validation started with lhcb-future#418
• [2017-06-04 00:02] Validation started with lhcb-future-clang#209
• [2017-06-05 00:02] Validation started with lhcb-future#419
• [2017-06-05 00:02] Validation started with lhcb-future-clang#210
• [2017-06-06 00:02] Validation started with lhcb-future#420
• [2017-06-06 00:02] Validation started with lhcb-future-clang#211
• [2017-06-07 00:02] Validation started with lhcb-future#421
• [2017-06-07 00:02] Validation started with lhcb-future-clang#212
• [2017-06-08 00:02] Validation started with lhcb-future#422
• [2017-06-08 00:02] Validation started with lhcb-future-clang#213
• [2017-06-09 00:07] Validation started with lhcb-future#423
• [2017-06-09 00:07] Validation started with lhcb-future-clang#214
• [2017-06-10 00:01] Validation started with lhcb-future#424
• [2017-06-10 00:02] Validation started with lhcb-future-clang#215
• [2017-06-11 00:02] Validation started with lhcb-future#425
• [2017-06-11 00:02] Validation started with lhcb-future-clang#216
• [2017-06-12 00:05] Validation started with lhcb-future-clang#217
• [2017-06-12 00:05] Validation started with lhcb-future#426
• [2017-06-13 00:04] Validation started with lhcb-future-clang#218
• [2017-06-13 00:04] Validation started with lhcb-future#427
• [2017-06-14 00:03] Validation started with lhcb-future#428
• [2017-06-14 00:03] Validation started with lhcb-future-clang#219
• [2017-06-15 00:02] Validation started with lhcb-future-clang#220
• [2017-06-15 00:02] Validation started with lhcb-future#429
• [2017-06-16 00:03] Validation started with lhcb-future-clang#221
• [2017-06-16 00:03] Validation started with lhcb-future#430
• [2017-06-17 00:02] Validation started with lhcb-future-clang#222
• [2017-06-17 00:03] Validation started with lhcb-future#431
• [2017-06-18 00:02] Validation started with lhcb-future-clang#223
• [2017-06-18 00:07] Validation started with lhcb-future#432
• [2017-06-19 00:02] Validation started with lhcb-future#433
• [2017-06-19 00:02] Validation started with lhcb-future-clang#224
• [2017-06-20 00:02] Validation started with lhcb-future#434
• [2017-06-20 00:02] Validation started with lhcb-future-clang#225
• [2017-06-20 10:23] Validation started with lhcb-future#435
• [2017-06-20 14:51] Validation started with lhcb-future#436
• [2017-06-21 00:02] Validation started with lhcb-future#437
• [2017-06-21 00:02] Validation started with lhcb-future-clang#226
• [2017-06-22 00:02] Validation started with lhcb-future-clang#227
• [2017-06-22 00:02] Validation started with lhcb-future#438
• [2017-06-22 09:54] Validation started with lhcb-future#439
• [2017-06-22 17:12] Validation started with lhcb-future#440
• [2017-06-23 00:02] Validation started with lhcb-future-clang#228
• [2017-06-23 00:02] Validation started with lhcb-future#441
• [2017-06-23 11:28] Validation started with lhcb-future#442
• [2017-06-24 00:02] Validation started with lhcb-future-clang#229
• [2017-06-24 00:03] Validation started with lhcb-future#443
• [2017-06-25 00:02] Validation started with lhcb-future-clang#230
• [2017-06-25 00:02] Validation started with lhcb-future#444
• [2017-06-26 00:02] Validation started with lhcb-future#445
• [2017-06-26 00:02] Validation started with lhcb-future-clang#231
• [2017-06-27 00:02] Validation started with lhcb-future#446
• [2017-06-27 00:02] Validation started with lhcb-future-clang#232
• [2017-06-28 00:02] Validation started with lhcb-future-clang#233
• [2017-06-28 00:02] Validation started with lhcb-future#447
• [2017-06-28 14:09] Validation started with lhcb-future#448
• [2017-06-29 00:02] Validation started with lhcb-future-clang#234
• [2017-06-29 00:02] Validation started with lhcb-future#449
• [2017-06-30 00:02] Validation started with lhcb-future-clang#235
• [2017-06-30 00:02] Validation started with lhcb-future#450
• [2017-07-01 00:02] Validation started with lhcb-future#451
• [2017-07-01 00:02] Validation started with lhcb-future-clang#236
• [2017-07-02 00:02] Validation started with lhcb-future#452
• [2017-07-02 00:02] Validation started with lhcb-future-clang#237
• [2017-07-03 00:02] Validation started with lhcb-future-clang#238
• [2017-07-03 00:02] Validation started with lhcb-future#453
• [2017-07-04 00:02] Validation started with lhcb-future#454
• [2017-07-04 00:02] Validation started with lhcb-future-clang#239
• [2017-07-05 00:02] Validation started with lhcb-future#455
• [2017-07-05 00:02] Validation started with lhcb-future-clang#240
• [2017-07-06 00:02] Validation started with lhcb-future#456
• [2017-07-06 00:03] Validation started with lhcb-future-clang#241
• [2017-07-07 00:02] Validation started with lhcb-future#457
• [2017-07-07 00:03] Validation started with lhcb-future-clang#242
• [2017-07-08 00:02] Validation started with lhcb-future-clang#243
• [2017-07-08 00:02] Validation started with lhcb-future#458
• [2017-07-09 00:02] Validation started with lhcb-future-clang#244
• [2017-07-09 00:02] Validation started with lhcb-future#459
• [2017-07-10 00:02] Validation started with lhcb-future#460
• [2017-07-10 00:03] Validation started with lhcb-future-clang#245
• [2017-07-11 00:02] Validation started with lhcb-future-clang#246
• [2017-07-11 00:02] Validation started with lhcb-future#461
• [2017-07-12 00:02] Validation started with lhcb-future-clang#247
• [2017-07-12 00:02] Validation started with lhcb-future#462
• [2017-07-12 13:41] Validation started with lhcb-future#463
• [2017-07-13 00:03] Validation started with lhcb-future-clang#248
• [2017-07-13 00:03] Validation started with lhcb-future#464
• [2017-07-14 00:02] Validation started with lhcb-future#465
• [2017-07-14 00:02] Validation started with lhcb-future-clang#249
• [2017-07-15 00:03] Validation started with lhcb-future#466
• [2017-07-15 00:03] Validation started with lhcb-future-clang#250
• [2017-07-16 00:02] Validation started with lhcb-future-clang#251
• [2017-07-16 00:03] Validation started with lhcb-future#467
• [2017-07-17 00:02] Validation started with lhcb-future#468
• [2017-07-17 00:03] Validation started with lhcb-future-clang#252
• [2017-07-17 12:34] Validation started with lhcb-future#469
• [2017-07-17 12:57] Validation started with lhcb-future#469
• [2017-07-17 13:03] Validation started with lhcb-future#469
• [2017-07-18 00:02] Validation started with lhcb-future-clang#253
• [2017-07-18 00:02] Validation started with lhcb-future#470
• [2017-07-18 15:02] Validation started with lhcb-future#471
• [2017-07-18 15:54] Validation started with lhcb-future#472
• [2017-07-19 00:02] Validation started with lhcb-future#473
• [2017-07-19 00:03] Validation started with lhcb-future-clang#254
• [2017-07-20 00:02] Validation started with lhcb-future-clang#255

assigned to @leggett

this is a pet peeve, but I really don't like std::tie if it's only being used to remove a couple of lines of code. It's not functionally faster than a case statement, and it's MUCH harder to read.

If I compare

    return
      code         < right.code   ? true  :
      right.code   <       code   ? false :
      reason       < right.reason ? true  :
      right.reason <       reason ? false :
      file         < right.file   ? true  :
      right.file   <       file   ? false : line < right.line ;

to

    return std::tie( left.code, left.reason, left.file, left.line )
         < std::tie( right.code, right.reason, right.file, right.line );

I can much easier convince myself that the version using std::tie is actually correct, and implements a proper strict weak ordering.... And you're right that the generated code will be the same (I actually remember checking that on godbolt) -- so I very much prefer the more 'abstract' version with std::tie

ping...

for me everything is fine...

ping...

fine for me

ping...

added 1 commit

• 9d5ae8cb - add support for Gaudi::Property<GaudiMath::Interpolation::Type>

Compare with previous version

added 52 commits

• 9d5ae8cb...878c38fa - 50 commits from branch gaudi:master
• 08cca55c - Modernize GaudiGSL
• 8b368e66 - add support for Gaudi::Property<GaudiMath::Interpolation::Type>

Compare with previous version

added 12 commits

• 8b368e66...f96f51c0 - 10 commits from branch gaudi:master
• ed763b36 - Modernize GaudiGSL
• 4af01610 - add support for Gaudi::Property<GaudiMath::Interpolation::Type>

Compare with previous version

changed the description

assigned to @hegner

changed milestone to %v28r3

approved this merge request

assigned to @clemenci

@graven, can you, please, rebase so that I can merge?

(for some reasons I got the rebase button for !352 (merged), but not for this one)

added 10 commits

• 4af01610...bcdd986d - 8 commits from branch gaudi:master
• d6d43cbf - Modernize GaudiGSL
• 347a94c2 - add support for Gaudi::Property<GaudiMath::Interpolation::Type>

Compare with previous version

@clemenci: done -- strange that you didn't get a rebase button, as it was a clean rebase...

And, as expected, it should be re-approved... this semi-linear history requirement looks to me like a waste of resources...

approved this merge request

enabled an automatic merge when the pipeline for 347a94c2 succeeds

mentioned in commit 6884e49a

merged

mentioned in merge request !377 (merged)

mentioned in merge request lhcb/Rec!716 (merged)