Skip to content
Snippets Groups Projects

Introduce PrecedenceSvc - a service for end-to-end graph-based task precedence management

Merged Introduce PrecedenceSvc - a service for end-to-end graph-based task precedence management
ishapova/Gaudi:prec-cleanup into master
All threads resolved!
Merged Illya Shapoval requested to merge ishapova/Gaudi:prec-cleanup into master
All threads resolved!

This MR begins a series of refactorings in the scheduler domain, targeted at optimization, standardization and new features deployment.

  • introduce a new service - PrecedenceSvc - for self-contained (CF+DF) graph-based task precedence management;
  • the corresponding interface is removed from the Execution Flow Manager (EFM)
  • switch Avalanche Scheduler from the EFM to Precedence Service;
  • Forward Scheduler still uses the EFM based CF management
  • clean up related code accordingly to the above bullets.

IPrecedenceSvc needs further polishing, but this is coupled with other upcoming developments.

Merge request reports

Pipeline #195626 passed

Stage: build
Stage: test
Stage: check

Pipeline passed for fbe3ab3e on ishapova:prec-cleanup

Approved by
Marco Clemencic

Merged by avatar (Apr 23, 2025 7:46pm UTC)

Merge details

  • Changes merged into master with fbe3ab3e.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • L
    Software for LHCb @lhcbsoft ·
    Edited by Software for LHCb
  • Illya Shapoval mentioned in merge request !394 (merged)

    mentioned in merge request !394 (merged)

  • Illya Shapoval resolved all discussions

    resolved all discussions

  • Illya Shapoval
    Illya Shapoval @ishapova ·
    Author Contributor

    pinging

  • Illya Shapoval mentioned in merge request !397 (merged)

    mentioned in merge request !397 (merged)

  • Illya Shapoval added 32 commits

    added 32 commits

    • 8da05de6...f86e7684 - 23 commits from branch gaudi:master
    • 13b48600 - remove obsolete method that assembles a data flow realm without data nodes, and…
    • 8e85ce1b - remove a bunch of obsolete methods related to recursive-based task precedence resolution
    • 609b9ad2 - remove the 'event slots' PRG class data member and cleanup related code
    • 0b614632 - rename PRG's updateDecision() to accept()
    • 833736ad - hide the head node member behind the get method
    • c036398d - add new service: PrecedenceSvc
    • 0dc0ab23 - switch the Avalanche Scheduler to use the new PrecedenceSvc
    • 0474bd8e - add dumpPrecedenceTrace() to the interface and implementation of PrecedenceSvc
    • fbe3ab3e - cleanup ExecutionFlowManager, removing methods unused by the ForwardScheduler

    Compare with previous version

    Toggle commit list
  • Illya Shapoval
    Illya Shapoval @ishapova ·
    Author Contributor

    Rebased to the latest master.

  • Marco Clemencic changed milestone to %v29r0

    changed milestone to %v29r0

  • Marco Clemencic assigned to @clemenci

    assigned to @clemenci

  • Marco Clemencic approved this merge request

    approved this merge request

  • Marco Clemencic merged

    merged

    • Please register or sign in to reply