GaudiKernel - Update VectorClass and hide in namespace

GaudiKernel builds a private version of instrset_detect() copied from the VectorClass package. Whilst the header is not made public, the symbols are compiled into the GaudiKernel linker library and thus available to any downstream users. This means these symbols could conflict with the same ones from a different build of VectorClass, such as the one LHCb privately uses, or the one in the LCG area.

This MR updates the version used to be that from a more recent release, and then uses a new feature in that version to place the symbols inside a namespace Gaudi. This means these symbols then are not in conflict with other usages (unless of course they happen to pick the same namespace...).

Longer term it would be better to use the version from the LCG area. However there is an issue which prevents this now, at least for LHCb, which is the version there is very old 2015-10-24 version 1.16 Whereas the latest is 2017-07-27 version 1.30. There are a number of updates and bug fixes between these two that I think we need in LHCb (clang fixes for instance).

@clemenci @bcouturi Could we request an update in the LCG area for a future release ? The current version is

/cvmfs/sft.cern.ch/lcg/releases/LCG_89/vectorclass/1.16

• [2017-08-22 11:17] Validation started with lhcb-gaudi-merge#194
• [2017-08-23 00:02] Validation started with lhcb-future-clang#290
• [2017-08-23 00:03] Validation started with lhcb-future#510
• [2017-08-24 00:03] Validation started with lhcb-future#511
• [2017-08-24 00:04] Validation started with lhcb-future-clang#291
• [2017-08-25 00:04] Validation started with lhcb-future#512
• [2017-08-25 00:05] Validation started with lhcb-future-clang#292
• [2017-08-26 00:03] Validation started with lhcb-future-clang#293
• [2017-08-26 00:04] Validation started with lhcb-future#513
• [2017-08-27 00:03] Validation started with lhcb-future-clang#294
• [2017-08-27 00:03] Validation started with lhcb-future#514
• [2017-08-28 00:03] Validation started with lhcb-future#515
• [2017-08-28 00:04] Validation started with lhcb-future-clang#295
• [2017-08-29 00:03] Validation started with lhcb-future#516
• [2017-08-30 00:04] Validation started with lhcb-future-clang#297
• [2017-08-30 00:04] Validation started with lhcb-future#517
• [2017-08-30 09:40] Validation started with lhcb-future#518
• [2017-08-31 00:03] Validation started with lhcb-future#519
• [2017-08-31 00:03] Validation started with lhcb-future-clang#298
• [2017-09-01 00:03] Validation started with lhcb-future-clang#299
• [2017-09-01 00:04] Validation started with lhcb-future#520
• [2017-09-01 08:49] Validation started with lhcb-future#521
• [2017-09-02 00:03] Validation started with lhcb-future#522
• [2017-09-02 00:03] Validation started with lhcb-future-clang#300
• [2017-09-03 00:03] Validation started with lhcb-future#523
• [2017-09-03 00:04] Validation started with lhcb-future-clang#301
• [2017-09-04 00:04] Validation started with lhcb-future-clang#302
• [2017-09-04 00:04] Validation started with lhcb-future#524
• [2017-09-05 00:03] Validation started with lhcb-future#525
• [2017-09-05 00:04] Validation started with lhcb-future-clang#303
• [2017-09-06 00:03] Validation started with lhcb-future#526
• [2017-09-06 00:04] Validation started with lhcb-future-clang#304
• [2017-09-07 00:04] Validation started with lhcb-future-clang#305
• [2017-09-07 00:04] Validation started with lhcb-future#527
• [2017-09-08 00:03] Validation started with lhcb-future#528
• [2017-09-08 00:03] Validation started with lhcb-future-clang#306
• [2017-09-09 00:03] Validation started with lhcb-future-clang#307
• [2017-09-09 00:03] Validation started with lhcb-future#529
• [2017-09-10 00:03] Validation started with lhcb-future#530
• [2017-09-10 00:04] Validation started with lhcb-future-clang#308
• [2017-09-11 00:03] Validation started with lhcb-future#531
• [2017-09-11 00:04] Validation started with lhcb-future-clang#309
• [2017-09-12 00:04] Validation started with lhcb-future#532
• [2017-09-12 00:04] Validation started with lhcb-future-clang#310
• [2017-09-13 00:03] Validation started with lhcb-future#533
• [2017-09-13 00:04] Validation started with lhcb-future-clang#311
• [2017-09-14 00:03] Validation started with lhcb-future#534
• [2017-09-14 00:04] Validation started with lhcb-future-clang#312
• [2017-09-15 00:03] Validation started with lhcb-future-clang#313
• [2017-09-15 00:03] Validation started with lhcb-future#535
• [2017-09-16 00:02] Validation started with lhcb-future#536
• [2017-09-16 00:03] Validation started with lhcb-future-clang#314
• [2017-09-17 00:03] Validation started with lhcb-future-clang#315
• [2017-09-17 00:03] Validation started with lhcb-future#537
• [2017-09-18 00:03] Validation started with lhcb-future#538
• [2017-09-18 00:04] Validation started with lhcb-future-clang#316
• [2017-09-19 00:03] Validation started with lhcb-future#539
• [2017-09-19 00:03] Validation started with lhcb-future-clang#317
• [2017-09-20 00:02] Validation started with lhcb-future-clang#318
• [2017-09-20 00:03] Validation started with lhcb-future#540
• [2017-09-21 00:02] Validation started with lhcb-future-clang#319
• [2017-09-21 00:03] Validation started with lhcb-future#541
• [2017-09-22 00:02] Validation started with lhcb-future#542
• [2017-09-22 00:03] Validation started with lhcb-future-clang#320
• [2017-09-23 00:03] Validation started with lhcb-future-clang#321
• [2017-09-23 00:04] Validation started with lhcb-future#543
• [2017-09-24 00:03] Validation started with lhcb-future-clang#322
• [2017-09-24 00:04] Validation started with lhcb-future#544
• [2017-09-25 00:02] Validation started with lhcb-future#545
• [2017-09-25 00:02] Validation started with lhcb-future-clang#323

changed the description

mentioned in merge request lhcb/LHCb!856 (merged)

I created SPI-989 to ask for the upgrade in LCG.

changed milestone to %v29r0

assigned to @hegner

@hegner, please, squash it when you merge.

I'd like to wait for Patricia's answer to the request of updating

The version of VectorClass in LCG dev4 has been upgraded, so it will be in LCG 91.

I see what needs to be done to use that instead of the one in Gaudi, then we decide.

mentioned in merge request !403 (merged)

approved this merge request

assigned to @clemenci

merged

mentioned in commit 7586df31