ApplicationMgr Return Code Fixes, master branch (2017.09.14.)

Making ApplicationMgr::i_startup() return a failure code in all cases when an error is detected. Previously it could in some cases return StatusCode::SUCCESS right after printing a FATAL message. In cases where the error was determined not based on a status code, but on some other condition. Making the sc variable actually be a success code in those instances.

This is a follow-up from !384 (merged), making sure that the issue found in there would not be lost.

• [2017-09-14 10:01] Validation started with lhcb-gaudi-merge#203

I don't want to be too annoying with this, but how is the GitLab CI test at all relevant/useful if it always fails, even on the simplest things? It's quite upsetting to make some change in the code, and then see the CI say that it doesn't build. I can't even see why it failed...

https://gitlab.cern.ch/akraszna/GaudiGaudi/-/jobs/567979

Did I miss setting up something on my fork of the repository?

I do not know what's wrong in your configuration.

Make sure you enable shared runners. This was not working in the past, but changed recently.

assigned to @clemenci

changed milestone to %v29r0

approved this merge request

Apparently that was indeed not enabled on my fork yet. Weird...

Apparently I was able to re-launch the CI job. Let's see what comes out of it this time around...

enabled an automatic merge when the pipeline for 477b5218 succeeds

merged

mentioned in commit f86e7684