Skip to content
Snippets Groups Projects

Modernize FileMgr

Merged Gerhard Raven requested to merge graven/Gaudi:modernize-filemgr into master
All threads resolved!
  • prefer optional over unique_ptr to make a nullable type, and avoid heap-allocation of RootFileHandler and POSIXFileHandler
  • better implementation of select1st,select2nd
  • prefer value-semantics implementation of get_bit and set_bit

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • ...and aside from this comment about code duplication, I'm fine with this MR.

  • assigned to @hegner

  • Benedikt Hegner changed milestone to %v30r0

    changed milestone to %v30r0

  • Benedikt Hegner approved this merge request

    approved this merge request

  • Benedikt Hegner resolved all discussions

    resolved all discussions

  • Benedikt Hegner mentioned in commit 697e2e94

    mentioned in commit 697e2e94

  • Please register or sign in to reply
    Loading