Skip to content
Snippets Groups Projects

Remove unnecessary long/StatusCode conversions

Merged Remove unnecessary long/StatusCode conversions
fwinkl/Gaudi:StatusCode_cleanup into master
Merged Frank Winklmeier requested to merge fwinkl/Gaudi:StatusCode_cleanup into master
  1. Nov 15, 2017
    • Frank Winklmeier's avatar
      Remove implicit StatusCode casts · ec3d2ff1
      Frank Winklmeier authored 
      Remove a few more trivial implicit bool/long casts of StatusCode. No
functional difference of the code.
      ec3d2ff1
    • Frank Winklmeier's avatar
      Remove unnecessary long/StatusCode conversions · ae4e372e
      Frank Winklmeier authored 
      In preparation for a larger re-design of StatusCode clean up a few
places where the code unnecessarily relies on an implicit long
type-conversion. In detail:

- ObjectVector::remove: Return the index of the deleted object as
  documented in the base class. Before it always returned 1
- RegistryEntry: Change return type of some methods from long to
  StautsCode
- IODataManager: Get rid of the S_OK/S_ERROR enum alias as this relies
  on the actual type of the StatusCode enums
- RootDataConnection: Change return type of setCompression from
  long to StatusCode
      ae4e372e