Modernize HiveSlimEventLoopMgr

• prefer STL algorithm over raw loops
• prefer inheriting constructor
• remove redundant (virtual) destructor
• add final
• remove SVN identifiers
• prefer std::make_unique over new
• prefer && instead of and, || instead of or, ! instead of not
• fix typo in variable name
• prefer nullptr over 0

added 11 commits

• adb0e7c5...c919700c - 10 commits from branch gaudi:master
• 3d388e70 - Modernize HiveSlimEventLoopMgr

Compare with previous version

• [2017-11-17 17:37] Validation started with lhcb-gaudi-merge#311
• [2017-11-17 19:22] Validation started with lhcb-gaudi-merge#313
• [2017-11-18 00:02] Validation started with lhcb-future-clang#379
• [2017-11-18 00:02] Validation started with lhcb-future#605
• [2017-11-18 00:03] Validation started with lhcb-gaudi-head#1662
• [2017-11-19 00:02] Validation started with lhcb-gaudi-head#1663
• [2017-11-19 00:03] Validation started with lhcb-future-clang#380
• [2017-11-19 00:03] Validation started with lhcb-future#606
• [2017-11-20 00:02] Validation started with lhcb-future-clang#381
• [2017-11-20 00:03] Validation started with lhcb-future#607
• [2017-11-20 00:04] Validation started with lhcb-gaudi-head#1664
• [2017-11-20 17:17] Validation started with lhcb-gaudi-head#734
• [2017-11-20 17:22] Validation started with lhcb-gaudi-head#734
• [2017-11-20 17:27] Validation started with lhcb-gaudi-head#734
• [2017-11-20 19:09] Validation started with lhcb-gaudi-head#734
• [2017-11-20 19:36] Validation started with lhcb-gaudi-head#734
• [2017-11-20 19:59] Validation started with lhcb-gaudi-head#734
• [2017-11-21 00:03] Validation started with lhcb-gaudi-head#1665
• [2017-11-21 00:03] Validation started with lhcb-future#608
• [2017-11-21 00:04] Validation started with lhcb-future-clang#382
• [2017-11-21 09:50] Validation started with lhcb-gaudi-head#734
• [2017-11-21 10:18] Validation started with lhcb-gaudi-head#734
• [2017-11-22 00:02] Validation started with lhcb-future-clang#383
• [2017-11-22 00:02] Validation started with lhcb-gaudi-head#1666
• [2017-11-22 00:02] Validation started with lhcb-future#609
• [2017-11-23 00:02] Validation started with lhcb-future#610
• [2017-11-23 00:02] Validation started with lhcb-gaudi-head#1667
• [2017-11-23 00:02] Validation started with lhcb-future-clang#384
• [2017-11-24 00:03] Validation started with lhcb-future-clang#385
• [2017-11-24 00:03] Validation started with lhcb-gaudi-head#1668
• [2017-11-24 00:04] Validation started with lhcb-future#611
• [2017-11-25 00:02] Validation started with lhcb-future#612
• [2017-11-25 00:02] Validation started with lhcb-gaudi-head#1669
• [2017-11-25 00:03] Validation started with lhcb-future-clang#386
• [2017-11-26 00:03] Validation started with lhcb-future#613
• [2017-11-26 00:03] Validation started with lhcb-gaudi-head#1670
• [2017-11-26 00:03] Validation started with lhcb-future-clang#387
• [2017-11-27 00:03] Validation started with lhcb-gaudi-head#1671
• [2017-11-27 00:04] Validation started with lhcb-future#614
• [2017-11-27 00:04] Validation started with lhcb-future-clang#388
• [2017-11-27 12:43] Validation started with lhcb-gaudi-head#1672
• [2017-11-27 15:24] Validation started with lhcb-gaudi-head#1672
• [2017-11-28 00:03] Validation started with lhcb-future#615
• [2017-11-28 00:04] Validation started with lhcb-gaudi-head#1673
• [2017-11-28 00:04] Validation started with lhcb-future-clang#389
• [2017-11-28 12:24] Validation started with lhcb-gaudi-head#1674

marked as a Work In Progress

changed the description

added 1 commit

• 6c9b3067 - Modernize HiveSlimEventLoopMgr

Compare with previous version

added 1 commit

• 9478c7f1 - Modernize HiveSlimEventLoopMgr

Compare with previous version

unmarked as a Work In Progress

approved this merge request

assigned to @hegner

changed milestone to %v30r1

merged

mentioned in commit bb342d3c

@graven, this is clashing heavily with all the scheduler fixes that I've done... Next time, can you wait that the known ongoing development on a given part is over before "modernizing" it ? Thanks !

added code cleanup label