Modernize constructors and destructors (!515) · Merge requests · Gaudi / Gaudi · GitLab

Snippets Groups Projects

Merged Gerhard Raven requested to merge graven/Gaudi:cleanuo-gaudialg into master 7 years ago

remove destructors qualified with 'override = default' or 'override = {}'
prefer inheriting constructors
and some formatting tweaks...

Edited 7 years ago by Gerhard Raven

Activity

L
Software for LHCb @lhcbsoft · 7 years ago
[2017-11-17 19:52] Validation started with lhcb-gaudi-merge#314

[2017-11-18 00:02] Validation started with lhcb-future-clang#379

[2017-11-18 00:03] Validation started with lhcb-future#605

[2017-11-18 00:03] Validation started with lhcb-gaudi-head#1662

[2017-11-18 11:12] Validation started with lhcb-gaudi-merge#315

[2017-11-19 00:03] Validation started with lhcb-gaudi-head#1663

[2017-11-19 00:03] Validation started with lhcb-future-clang#380

[2017-11-19 00:03] Validation started with lhcb-future#606

[2017-11-20 00:03] Validation started with lhcb-future-clang#381

[2017-11-20 00:03] Validation started with lhcb-future#607

[2017-11-20 00:04] Validation started with lhcb-gaudi-head#1664

[2017-11-20 17:17] Validation started with lhcb-gaudi-head#734

[2017-11-20 17:22] Validation started with lhcb-gaudi-head#734

[2017-11-20 17:27] Validation started with lhcb-gaudi-head#734

[2017-11-20 19:09] Validation started with lhcb-gaudi-head#734

[2017-11-20 19:36] Validation started with lhcb-gaudi-head#734

[2017-11-20 19:59] Validation started with lhcb-gaudi-head#734

[2017-11-21 00:03] Validation started with lhcb-gaudi-head#1665

[2017-11-21 00:03] Validation started with lhcb-future#608

[2017-11-21 00:04] Validation started with lhcb-future-clang#382

[2017-11-21 09:50] Validation started with lhcb-gaudi-head#734

[2017-11-21 10:18] Validation started with lhcb-gaudi-head#734

[2017-11-22 00:02] Validation started with lhcb-future-clang#383

[2017-11-22 00:02] Validation started with lhcb-future#609

[2017-11-23 00:02] Validation started with lhcb-future#610

[2017-11-23 00:02] Validation started with lhcb-gaudi-head#1667

[2017-11-23 00:03] Validation started with lhcb-future-clang#384

[2017-11-24 00:03] Validation started with lhcb-future-clang#385

[2017-11-24 00:03] Validation started with lhcb-gaudi-head#1668

[2017-11-24 00:04] Validation started with lhcb-future#611

[2017-11-25 00:02] Validation started with lhcb-gaudi-head#1669

[2017-11-25 00:03] Validation started with lhcb-future-clang#386

[2017-11-26 00:03] Validation started with lhcb-future#613

[2017-11-26 00:03] Validation started with lhcb-future-clang#387

[2017-11-26 00:03] Validation started with lhcb-gaudi-head#1670

[2017-11-27 00:04] Validation started with lhcb-gaudi-head#1671

[2017-11-27 00:04] Validation started with lhcb-future#614

[2017-11-27 00:04] Validation started with lhcb-future-clang#388

[2017-11-27 12:43] Validation started with lhcb-gaudi-head#1672

[2017-11-27 15:24] Validation started with lhcb-gaudi-head#1672

[2017-11-28 00:03] Validation started with lhcb-future#615

[2017-11-28 00:04] Validation started with lhcb-gaudi-head#1673

[2017-11-28 00:04] Validation started with lhcb-future-clang#389

[2017-11-28 12:24] Validation started with lhcb-gaudi-head#1674

Edited 7 years ago by Software for LHCb
Gerhard Raven added 1 commit 7 years ago
added 1 commit

b3ce39cf - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

cd67302b - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

6d99b42c - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

aa38e2ad - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

3a163601 - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

80fc261b - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

8dbb25cc - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

09a796d5 - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

d2ff9d23 - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

93e32595 - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

93e32595 - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

afd120cd - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

bf262d23 - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

265bc6c0 - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

70b8c016 - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

ee0760d7 - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

ee0760d7 - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

5f576c8a - remove destructors qualified with 'override = default'

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

56f9c83b - remove destructors qualified with 'override = default'

Compare with previous version
Marco Clemencic marked as a Work In Progress 7 years ago

marked as a Work In Progress

Marco Clemencic @clemenci · 7 years ago

Owner

.../GaudiKernel/src/Lib/DataStreamTool.cpp:24:108: error: definition of implicitly-declared 'DataStreamTool::DataStreamTool(const string&, const string&, const IInterface*)'
DataStreamTool::DataStreamTool( const std::string& type, const std::string& name, const IInterface* parent )
                                                                                                           ^

G

Gerhard Raven @graven · 7 years ago

Author Developer

already fixed, see https://gitlab.cern.ch/gaudi/Gaudi/merge_requests/515/diffs?diff_id=113916&start_sha=265bc6c080e9cfdf0e138f8eaa02ccdf6e6cd70c... (otherwise, the pipeline wouldn't be green now)
Gerhard Raven unmarked as a Work In Progress 7 years ago

unmarked as a Work In Progress
Gerhard Raven added 1 commit 7 years ago
added 1 commit

ddf1a7d3 - Modernize constructors and destructors

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

1a03cb95 - Modernize constructors and destructors

Compare with previous version
Gerhard Raven changed title from remove destructors qualified with 'override = default' to Modernize constructors and destructors 7 years ago

changed title from remove destructors qualified with 'override = default' to Modernize constructors and destructors
Gerhard Raven changed the description 7 years ago

changed the description
Gerhard Raven added 1 commit 7 years ago
added 1 commit

882409c1 - Modernize constructors and destructors

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

aa66ebd4 - Modernize constructors and destructors

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

798fd725 - Modernize constructors and destructors

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

325ff2cf - Modernize constructors and destructors

Compare with previous version
Marco Cattaneo mentioned in merge request lhcb/Rec!794 (merged) 7 years ago

mentioned in merge request lhcb/Rec!794 (merged)
Marco Cattaneo mentioned in merge request lhcb/Brunel!313 (merged) 7 years ago

mentioned in merge request lhcb/Brunel!313 (merged)
Gerhard Raven added 2 commits 7 years ago
added 2 commits

2f25dc75 - prefer inherited constructor

1c9a1c0f - prefer inherited constructor, remove destructor

Compare with previous version
Gerhard Raven added 1 commit 7 years ago
added 1 commit

0e050f92 - prefer inherited constructor, remove destructor

Compare with previous version
Gerhard Raven added 18 commits 7 years ago
added 18 commits

0e050f92...0b30075f - 16 commits from branch gaudi:master

4aa9d87d - Modernize constructors and destructors

5fca4769 - prefer inherited constructor, remove destructor

Compare with previous version
Gerhard Raven added 18 commits 7 years ago
added 18 commits

0e050f92...0b30075f - 16 commits from branch gaudi:master

4aa9d87d - Modernize constructors and destructors

5fca4769 - prefer inherited constructor, remove destructor

Compare with previous version
Benedikt Hegner approved this merge request 7 years ago

approved this merge request
Benedikt Hegner changed milestone to %v30r1 7 years ago

changed milestone to %v30r1
Benedikt Hegner assigned to @hegner 7 years ago

assigned to @hegner
Benedikt Hegner merged 7 years ago

merged
Benedikt Hegner mentioned in commit 8b800035 7 years ago

mentioned in commit 8b800035
Marco Cattaneo mentioned in commit lhcb/Rec@e6175935 7 years ago

mentioned in commit lhcb/Rec@e6175935
Marco Cattaneo mentioned in commit lhcb/Brunel@8ad44030 7 years ago

mentioned in commit lhcb/Brunel@8ad44030
Marco Clemencic added code cleanup label 7 years ago

added code cleanup label

Please register or sign in to reply