GaudiAlg FunctionalDetails apply range size check in debug builds only

Following a discussion with @graven last week during the LHCb S/W workshop, where we discussed the idea that runtime sanity checks should only be applied in debug builds, and the optimised release builds should skip them as far as possible, this MR protects the runtime container size check used by the range zipping utilities to only be applied in debug builds (i.e. when NDEBUG is not defined.).

GaudiAlg/GaudiAlg/FunctionalDetails.h

@@ -84,8 +84,9 @@ namespace Gaudi
         template <typename... Args>
         inline decltype( auto ) range( Args&&... args )
         {
-          // assert( check_sizes( args... ) );
+#ifndef NDEBUG
           verifySizes( args... );
+#endif
           return ranges::view::zip( std::forward<Args>( args )... );
         }
 
@@ -93,8 +94,9 @@ namespace Gaudi
         template <typename... Args>
         inline decltype( auto ) const_range( Args&&... args )
         {
-          // assert( check_sizes( args... ) );
+#ifndef NDEBUG
           verifySizes( args... );
+#endif
           return ranges::view::const_( ranges::view::zip( std::forward<Args>( args )... ) );
         }
       }