[[ deprecated ]] does not compile with using statements

[[deprecated]] is incompatible with using statements (at least for me with gcc62 and gcc7). Building this header alone (i.e. a one-line cpp file that does only the include) results in an error instead of the desired warning:

In file included from GaudiKernel/GaudiKernel/GaudiKernel/DataObjIDProperty.h.cpp:1:0:
../GaudiKernel/GaudiKernel/DataObjIDProperty.h:7:77: error: expected unqualified-id before 'using'
 [[deprecated( "replace DataObjIDProperty by Gaudi::Property<DataObjID>" )]] using DataObjIDProperty =
                                                                             ^~~~~
../GaudiKernel/GaudiKernel/DataObjIDProperty.h:9:85: error: expected unqualified-id before 'using'
 [[deprecated( "replace DataObjIDCollProperty by Gaudi::Property<DataObjIDColl>" )]] using DataObjIDCollProperty =
                                                                                     ^~~~~

With a typedef and an instantiation, one receives the desired warning

GaudiKernel/GaudiKernel/GaudiKernel/DataObjIDProperty.h.cpp:3:23: warning: 'DataObjIDCollProperty' is deprecated: replace DataObjIDCollProperty by Gaudi::Property<DataObjIDColl> [-Wdeprecated-declarations]
 DataObjIDCollProperty a;
                       ^
In file included from GaudiKernel/GaudiKernel/GaudiKernel/DataObjIDProperty.h.cpp:1:0:
../GaudiKernel/GaudiKernel/DataObjIDProperty.h:8:124: note: declared here
 [[deprecated( "replace DataObjIDCollProperty by Gaudi::Property<DataObjIDColl>" )]] typedef Gaudi::Property<DataObjIDColl> DataObjIDCollProperty;
                                                                                                                            ^~~~~~~~~~~~~~~~~~~~~

added 1 commit

• 65d44d12 - formating

Compare with previous version

changed the description

cf https://stackoverflow.com/questions/48445867/deprecated-incompatible-with-using-but-compatible-with-typedef

• [2018-01-25 16:07] Validation started with lhcb-gaudi-merge#392
• [2018-01-26 00:05] Validation started with lhcb-gaudi-head-py3#45
• [2018-01-26 00:05] Validation started with lhcb-tdr-test#38
• [2018-01-26 00:07] Validation started with lhcb-gaudi-head#1735
• [2018-01-26 08:43] Validation started with lhcb-gaudi-head#1736
• [2018-01-27 00:04] Validation started with lhcb-gaudi-head-py3#46
• [2018-01-27 00:06] Validation started with lhcb-tdr-test#39
• [2018-01-27 00:08] Validation started with lhcb-gaudi-head#1737
• [2018-01-28 00:05] Validation started with lhcb-gaudi-head-py3#47
• [2018-01-28 00:06] Validation started with lhcb-tdr-test#40
• [2018-01-28 00:08] Validation started with lhcb-gaudi-head#1738
• [2018-01-29 00:04] Validation started with lhcb-gaudi-head-py3#48
• [2018-01-29 00:05] Validation started with lhcb-tdr-test#41
• [2018-01-29 00:09] Validation started with lhcb-gaudi-head#1739

Almost there, just a little bit more clang-format massaging to do :)

if i see it correctly, the pipeline only complains about .py files, which i hadn't touched

I mean i can run a formatter on these, too, but that seems a separate issue to me.

Indeed, that's strange... it looks like another MR managed to get through clang-format's radar (as happened to one of mine before).

@clemenci, any idea of why this might happen?

Same problem as !514 (merged) and !578 (merged). I'll prepare an independent MR to fix it.

formatting fixed with !588 (merged), you can rebase on master

added 4 commits

• 65d44d12...16c30794 - 2 commits from branch gaudi:master
• d9c905a0 - [[ deprecated ]] does not compile with using statements
• 31f63bf6 - formating

Compare with previous version

It is possible to use [[deprecated]] with using -- provided you put it in the right place ;-). See eg. here or try it with your favorite compiler here.

you do realise that you committed it in the wrong place in the first place?

yes ;-)

mentioned in merge request !592 (merged)

changed milestone to %v30r2

assigned to @hegner

approved this merge request

merged

mentioned in commit a7e451ee

added bug fix label