Speed up TimelineSvc

Closes #15 (closed)

added lhcb-tdr-test label

changed the description

warning: emplace_back returning a reference is C++17, so if lhcb-gaudi-head or lhcb-tdr-test uses gcc 6.2 and c++14, this won't compile, as one cannot dereference void...

good that m_events is tbb:concurrent_vector and not std::vector, and emplace_back returns an iterator.

This in fact breaks compilation with clang50:

error: no member named 'emplace_back' in 'tbb::concurrent_vector<TimelineEvent, tbb::cache_aligned_allocator<TimelineEvent> >'
  TimelineRecorder recorder{*m_events.emplace_back(), std::move( alg ), ctx};
                             ~~~~~~~~ ^

See https://lhcb-nightlies.cern.ch/logs/build/nightly/lhcb-clang-test/909/x86_64-centos7-clang50-opt/Gaudi/

It would be good if a fix could be provided in Gaudi/master ASAP

resolved all discussions

added 2 commits

• dc4556a1 - Speed up TimelineSvc
• 28ceb480 - Removed ITimelineSvc::registerTimelineEvent

Compare with previous version

• [2018-03-01 00:06] Validation started with lhcb-tdr-test#74
• [2018-03-01 00:12] Validation started with lhcb-gaudi-head#1784
• [2018-03-01 13:04] Validation started with lhcb-gaudi-merge#437
• [2018-03-01 13:05] Validation started with lhcb-upgrade-hackathon#40
• [2018-03-02 00:05] Validation started with lhcb-gaudi-head-py3#80
• [2018-03-02 00:06] Validation started with lhcb-upgrade-hackathon#41
• [2018-03-02 00:06] Validation started with lhcb-tdr-test#75
• [2018-03-02 00:10] Validation started with lhcb-gaudi-head#1785
• [2018-03-02 09:45] Validation started with lhcb-upgrade-hackathon#42
• [2018-03-03 00:03] Validation started with lhcb-gaudi-head-py3#81
• [2018-03-03 00:04] Validation started with lhcb-upgrade-hackathon#43
• [2018-03-03 00:05] Validation started with lhcb-tdr-test#76
• [2018-03-03 00:10] Validation started with lhcb-gaudi-head#1786
• [2018-03-03 09:56] Validation started with lhcb-gaudi-head#1787
• [2018-03-04 00:04] Validation started with lhcb-upgrade-hackathon#44
• [2018-03-04 00:05] Validation started with lhcb-gaudi-head-py3#82
• [2018-03-04 00:05] Validation started with lhcb-tdr-test#77
• [2018-03-04 00:06] Validation started with lhcb-gaudi-head#1788
• [2018-03-05 00:04] Validation started with lhcb-gaudi-head-py3#83
• [2018-03-05 00:08] Validation started with lhcb-upgrade-hackathon#45
• [2018-03-05 00:10] Validation started with lhcb-gaudi-head#1789
• [2018-03-05 00:10] Validation started with lhcb-tdr-test#78
• [2018-03-06 00:03] Validation started with lhcb-gaudi-head-py3#84
• [2018-03-06 00:04] Validation started with lhcb-upgrade-hackathon#46
• [2018-03-06 00:07] Validation started with lhcb-tdr-test#79
• [2018-03-06 00:08] Validation started with lhcb-gaudi-head#1790
• [2018-03-07 00:05] Validation started with lhcb-gaudi-head-py3#85
• [2018-03-07 00:05] Validation started with lhcb-upgrade-hackathon#47
• [2018-03-07 00:06] Validation started with lhcb-tdr-test#80
• [2018-03-07 00:13] Validation started with lhcb-gaudi-head#1791
• [2018-03-07 14:24] Validation started with lhcb-tdr-test#81
• [2018-03-08 00:04] Validation started with lhcb-upgrade-hackathon#48
• [2018-03-08 00:04] Validation started with lhcb-gaudi-head-py3#86
• [2018-03-08 00:06] Validation started with lhcb-tdr-test#82
• [2018-03-08 00:10] Validation started with lhcb-gaudi-head#1792
• [2018-03-09 00:05] Validation started with lhcb-gaudi-head-py3#87
• [2018-03-09 00:07] Validation started with lhcb-upgrade-hackathon#49
• [2018-03-09 00:08] Validation started with lhcb-tdr-test#83
• [2018-03-09 00:11] Validation started with lhcb-gaudi-head#1793
• [2018-03-10 00:04] Validation started with lhcb-upgrade-hackathon#50
• [2018-03-10 00:07] Validation started with lhcb-gaudi-head-py3#88
• [2018-03-10 00:09] Validation started with lhcb-tdr-test#84
• [2018-03-10 00:11] Validation started with lhcb-gaudi-head#1794
• [2018-03-10 00:46] Validation started with lhcb-tdr-test#84
• [2018-03-11 00:05] Validation started with lhcb-upgrade-hackathon#51
• [2018-03-11 00:06] Validation started with lhcb-gaudi-head-py3#89
• [2018-03-11 00:07] Validation started with lhcb-tdr-test#85
• [2018-03-11 00:11] Validation started with lhcb-gaudi-head#1795
• [2018-03-12 00:06] Validation started with lhcb-gaudi-head-py3#90
• [2018-03-12 00:07] Validation started with lhcb-upgrade-hackathon#52
• [2018-03-12 00:07] Validation started with lhcb-tdr-test#86
• [2018-03-12 00:15] Validation started with lhcb-gaudi-head#1796
• [2018-03-13 00:06] Validation started with lhcb-gaudi-head-py3#91
• [2018-03-13 00:07] Validation started with lhcb-upgrade-hackathon#53
• [2018-03-13 00:09] Validation started with lhcb-tdr-test#87
• [2018-03-13 00:10] Validation started with lhcb-gaudi-head#1797
• [2018-03-14 00:04] Validation started with lhcb-gaudi-head-py3#92
• [2018-03-14 00:05] Validation started with lhcb-upgrade-hackathon#54
• [2018-03-14 00:09] Validation started with lhcb-tdr-test#88
• [2018-03-14 00:11] Validation started with lhcb-gaudi-head#1798
• [2018-03-15 00:04] Validation started with lhcb-gaudi-head-py3#93
• [2018-03-15 00:08] Validation started with lhcb-tdr-test#89
• [2018-03-15 00:20] Validation started with lhcb-gaudi-head#1799
• [2018-03-16 00:05] Validation started with lhcb-gaudi-head-py3#94
• [2018-03-16 00:06] Validation started with lhcb-tdr-test#90
• [2018-03-16 00:08] Validation started with lhcb-gaudi-head#1800
• [2018-03-16 08:02] Validation started with lhcb-gaudi-head#1801

mentioned in merge request !610 (merged)

mentioned in issue #15 (closed)

unmarked as a Work In Progress

added 2 commits

• 40d82b4e - Speed up TimelineSvc
• e72f7268 - Removed ITimelineSvc::registerTimelineEvent

Compare with previous version

assigned to @leggett

added To Do label

merged