Remove DataHandle::commit()

From discussion with @leggett on !462 (merged), it seems like the DataHandle::commit() functionality is not used, and that using it is not envisioned anymore. I would thus tentatively propose to remove it.

Can you try this commit in your respective experiment frameworks and tell me how well it goes?

added 90 commits

• b969124e...9eca68f7 - 89 commits from branch gaudi:master
• f9e23eb4 - Try to disable DataHandle::commit()

Compare with previous version

unmarked as a Work In Progress

changed title from WIP: Try to disable DataHandle::commit() to DO NOT MERGE: Try to disable DataHandle::commit()

changed the description

Rebased and re-tested. Un-wipping to check if the LHCb nightlies can withstand these changes. Please do not merge yet...

• [2018-03-27 14:04] Validation started with lhcb-gaudi-merge#471
• [2018-03-28 00:03] Validation started with lhcb-gaudi-head-py3#106
• [2018-03-28 00:08] Validation started with lhcb-tdr-test#102
• [2018-03-28 00:13] Validation started with lhcb-gaudi-head#1814
• [2018-03-29 00:05] Validation started with lhcb-gaudi-head-py3#107
• [2018-03-29 00:06] Validation started with lhcb-gaudi-head#1815
• [2018-03-29 00:08] Validation started with lhcb-tdr-test#103
• [2018-03-29 10:01] Validation started with lhcb-gaudi-head#1816
• [2018-03-30 00:07] Validation started with lhcb-gaudi-head-py3#108
• [2018-03-30 00:08] Validation started with lhcb-tdr-test#104
• [2018-03-30 00:14] Validation started with lhcb-gaudi-head#1817
• [2018-03-30 02:42] Validation started with lhcb-tdr-test#104
• [2018-03-30 04:03] Validation started with lhcb-tdr-test#104
• [2018-03-31 00:04] Validation started with lhcb-gaudi-head-py3#109
• [2018-03-31 00:07] Validation started with lhcb-tdr-test#105
• [2018-03-31 00:08] Validation started with lhcb-gaudi-head#1818
• [2018-04-01 00:05] Validation started with lhcb-gaudi-head-py3#110
• [2018-04-01 00:07] Validation started with lhcb-tdr-test#106
• [2018-04-01 00:07] Validation started with lhcb-gaudi-head#1819
• [2018-04-02 00:05] Validation started with lhcb-gaudi-head-py3#111
• [2018-04-02 00:07] Validation started with lhcb-tdr-test#107
• [2018-04-02 00:08] Validation started with lhcb-gaudi-head#1820
• [2018-04-03 00:04] Validation started with lhcb-gaudi-head-py3#112
• [2018-04-03 00:07] Validation started with lhcb-tdr-test#108
• [2018-04-03 00:07] Validation started with lhcb-gaudi-head#1821
• [2018-04-04 00:05] Validation started with lhcb-gaudi-head-py3#113
• [2018-04-04 00:06] Validation started with lhcb-tdr-test#109
• [2018-04-04 00:08] Validation started with lhcb-gaudi-head#1822
• [2018-04-05 00:04] Validation started with lhcb-gaudi-head-py3#114
• [2018-04-05 00:07] Validation started with lhcb-gaudi-head#1823
• [2018-04-05 00:09] Validation started with lhcb-tdr-test#110
• [2018-04-06 00:06] Validation started with lhcb-gaudi-head-py3#115
• [2018-04-06 00:12] Validation started with lhcb-gaudi-head#1824
• [2018-04-06 00:20] Validation started with lhcb-tdr-test#111
• [2018-04-07 00:04] Validation started with lhcb-gaudi-head-py3#116
• [2018-04-07 00:06] Validation started with lhcb-tdr-test#112
• [2018-04-07 00:09] Validation started with lhcb-gaudi-head#1825
• [2018-04-08 00:04] Validation started with lhcb-gaudi-head-py3#117
• [2018-04-08 00:09] Validation started with lhcb-tdr-test#113
• [2018-04-08 00:09] Validation started with lhcb-gaudi-head#1826
• [2018-04-09 00:05] Validation started with lhcb-gaudi-head-py3#118
• [2018-04-09 00:07] Validation started with lhcb-tdr-test#114
• [2018-04-09 00:10] Validation started with lhcb-gaudi-head#1827
• [2018-04-10 00:03] Validation started with lhcb-gaudi-head-py3#119
• [2018-04-10 00:06] Validation started with lhcb-tdr-test#115
• [2018-04-10 00:08] Validation started with lhcb-gaudi-head#1828
• [2018-04-11 00:06] Validation started with lhcb-gaudi-head-py3#120
• [2018-04-11 00:06] Validation started with lhcb-tdr-test#116
• [2018-04-11 00:44] Validation started with lhcb-gaudi-head#1829
• [2018-04-11 01:33] Validation started with lhcb-gaudi-head-py3#120
• [2018-04-11 09:32] Validation started with lhcb-gaudi-head#1829
• [2018-04-12 00:04] Validation started with lhcb-gaudi-head-py3#121
• [2018-04-12 00:07] Validation started with lhcb-tdr-test#117
• [2018-04-12 00:10] Validation started with lhcb-gaudi-head#1830
• [2018-04-12 10:31] Validation started with lhcb-gaudi-head#1831

To my untrained eye, this looks fine.

• The numerical error/warning/test diff w.r.t. the previous build ranges from quiet to positive.
• Since this MR removes some C++ API surface, I would expect usage of the old APIs to result in build errors. But I have reviewed all the build errors in this build and none of them seems to relate to this MR.

So I think that on the LHCb side at least, this is ready to merge.

@leggett Can you check if this works on the ATLAS side as well?

This looks ok on the ATLAS end.

approved this merge request

changed title from DO NOT MERGE: Try to disable DataHandle::commit() to Disable DataHandle::commit()

Let's mark this as mergeable then :)

added C++ framework label

assigned to @clemenci

changed milestone to %v30r3

added 15 commits

• f9e23eb4...ab1a967b - 14 commits from branch gaudi:master
• 3699208f - Try to disable DataHandle::commit()

Compare with previous version

added 1 commit

• 168f0edd - Maybe just removing the code is fine

Compare with previous version

mentioned in merge request !462 (merged)

changed title from Disable DataHandle::commit() to Remove DataHandle::commit()

changed the description

added 13 commits

• 168f0edd...e1b5afb1 - 11 commits from branch gaudi:master
• a844406f - Try to disable DataHandle::commit()
• b9ff7b14 - Maybe just removing the code is fine

Compare with previous version

resolved all discussions

added 1 commit

• 74301974 - Fixed formatting

Compare with previous version

Thanks for the new formatting one-liner @clemenci! It's very convenient.

approved this merge request

merged

mentioned in commit 8d6c9e40