Resolve "KeyedContainer move constructor does not preserve object version" (!662) · Merge requests · Gaudi / Gaudi · GitLab

Snippets Groups Projects

Merged Marco Clemencic requested to merge 27-fix-keyedcontainer-move into v29-patches 7 years ago

1 unresolved thread

Closes #27 (closed)

Edited 7 years ago by Marco Clemencic

Activity

Marco Clemencic added 7 commits 7 years ago
added 7 commits

fa547fc2...c0fdddd5 - 6 commits from branch v29-patches

12ceccf8 - Add test of version propagation in KeyedContainer move (#27 (closed))

Compare with previous version
Marco Clemencic unmarked as a Work In Progress 7 years ago

unmarked as a Work In Progress
Marco Clemencic assigned to @clemenci 7 years ago

assigned to @clemenci
L
Software for LHCb @lhcbsoft · 7 years ago
[2018-04-16 15:22] Validation started with lhcb-gaudi-merge#488
Marco Clemencic added 1 commit 7 years ago
added 1 commit

1ec01b33 - Add test and fix of version propagation in KeyedContainer move (#27 (closed))

Compare with previous version
Marco Clemencic merged 7 years ago

merged
Marco Clemencic mentioned in commit ec5bb942 7 years ago

mentioned in commit ec5bb942
Gerhard Raven @graven started a thread on the diff 7 years ago

GaudiKernel/GaudiKernel/KeyedContainer.h

     m_cont.setup( (void*)sptr, (void**)rptr );
+  }
   KeyedContainer( KeyedContainer&& other )
       : m_cont( std::move( other.m_cont ) ), m_sequential( std::move( other.m_sequential ) )
       : ObjectContainerBase( std::move( other ) )

Marco Cattaneo @cattanem commented on commit 1ec01b33 7 years ago

Developer

@clemenci We should propagate this fix also to the 2017-patches LHCb stack. Which I think means making a gaudi/v28-patches branch starting from v28r2

@jonrob do you agree?
Christopher Rob Jones @jonrob · 7 years ago

Contributor

I would agree. Now we know this bug exists, I think it makes sense to fix it for MC productions. The RICH fixes on their own will not do any good without a Gaudi fix as well.
Please register or sign in to reply

Marco Cattaneo mentioned in merge request lhcb/Rec!1007 (merged) 7 years ago

mentioned in merge request lhcb/Rec!1007 (merged)

Marco Clemencic mentioned in merge request !665 (merged) 7 years ago

mentioned in merge request !665 (merged)

Please register or sign in to reply