C++11 modernization changes

Some trivial - and some not so trivial! - changes which take advantage of C++11...

Added 3 commits:

• 8b943457 - Optimize string handling
• fbb01575 - Modernize Message.h
• 4aed1415 - Modernize JobOptionsSvc

Added 2 commits:

• efb489a9 - Message::setFormat: tweak move assignment
• ea7e0da1 - Modernize DataOnDemandSvc

The only concern I have is about commit 7e9d454b (replacement of empty destructors).

In many cases the (virtual) destructors have been moved to the .cpp files to ensure that there was only one implementation of them (instead of several ones reduced to one only at link or load time). Multiple destructor copies imply multiple virtual table copies, which, in some circumstances, break the dynamic_cast.

To be fair:

• we discourage dynamic_cast (even if it is heavily used in several places)
• last time I had a problem was because of a templated class used as a intermediate level in an inheritance tree (very fishy)
• most problems with duplicated symbols may come from Windows, where you need to play with symbol visibility and it may not be trivial to get it right.

So, after all I think your proposal is good.

Now either @hegner or @leggett should comment.

Created GAUDI-1057 to track this merge request.

Added 1 commit:

• a64b913b - Modernize the ParticlePropertySvc / PartPropSvc

All changes make perfect sense to me (modulo the easy mistake of suppressing const'ness w/ auto). In particular the "default" keyword is a good thing IMHO. No premature circumvention of problems which I believe are anyhow fixed in current compilers.

Added 1 commit:

• 38edd30c - use cbegin instead of begin

Added 3 commits:

• 10f2a5c1 - follow up on suggestion from Benedikt and Marco
• a33e1391 - Modernize RootCnv and RootHistCnv
• 79440e63 - Modernize GaudiUtils

Added 1 commit:

• baec33a7 - Modernize GaudiSvc/src/RndmGenSvc

Added 1 commit:

• 598910fc - Modernize GaudiSvc/src/FileMgr

Since you are still having fun with the modernization, I added the Work In Progress prefix so that it does not get applied by mistake while you are still working.

Once you are done (or are reasonably happy, or want some rest), remove the [WIP] from the title.

Added 2 commits:

• 4234bd75 - Modernize GaudiCommonSvc/src/HistorgramSvc
• dcdad636 - Modernize GaudiCommonSvc/src/DataSvc

Added 1 commit:

• 6a3a3e8d - Modernize StreamLogger

Added 1 commit:

• 68a9fca1 - Modernize StreamLogger

Added 1 commit:

• e6e2d4df - Modernize MsgStream

Added 1 commit:

• c53a6da2 - Modernize GaudiAlg/src/components

Added 2 commits:

• c94be208 - Modernize GaudiKernel/HashMap and GaudiKernel/Map
• b07fb554 - Modernize GaudiAlg

Added 1 commit:

• 8365349f - replace a number of trivial constructors with = default as gcc 4.8.4 does not cr…

Added 1 commit:

• bdd9ec85 - Modernize GaudiCommonSvc

Added 3 commits:

• 5724b596 - Map.h: extend 'erase' to return iterator
• 9a7b34bb - FileMgr: add a select2nd functor to streamline the code
• dd5ed2b4 - Modernize GaudiCoreSvc and GaudiAlg