Avoid using a (possibly invalid) EventContext pointer - attempt 2

First version (!719 (merged)) had a bug, but it only became apparent after it was merged and used in Athena. The merge deleted the source branch, so I'm starting again here.

Motivation remains the same: fixing an intermittent issue documented here: https://its.cern.ch/jira/browse/ATEAM-471

An EventContext pointer had the potential to be used after deletion. Since the pointer wasn't really necessary I've refactored the updateStates() method to avoid it.

added 10 commits

• eb934805...e69574e9 - 8 commits from branch gaudi:master
• ceee197b - Merge remote-tracking branch 'upstream/master' into RefactorContextPointerFix
• d2ab4427 - Added the fix - check that sub-slot index corresponds to slot

Compare with previous version

added 10 commits

• eb934805...e69574e9 - 8 commits from branch gaudi:master
• ceee197b - Merge remote-tracking branch 'upstream/master' into RefactorContextPointerFix
• d2ab4427 - Added the fix - check that sub-slot index corresponds to slot

Compare with previous version

added 1 commit

• 80c9857c - Tidy, apply-formatting

Compare with previous version

unmarked as a Work In Progress

changed the description

• [2018-07-26 16:44] Validation started with lhcb-gaudi-merge#549
• [2018-07-27 00:04] Validation started with lhcb-lcg-dev4#598
• [2018-07-27 00:06] Validation started with lhcb-lcg-dev3#599
• [2018-07-27 00:08] Validation started with lhcb-tdr-test#229
• [2018-07-27 00:09] Validation started with lhcb-gaudi-head#1943
• [2018-07-28 00:05] Validation started with lhcb-lcg-dev4#599
• [2018-07-28 00:06] Validation started with lhcb-lcg-dev3#600
• [2018-07-28 00:07] Validation started with lhcb-gaudi-head#1944
• [2018-07-28 00:08] Validation started with lhcb-tdr-test#230
• [2018-07-29 00:05] Validation started with lhcb-lcg-dev4#600
• [2018-07-29 00:06] Validation started with lhcb-tdr-test#231
• [2018-07-29 00:06] Validation started with lhcb-gaudi-head#1945
• [2018-07-30 00:04] Validation started with lhcb-lcg-dev3#602
• [2018-07-30 00:06] Validation started with lhcb-lcg-dev4#601
• [2018-07-30 00:07] Validation started with lhcb-tdr-test#232
• [2018-07-30 00:11] Validation started with lhcb-gaudi-head#1946
• [2018-07-30 15:12] Validation started with lhcb-tdr-test#233
• [2018-07-31 00:03] Validation started with lhcb-lcg-dev4#602
• [2018-07-31 00:06] Validation started with lhcb-lcg-dev3#603
• [2018-07-31 00:07] Validation started with lhcb-gaudi-head#1947
• [2018-07-31 00:08] Validation started with lhcb-tdr-test#234
• [2018-08-01 00:04] Validation started with lhcb-lcg-dev4#603
• [2018-08-01 00:04] Validation started with lhcb-lcg-dev3#604
• [2018-08-01 00:06] Validation started with lhcb-gaudi-head#1948
• [2018-08-01 00:08] Validation started with lhcb-tdr-test#235
• [2018-08-01 10:09] Validation started with lhcb-tdr-test#236
• [2018-08-02 00:04] Validation started with lhcb-lcg-dev4#604
• [2018-08-02 00:06] Validation started with lhcb-lcg-dev3#605
• [2018-08-02 00:06] Validation started with lhcb-gaudi-head#1949
• [2018-08-02 00:07] Validation started with lhcb-tdr-test#237
• [2018-08-02 11:14] Validation started with lhcb-tdr-test#238
• [2018-08-03 00:03] Validation started with lhcb-lcg-dev3#606
• [2018-08-03 00:04] Validation started with lhcb-lcg-dev4#605
• [2018-08-03 00:06] Validation started with lhcb-gaudi-head#1950
• [2018-08-03 00:07] Validation started with lhcb-tdr-test#239
• [2018-08-03 10:33] Validation started with lhcb-tdr-test#240
• [2018-08-03 13:46] Validation started with lhcb-tdr-test#241
• [2018-08-04 00:03] Validation started with lhcb-lcg-dev4#606
• [2018-08-04 00:05] Validation started with lhcb-lcg-dev3#607
• [2018-08-04 00:09] Validation started with lhcb-tdr-test#242
• [2018-08-04 00:09] Validation started with lhcb-gaudi-head#1951
• [2018-08-05 00:04] Validation started with lhcb-gaudi-head#1952
• [2018-08-05 00:04] Validation started with lhcb-lcg-dev3#608
• [2018-08-05 00:07] Validation started with lhcb-tdr-test#243
• [2018-08-05 00:12] Validation started with lhcb-lcg-dev4#607
• [2018-08-06 00:04] Validation started with lhcb-lcg-dev3#609
• [2018-08-06 00:06] Validation started with lhcb-gaudi-head#1953
• [2018-08-06 00:06] Validation started with lhcb-lcg-dev4#608
• [2018-08-06 00:09] Validation started with lhcb-tdr-test#244
• [2018-08-07 00:04] Validation started with lhcb-lcg-dev4#609
• [2018-08-07 00:05] Validation started with lhcb-lcg-dev3#610
• [2018-08-07 00:08] Validation started with lhcb-tdr-test#245
• [2018-08-07 00:09] Validation started with lhcb-gaudi-head#1954
• [2018-08-07 13:10] Validation started with lhcb-tdr-test#246
• [2018-08-08 00:05] Validation started with lhcb-lcg-dev4#610
• [2018-08-08 00:05] Validation started with lhcb-lcg-dev3#611
• [2018-08-08 00:07] Validation started with lhcb-tdr-test#247
• [2018-08-08 00:07] Validation started with lhcb-gaudi-head#1955
• [2018-08-08 12:20] Validation started with lhcb-tdr-test#248
• [2018-08-09 00:04] Validation started with lhcb-lcg-dev3#612
• [2018-08-09 00:06] Validation started with lhcb-lcg-dev4#611
• [2018-08-09 00:08] Validation started with lhcb-gaudi-head#1956
• [2018-08-09 00:12] Validation started with lhcb-tdr-test#249
• [2018-08-10 00:04] Validation started with lhcb-lcg-dev4#612
• [2018-08-10 00:05] Validation started with lhcb-lcg-dev3#613
• [2018-08-10 00:09] Validation started with lhcb-tdr-test#250
• [2018-08-10 00:21] Validation started with lhcb-gaudi-head#1957
• [2018-08-11 09:56] Validation started with lhcb-lcg-dev4#613
• [2018-08-11 09:56] Validation started with lhcb-lcg-dev3#614
• [2018-08-11 10:00] Validation started with lhcb-tdr-test#251
• [2018-08-11 10:01] Validation started with lhcb-gaudi-head#1958
• [2018-08-12 00:05] Validation started with lhcb-lcg-dev4#614
• [2018-08-12 00:06] Validation started with lhcb-tdr-test#252
• [2018-08-12 00:06] Validation started with lhcb-lcg-dev3#615
• [2018-08-13 00:04] Validation started with lhcb-lcg-dev3#616
• [2018-08-13 00:04] Validation started with lhcb-lcg-dev4#615
• [2018-08-13 00:06] Validation started with lhcb-tdr-test#253
• [2018-08-13 00:07] Validation started with lhcb-gaudi-head#1960
• [2018-08-14 09:40] Validation started with lhcb-lcg-dev4#616
• [2018-08-14 09:41] Validation started with lhcb-gaudi-head#1961
• [2018-08-14 09:42] Validation started with lhcb-lcg-dev3#617
• [2018-08-14 09:46] Validation started with lhcb-tdr-test#254
• [2018-08-15 00:06] Validation started with lhcb-lcg-dev4#617
• [2018-08-15 00:07] Validation started with lhcb-lcg-dev3#618
• [2018-08-15 00:08] Validation started with lhcb-tdr-test#255
• [2018-08-15 00:08] Validation started with lhcb-gaudi-head#1962
• [2018-08-15 00:29] Validation started with lhcb-tdr-test#256
• [2018-08-16 00:04] Validation started with lhcb-lcg-dev4#618
• [2018-08-16 00:06] Validation started with lhcb-tdr-test#257
• [2018-08-16 00:06] Validation started with lhcb-lcg-dev3#619
• [2018-08-16 00:12] Validation started with lhcb-gaudi-head#1963
• [2018-08-17 00:04] Validation started with lhcb-lcg-dev3#620
• [2018-08-17 00:06] Validation started with lhcb-lcg-dev4#619
• [2018-08-17 00:09] Validation started with lhcb-gaudi-head#1964
• [2018-08-17 00:10] Validation started with lhcb-tdr-test#258
• [2018-08-18 00:04] Validation started with lhcb-lcg-dev3#621
• [2018-08-18 00:06] Validation started with lhcb-lcg-dev4#620
• [2018-08-18 00:09] Validation started with lhcb-tdr-test#259
• [2018-08-18 00:16] Validation started with lhcb-gaudi-head#1965
• [2018-08-19 00:04] Validation started with lhcb-lcg-dev3#622
• [2018-08-19 00:04] Validation started with lhcb-gaudi-head#1966
• [2018-08-19 00:05] Validation started with lhcb-lcg-dev4#621
• [2018-08-19 00:06] Validation started with lhcb-tdr-test#260
• [2018-08-20 00:06] Validation started with lhcb-lcg-dev4#622
• [2018-08-20 00:07] Validation started with lhcb-gaudi-head#1967
• [2018-08-20 00:08] Validation started with lhcb-lcg-dev3#623
• [2018-08-20 00:10] Validation started with lhcb-tdr-test#261
• [2018-08-21 00:05] Validation started with lhcb-lcg-dev4#623
• [2018-08-21 00:05] Validation started with lhcb-lcg-dev3#624
• [2018-08-21 00:07] Validation started with lhcb-tdr-test#262
• [2018-08-21 00:09] Validation started with lhcb-gaudi-head#1968
• [2018-08-21 16:40] Validation started with lhcb-lcg-dev4#624
• [2018-08-22 00:04] Validation started with lhcb-lcg-dev4#625
• [2018-08-22 00:07] Validation started with lhcb-lcg-dev3#625
• [2018-08-22 00:08] Validation started with lhcb-tdr-test#263
• [2018-08-22 00:09] Validation started with lhcb-gaudi-head#1969
• [2018-08-23 00:06] Validation started with lhcb-lcg-dev4#626
• [2018-08-23 00:06] Validation started with lhcb-lcg-dev3#626
• [2018-08-23 00:09] Validation started with lhcb-tdr-test#264
• [2018-08-23 00:10] Validation started with lhcb-gaudi-head#1970
• [2018-08-24 00:04] Validation started with lhcb-lcg-dev3#627
• [2018-08-24 00:05] Validation started with lhcb-lcg-dev4#627
• [2018-08-24 00:10] Validation started with lhcb-gaudi-head#1971
• [2018-08-24 00:15] Validation started with lhcb-tdr-test#265
• [2018-08-30 14:43] Validation started with lhcb-gaudi-merge#561
• [2018-08-31 00:04] Validation started with lhcb-lcg-dev4#635
• [2018-08-31 00:05] Validation started with lhcb-lcg-dev3#634
• [2018-08-31 00:08] Validation started with lhcb-gaudi-head#1978
• [2018-08-31 00:15] Validation started with lhcb-tdr-test#272
• [2018-08-31 10:34] Validation started with lhcb-gaudi-head#1979
• [2018-08-31 15:06] Validation started with lhcb-lcg-dev4#636
• [2018-09-01 00:05] Validation started with lhcb-lcg-dev3#635
• [2018-09-01 00:05] Validation started with lhcb-lcg-dev4#637
• [2018-09-01 00:08] Validation started with lhcb-tdr-test#273
• [2018-09-01 00:11] Validation started with lhcb-gaudi-head#1980
• [2018-09-01 01:53] Validation started with lhcb-lcg-dev4#637
• [2018-09-01 02:11] Validation started with lhcb-gaudi-head#1980
• [2018-09-02 00:05] Validation started with lhcb-lcg-dev4#638
• [2018-09-02 00:05] Validation started with lhcb-lcg-dev3#636
• [2018-09-02 00:05] Validation started with lhcb-gaudi-head#1981
• [2018-09-02 00:08] Validation started with lhcb-tdr-test#274
• [2018-09-02 13:58] Validation started with lhcb-lcg-dev4#639
• [2018-09-03 00:04] Validation started with lhcb-gaudi-head#1982
• [2018-09-03 00:06] Validation started with lhcb-lcg-dev4#640
• [2018-09-03 00:07] Validation started with lhcb-lcg-dev3#637
• [2018-09-03 00:10] Validation started with lhcb-tdr-test#275
• [2018-09-04 00:04] Validation started with lhcb-lcg-dev3#638
• [2018-09-04 00:06] Validation started with lhcb-lcg-dev4#641
• [2018-09-04 00:07] Validation started with lhcb-gaudi-head#1983
• [2018-09-04 00:09] Validation started with lhcb-tdr-test#276
• [2018-09-05 00:04] Validation started with lhcb-lcg-dev4#642
• [2018-09-05 00:05] Validation started with lhcb-lcg-dev3#639
• [2018-09-05 00:08] Validation started with lhcb-tdr-test#277
• [2018-09-05 00:10] Validation started with lhcb-gaudi-head#1984
• [2018-09-06 00:05] Validation started with lhcb-lcg-dev3#640
• [2018-09-06 00:08] Validation started with lhcb-lcg-dev4#643
• [2018-09-06 00:11] Validation started with lhcb-tdr-test#278
• [2018-09-06 00:11] Validation started with lhcb-gaudi-head#1985
• [2018-09-07 00:05] Validation started with lhcb-lcg-dev3#641
• [2018-09-07 00:06] Validation started with lhcb-lcg-dev4#644
• [2018-09-07 00:09] Validation started with lhcb-tdr-test#279
• [2018-09-07 00:19] Validation started with lhcb-gaudi-head#1986
• [2018-09-07 00:52] Validation started with lhcb-lcg-dev4#644
• [2018-09-07 00:55] Validation started with lhcb-tdr-test#279
• [2018-09-07 01:05] Validation started with lhcb-gaudi-head#1986
• [2018-09-07 01:34] Validation started with lhcb-tdr-test#279
• [2018-09-07 09:11] Validation started with lhcb-gaudi-head#1987
• [2018-09-08 00:04] Validation started with lhcb-lcg-dev4#645
• [2018-09-08 00:06] Validation started with lhcb-lcg-dev3#642
• [2018-09-08 00:07] Validation started with lhcb-tdr-test#280
• [2018-09-08 00:10] Validation started with lhcb-gaudi-head#1988
• [2018-09-09 17:02] Validation started with lhcb-lcg-dev3#643
• [2018-09-09 17:04] Validation started with lhcb-lcg-dev4#646
• [2018-09-09 17:05] Validation started with lhcb-tdr-test#281
• [2018-09-10 00:08] Validation started with lhcb-lcg-dev3#644
• [2018-09-10 00:11] Validation started with lhcb-lcg-dev4#647
• [2018-09-10 00:14] Validation started with lhcb-tdr-test#282
• [2018-09-10 00:18] Validation started with lhcb-gaudi-head#1990
• [2018-09-10 09:41] Validation started with lhcb-dd4hep-dev4#1
• [2018-09-10 10:04] Validation started with lhcb-dd4hep-dev4#2
• [2018-09-10 17:08] Validation started with lhcb-dd4hep-dev4#3
• [2018-09-10 22:34] Validation started with lhcb-dd4hep-dev4#4
• [2018-09-11 00:04] Validation started with lhcb-lcg-dev4#648
• [2018-09-11 00:06] Validation started with lhcb-dd4hep-dev4#5
• [2018-09-11 00:08] Validation started with lhcb-tdr-test#283
• [2018-09-11 00:09] Validation started with lhcb-gaudi-head#1991
• [2018-09-11 00:18] Validation started with lhcb-dd4hep-dev4#5
• [2018-09-11 00:27] Validation started with lhcb-dd4hep-dev4#5
• [2018-09-11 09:47] Validation started with lhcb-tdr-test#284
• [2018-09-11 18:17] Validation started with lhcb-dd4hep-dev4#6
• [2018-09-12 00:05] Validation started with lhcb-dd4hep-dev4#7
• [2018-09-12 00:05] Validation started with lhcb-lcg-dev4#649
• [2018-09-12 00:06] Validation started with lhcb-lcg-dev3#646
• [2018-09-12 00:07] Validation started with lhcb-tdr-test#285
• [2018-09-12 00:10] Validation started with lhcb-gaudi-head#1992
• [2018-09-13 00:05] Validation started with lhcb-lcg-dev4#651
• [2018-09-13 00:06] Validation started with lhcb-dd4hep-dev4#8
• [2018-09-13 00:13] Validation started with lhcb-lcg-dev3#647
• [2018-09-13 00:15] Validation started with lhcb-gaudi-head#1993
• [2018-09-13 00:15] Validation started with lhcb-tdr-test#286
• [2018-09-13 00:37] Validation started with lhcb-dd4hep-dev4#8
• [2018-09-13 00:39] Validation started with lhcb-sanitizers#2
• [2018-09-14 00:04] Validation started with lhcb-lcg-dev3#648
• [2018-09-14 00:05] Validation started with lhcb-dd4hep-dev4#9
• [2018-09-14 00:06] Validation started with lhcb-lcg-dev4#652
• [2018-09-14 00:14] Validation started with lhcb-sanitizers#3
• [2018-09-14 00:23] Validation started with lhcb-tdr-test#287
• [2018-09-14 00:47] Validation started with lhcb-gaudi-head#1994
• [2018-09-15 00:06] Validation started with lhcb-lcg-dev3#649
• [2018-09-15 00:07] Validation started with lhcb-dd4hep-dev4#10
• [2018-09-15 00:07] Validation started with lhcb-tdr-test#288
• [2018-09-15 00:08] Validation started with lhcb-lcg-dev4#653
• [2018-09-15 00:10] Validation started with lhcb-sanitizers#4
• [2018-09-15 00:10] Validation started with lhcb-gaudi-head#1995
• [2018-09-16 00:07] Validation started with lhcb-lcg-dev4#654
• [2018-09-16 00:07] Validation started with lhcb-sanitizers#5
• [2018-09-16 00:07] Validation started with lhcb-gaudi-head#1996
• [2018-09-16 00:08] Validation started with lhcb-tdr-test#289
• [2018-09-16 00:08] Validation started with lhcb-dd4hep-dev4#11
• [2018-09-16 11:07] Validation started with lhcb-dd4hep-dev4#12
• [2018-09-17 00:04] Validation started with lhcb-dd4hep-dev4#13
• [2018-09-17 00:06] Validation started with lhcb-lcg-dev4#655
• [2018-09-17 00:06] Validation started with lhcb-gaudi-head#1997
• [2018-09-17 00:07] Validation started with lhcb-lcg-dev3#651
• [2018-09-17 00:07] Validation started with lhcb-tdr-test#290
• [2018-09-17 00:10] Validation started with lhcb-sanitizers#6

Ping!

mentioned in merge request !730 (closed)

mentioned in merge request !732 (merged)

mentioned in issue #37 (closed)

added 31 commits

• 80c9857c...6106f978 - 28 commits from branch gaudi:master
• 222f647e - Merge remote-tracking branch 'upstream/master' into RefactorContextPointerFix
• b0e1d306 - Merge remote-tracking branch 'upstream/master' into RefactorContextPointerFix
• 1e84442a - Change of approach - just update all subslots

Compare with previous version

Actually changed to a new approach where I don't pass subslot info to updateStates at all. Looks simpler, and is probably more robust.

mentioned in merge request !735 (closed)

marked as a Work In Progress

added 2 commits

• 028828c3 - Revert "Tidy, apply-formatting"
• 71db4347 - Formatting

Compare with previous version

added 1 commit

• 8fd3cca7 - Make test consistent

Compare with previous version

unmarked as a Work In Progress

resolved all discussions

changed milestone to %v30r4

added task scheduling label

approved this merge request

@leggett I let you merge it whenever it's OK for you

assigned to @leggett

• [2018-09-18 00:03] Validation started with lhcb-dd4hep-dev4#14
• [2018-09-18 00:05] Validation started with lhcb-lcg-dev3#652
• [2018-09-18 00:06] Validation started with lhcb-lcg-dev4#656
• [2018-09-18 00:06] Validation started with lhcb-sanitizers#7
• [2018-09-18 00:07] Validation started with lhcb-gaudi-head#1998
• [2018-09-18 00:18] Validation started with lhcb-tdr-test#291
• [2018-09-19 00:04] Validation started with lhcb-lcg-dev3#653
• [2018-09-19 00:05] Validation started with lhcb-dd4hep-dev4#15
• [2018-09-19 00:06] Validation started with lhcb-sanitizers#8
• [2018-09-19 00:06] Validation started with lhcb-lcg-dev4#657
• [2018-09-19 00:09] Validation started with lhcb-gaudi-head#1999
• [2018-09-19 00:10] Validation started with lhcb-tdr-test#292

merged

mentioned in commit 10d92592