Use unique pointers for EventContexts

Addressing #37 (closed)

EventContext pointers passed to the scheduler for sub-slot scheduling aren't deleted reliably. Switch to using unique pointers in the interface, and storing unique pointers for contexts within EventSlots.

Includes changes from !730 (closed) that reduced the use of EventContext pointers

Part of a larger overhaul of sub-slot scheduling including !727 (merged) and !729 (merged)

Could go further, and convert scheduler interface to use unique pointers only, but that would be a larger-scale change. Could also reduce passing of EventContext pointers between scheduler methods, like !727 (merged) but going further.

added 1 commit

• d7ffd935 - Moving uniqueness into the EventSlot

Compare with previous version

added 2 commits

• 39a9de5a - Made EventSlot context unique entirely, and it runs without crashing, sort of
• 5785aa7e - Removed a debug message that broke most of the ctests. Only views left to fix!

Compare with previous version

added 1 commit

• e572533d - Fixed a segfault in view copying

Compare with previous version

added 1 commit

• 12d4cb0d - Simplification, most tests pass

Compare with previous version

added 5 commits

• 4161e81f - Changed EventContexts to have a sub-slot index, and removed that lookup from EventSlot
• acf04e80 - More logical way to test for sub-slot scheduling
• 41807762 - Can now detect nesting at the scheduler level
• 4826ee8b - Want to save progress then merge "removing the context lookup"
• 12dc7e05 - Merge branch 'ContextSubSlotIndex' into ContextUniquePointer

Compare with previous version

added 1 commit

• 084f8249 - All tests pass :D

Compare with previous version

mentioned in merge request !730 (closed)

Merged !730 (closed) in here, since the removal of the EventContext pointer lookup really simplifies the use of unique pointers. Hoped to keep the issues factorised for ease of discussion, but hey ho.

added 1 commit

• 2df4037b - Tidying

Compare with previous version

added 1 commit

• da3eb794 - More tidying. Do not release context pointers for sub-slots: they are owned

Compare with previous version

added 1 commit

• 70b97f12 - Tidying, removing those "isSubSlot" checks again because it couldn't be

Compare with previous version

added 1 commit

• 93069e59 - Tidying

Compare with previous version

added 1 commit

• 581bf385 - Fixed formatting

Compare with previous version

unmarked as a Work In Progress

changed the description

mentioned in issue #37 (closed)

• [2018-08-14 18:34] Validation started with lhcb-gaudi-merge#555
• [2018-08-15 00:06] Automatic merge failed in lhcb-lcg-dev4#617
• [2018-08-15 00:07] Automatic merge failed in lhcb-lcg-dev3#618
• [2018-08-15 00:08] Automatic merge failed in lhcb-tdr-test#255
• [2018-08-15 00:08] Automatic merge failed in lhcb-gaudi-head#1962
• [2018-08-15 00:30] Automatic merge failed in lhcb-tdr-test#256
• [2018-08-16 00:05] Automatic merge failed in lhcb-lcg-dev4#618
• [2018-08-16 00:06] Automatic merge failed in lhcb-tdr-test#257
• [2018-08-16 00:07] Automatic merge failed in lhcb-lcg-dev3#619
• [2018-08-16 00:12] Automatic merge failed in lhcb-gaudi-head#1963
• [2018-08-17 00:04] Automatic merge failed in lhcb-lcg-dev3#620
• [2018-08-17 00:06] Automatic merge failed in lhcb-lcg-dev4#619
• [2018-08-17 00:09] Automatic merge failed in lhcb-gaudi-head#1964
• [2018-08-17 00:10] Automatic merge failed in lhcb-tdr-test#258
• [2018-08-18 00:04] Automatic merge failed in lhcb-lcg-dev3#621
• [2018-08-18 00:06] Automatic merge failed in lhcb-lcg-dev4#620
• [2018-08-18 00:09] Automatic merge failed in lhcb-tdr-test#259
• [2018-08-18 00:17] Automatic merge failed in lhcb-gaudi-head#1965
• [2018-08-19 00:04] Automatic merge failed in lhcb-lcg-dev3#622
• [2018-08-19 00:05] Automatic merge failed in lhcb-gaudi-head#1966
• [2018-08-19 00:05] Automatic merge failed in lhcb-lcg-dev4#621
• [2018-08-19 00:06] Automatic merge failed in lhcb-tdr-test#260
• [2018-08-20 00:07] Automatic merge failed in lhcb-lcg-dev4#622
• [2018-08-20 00:07] Automatic merge failed in lhcb-gaudi-head#1967
• [2018-08-20 00:08] Automatic merge failed in lhcb-lcg-dev3#623
• [2018-08-20 00:10] Automatic merge failed in lhcb-tdr-test#261
• [2018-08-21 00:05] Automatic merge failed in lhcb-lcg-dev4#623
• [2018-08-21 00:05] Automatic merge failed in lhcb-lcg-dev3#624
• [2018-08-21 00:07] Automatic merge failed in lhcb-tdr-test#262
• [2018-08-21 00:09] Automatic merge failed in lhcb-gaudi-head#1968
• [2018-08-21 16:40] Automatic merge failed in lhcb-lcg-dev4#624
• [2018-08-22 00:04] Automatic merge failed in lhcb-lcg-dev4#625
• [2018-08-22 00:07] Automatic merge failed in lhcb-lcg-dev3#625
• [2018-08-22 00:08] Automatic merge failed in lhcb-tdr-test#263
• [2018-08-22 00:09] Automatic merge failed in lhcb-gaudi-head#1969

mentioned in issue #39