Skip to content
Snippets Groups Projects

Fix sanitizer errors from THistSvc

Merged Christopher Rob Jones requested to merge jonrob/Gaudi:THistSvc-FixSanitizerErrors into master
All threads resolved!

Addresses a couple errors from the address and undefined behaviour sanitizers.

==3989==ERROR: AddressSanitizer: heap-use-after-free on address 0x60300027d378 at pc 0x7f954f29b3cb bp 0x7ffcea53c170 sp 0x7ffcea53c168
READ of size 8 at 0x60300027d378 thread T0
    #0 0x7f954f29b3ca in THistSvc::deReg(TObject*) /workspace/build/GAUDI/GAUDI_HEAD/GaudiSvc/src/THistSvc/THistSvc.cpp:634
    #1 0x7f954f297f9d in THistSvc::deReg(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /workspace/build/GAUDI/GAUDI_HEAD/GaudiSvc/src/THistSvc/THistSvc.cpp:586
    #2 0x7f9554c10998 in THistWrite::finalize() /workspace/build/GAUDI/GAUDI_HEAD/GaudiExamples/src/THist/THistWrite.cpp:280
/workspace/build/GAUDI/GAUDI_HEAD/GaudiSvc/src/THistSvc/THistSvc.icc:115:21: runtime error: load of value 55966096, which is not a valid value for type 'Mode'
    #0 0x7f7d1d2a1960 in StatusCode THistSvc::regHist_i<TH1>(std::unique_ptr<TH1, std::default_delete<TH1> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool, THistSvc::THistID*&) /workspace/build/GAUDI/GAUDI_HEAD/GaudiSvc/src/THistSvc/THistSvc.icc:115
    #1 0x7f7d1d2a3182 in StatusCode THistSvc::regHist_i<TH1>(std::unique_ptr<TH1, std::default_delete<TH1> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool) /workspace/build/GAUDI/GAUDI_HEAD/GaudiSvc/src/THistSvc/THistSvc.icc:20
    #2 0x7f7d1d214407 in THistSvc::regHist(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::unique_ptr<TH1, std::default_delete<TH1> >) /workspace/build/GAUDI/GAUDI_HEAD/GaudiSvc/src/THistSvc/THistSvc.cpp:352
    #3 0x7f7d2b7d8037 in THistWrite::initialize() /workspace/build/GAUDI/GAUDI_HEAD/GaudiExamples/src/THist/THistWrite.cpp:40

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added bug fix label

  • Marco Clemencic changed milestone to %v30r4

    changed milestone to %v30r4

  • assigned to @leggett

  • @jonrob: we still have some unresolved comments here.

  • Sure, let me take a look now.

  • added 63 commits

    Compare with previous version

  • Christopher Rob Jones resolved all discussions

    resolved all discussions

  • added 1 commit

    • 66269890 - Fix sanitizer errors from THistSvc

    Compare with previous version

  • Marco Clemencic approved this merge request

    approved this merge request

  • Marco Clemencic mentioned in commit 5614f217

    mentioned in commit 5614f217

  • Please register or sign in to reply
    Loading