Improve CommonMessaging

Implementation of GAUDI-1146: Improve CommonMessaging and use it in more places...

Added 897 commits:

• a3663495...73b596cb - 896 commits from branch gaudi:master
• efef1d93 - clean up common messaging and use it in a few additional places

Added 33 commits:

• 6984f5a1 - use common messaging in PartPropSvc
• c2cd7220 - use common messaging in NTupleSvc
• ee4532a6 - use common messaging in RndmGenSvc
• 33ea36bc - use common messaging in EventCounter
• fcb9f2b1 - use common messaging
• a1aa593b - remove duplicate property update handler
• 49506dc3 - use common messaging
• 788ac0c5 - use common messaging
• 826a444b - use common messaging
• 6fdcdd5e - use common messaging
• 03b3e965 - use common messaging
• df269dd5 - use common messaging
• 227528c2 - use common messaging
• 463070a6 - use common messaging
• 76ef62e4 - use common messaging
• fb98d46a - use common messaging
• 90bf5084 - use common messaging
• 5cefe65e - use common messaging
• f9af4210 - use common messaging
• ffb0e3e1 - use common messaging
• 83d72381 - use common messaging
• a792a2cf - use common messaging
• 3dff62b8 - convert auditors to use common messaging
• c9043430 - use common messaging
• 5909b598 - use common messaging
• 28c7187d - use common messaging
• a02d420f - use common messaging
• 0d3828de - replace outputLevel with msgLevel
• 83af96e7 - replace outputLevel with msgLevel
• 2ff4fd6c - replace outputLevel with msgLevel
• 8ba3b88a - use common messaging
• 8171842a - use common messaging
• 400f8791 - use common messaging

Added 1 commit:

• ad2e6eb2 - cache msgLevel so that msgLevel() gets inlined

Added 6 commits:

• db95a82d - remove (now) unused message svc from Auditor
• 23c94d8d - use common messaging
• d68d7654 - replace outputLevel with msgLevel
• b2c89b69 - add property update message
• 8a4bd7af - remove msgSvc, messageService which are now inherited from CommonMessaging
• 6a494584 - remove outputLevel{,Property}

Added 2 commits:

• 13b41acc - remove redundan inheritance from CommonMessaging
• 647ad45f - add override

Added 2 commits:

• 5468c73b - remove redundant inheritance from CommonMessaging
• 51a33c94 - add override

Added 2 commits:

• b3e166ba - improved hot-cold seperation
• 1664587d - improve code generation and reduce code bloat

Added 1 commit:

• e76bfd91 - update reference files

Added 2 commits:

• 9bcf493e - improve tests
• 05b926a7 - update references

Title changed from [WIP] Improve CommonMessaging to Improve CommonMessaging

Validation started with lhcb-gaudi-merge#27

Milestone changed to v27r0

@lhcbsoft: I've migrated the code in LHCb's Rec and Analysis to be both backwards and forwards compatible with this merge request. Can you please start another validation build?

Validation started with lhcb-gaudi-merge#29

Looking at output_diff of https://lhcb-archive.cern.ch/artifacts/nightly/lhcb-gaudi-merge/29/summaries.x86_64-slc6-gcc48-opt/LHCb/html/index.html?test=results/ioexample0//readrootdst it seems that pointers are now streamed differently:

- StoreExplorerAlg     INFO ========= /Event[0x########@EventDataSvc]:
+ StoreExplorerAlg     INFO ========= /Event[0x0x########@EventDataSvc]:
?                                            ++

Could you check and fix?

Added 1 commit:

• d52d4c62 - consistently use std::showbase in StoreExplorerAlg

OK, the effect is understood: before, every info message in StoreExplorerAlg was sent through a 'fresh' MsgStream. As a result, each manipulation of the output state (eg. using std::hex or, more importantly, std::showbase) was contained to a single message. Now, info() re-uses the same MsgStream, so outputting an std::showbase in one message affects the other messages. So the above is fixed by consistently using either a manual prefix "0x", or consistently use std::showbase and not to mix them.

I suspect that a similar thing may happen further downstream, eg. in LHCb or Atlas specific code -- this will make validation potentially quite a bit more work...

Added 8 commits:

• d52d4c62...8119d23e - 7 commits from branch gaudi:master
• 9e254b03 - Merge remote branch 'Gaudi/master' into dev-common-messaging

Status changed to closed

Status changed to reopened

Validation started with lhcb-gaudi-merge#35

I still see some discrepancies in the outputs, like:

- TESFingerPrint      DEBUG Property update for OutputLevel : new value = 1
- DumpTracks          DEBUG Property update for OutputLevel : new value = 2
+ TESFingerPrint      DEBUG Adding tools for TESFingerPrint
+ DumpTracks          DEBUG Adding tools for DumpTracks
- TESFingerPrint      DEBUG Property update for OutputLevel : new value = 1
- DumpTracks          DEBUG Property update for OutputLevel : new value = 2
- TESFingerPrint      DEBUG Property update for OutputLevel : new value = 1
- DumpTracks          DEBUG Property update for OutputLevel : new value = 2

I'll postpone this for the next version of Gaudi, because I'd like to either hide the diff or update the reference files in LHCb projects.

Milestone changed to v27r1

It will (by construction) be hard to validate this patch based on the tests which compare the messaging output -- eg. the above difference is 'by intent', but checking this across all the tests is a huge amount of work.

Note that updating the reference files is almost a 'catch 22', as it is impossible to have the same references for the code 'pre' and 'post' this patch, so there is no adiabatic way to do this...

Finally, don't forget that this patch fixes a performance regression in the use of CommonMessaging (msgLevel wasn't getting inlined, with this patch it is), so what is currently in use isn't quite optimal. In an ideal world someone would have a bit of time to split/disentangle this patch into two, one addressing the changes to the CommonMessaging implementation, i.e. CommonMessaging.h, and the rest, which is the 'use' of it... The former is easier to validate, the latter much more work.

Added 63 commits:

• 9e254b03...ce1274ce - 62 commits from branch gaudi:master
• 1776a0df - Merge remote branch 'Gaudi/master' into dev-common-messaging

mentioned in commit b0618f78

Status changed to merged

Reassigned to @clemenci

mentioned in commit 3aa8fa96

Mentioned in commit jlingema/Gaudi@b0618f78