HiveWhiteBoard::freeStore: check whether slot was already free

closes #49 (closed)

mentioned in issue #49 (closed)

• [2018-10-13 01:52] Validation started with lhcb-lcg-dev3#677
• [2018-10-13 08:03] Validation started with lhcb-gaudi-merge#608
• [2018-10-14 00:05] Validation started with lhcb-dd4hep#27
• [2018-10-14 00:07] Validation started with lhcb-gaudi-head#2028
• [2018-10-14 00:07] Validation started with lhcb-lcg-dev3#678
• [2018-10-14 00:07] Validation started with lhcb-tdr-test#322
• [2018-10-14 00:08] Validation started with lhcb-lcg-dev4#682
• [2018-10-15 00:04] Validation started with lhcb-lcg-dev3#679
• [2018-10-15 00:06] Validation started with lhcb-lcg-dev4#683
• [2018-10-15 00:07] Validation started with lhcb-gaudi-head#2029
• [2018-10-15 00:07] Validation started with lhcb-tdr-test#323
• [2018-10-15 00:08] Validation started with lhcb-sanitizers#34
• [2018-10-15 00:09] Validation started with lhcb-dd4hep#28
• [2018-10-16 00:05] Validation started with lhcb-lcg-dev3#680
• [2018-10-16 00:06] Validation started with lhcb-tdr-test#324
• [2018-10-16 00:07] Validation started with lhcb-lcg-dev4#684
• [2018-10-16 00:09] Validation started with lhcb-dd4hep#29
• [2018-10-16 00:11] Validation started with lhcb-gaudi-head#2030
• [2018-10-16 00:11] Validation started with lhcb-sanitizers#35
• [2018-10-17 00:05] Validation started with lhcb-dd4hep#30
• [2018-10-17 00:05] Validation started with lhcb-lcg-dev3#681
• [2018-10-17 00:08] Validation started with lhcb-lcg-dev4#685
• [2018-10-17 00:09] Validation started with lhcb-tdr-test#325
• [2018-10-17 00:10] Validation started with lhcb-sanitizers#36
• [2018-10-17 00:12] Validation started with lhcb-gaudi-head#2031
• [2018-10-18 00:05] Validation started with lhcb-lcg-dev4#686
• [2018-10-18 00:05] Validation started with lhcb-dd4hep#31
• [2018-10-18 00:07] Validation started with lhcb-lcg-dev3#682
• [2018-10-18 00:08] Validation started with lhcb-tdr-test#326
• [2018-10-18 00:10] Validation started with lhcb-sanitizers#37
• [2018-10-18 00:11] Validation started with lhcb-gaudi-head#2032
• [2018-10-19 00:05] Validation started with lhcb-lcg-dev3#683
• [2018-10-19 00:10] Validation started with lhcb-lcg-dev4#687
• [2018-10-19 00:10] Validation started with lhcb-dd4hep#32
• [2018-10-19 00:11] Validation started with lhcb-tdr-test#327
• [2018-10-19 00:17] Validation started with lhcb-sanitizers#38
• [2018-10-19 00:20] Validation started with lhcb-gaudi-head#2033
• [2018-10-20 00:05] Validation started with lhcb-lcg-dev4#688
• [2018-10-20 00:07] Validation started with lhcb-tdr-test#328
• [2018-10-20 00:07] Validation started with lhcb-lcg-dev3#684
• [2018-10-20 00:07] Validation started with lhcb-gaudi-head#2034
• [2018-10-20 00:10] Validation started with lhcb-dd4hep#33
• [2018-10-20 00:11] Validation started with lhcb-sanitizers#39
• [2018-10-21 00:04] Validation started with lhcb-dd4hep#34
• [2018-10-21 00:06] Validation started with lhcb-gaudi-head#2035
• [2018-10-21 00:06] Validation started with lhcb-lcg-dev4#689
• [2018-10-21 00:08] Validation started with lhcb-lcg-dev3#685
• [2018-10-21 00:08] Validation started with lhcb-tdr-test#329
• [2018-10-21 00:08] Validation started with lhcb-sanitizers#40
• [2018-10-22 00:04] Validation started with lhcb-lcg-dev4#690
• [2018-10-22 00:05] Validation started with lhcb-lcg-dev3#686
• [2018-10-22 00:05] Validation started with lhcb-dd4hep#35
• [2018-10-22 00:09] Validation started with lhcb-gaudi-head#2036
• [2018-10-22 00:09] Validation started with lhcb-tdr-test#330
• [2018-10-22 00:12] Validation started with lhcb-sanitizers#41
• [2018-10-23 00:08] Validation started with lhcb-lcg-dev3#687
• [2018-10-23 00:08] Validation started with lhcb-lcg-dev4#691
• [2018-10-23 00:08] Validation started with lhcb-dd4hep#36
• [2018-10-23 00:11] Validation started with lhcb-gaudi-head#2037
• [2018-10-23 00:12] Validation started with lhcb-sanitizers#42
• [2018-10-23 00:16] Validation started with lhcb-tdr-test#331
• [2018-10-24 00:11] Validation started with lhcb-dd4hep#37
• [2018-10-24 00:12] Validation started with lhcb-tdr-test#332
• [2018-10-24 00:13] Validation started with lhcb-lcg-dev3#688
• [2018-10-24 00:14] Validation started with lhcb-gaudi-head#2038
• [2018-10-24 00:19] Validation started with lhcb-lcg-dev4#692
• [2018-10-24 00:20] Validation started with lhcb-sanitizers#43
• [2018-10-24 10:12] Validation started with lhcb-tdr-test#333
• [2018-10-24 13:50] Validation started with lhcb-tdr-test#334
• [2018-10-25 00:06] Validation started with lhcb-dd4hep#38
• [2018-10-25 00:06] Validation started with lhcb-lcg-dev4#693
• [2018-10-25 00:09] Validation started with lhcb-lcg-dev3#689
• [2018-10-25 00:10] Validation started with lhcb-sanitizers#44
• [2018-10-25 00:10] Validation started with lhcb-tdr-test#335
• [2018-10-25 00:18] Validation started with lhcb-gaudi-head#2039
• [2018-10-26 00:12] Validation started with lhcb-lcg-dev3#690
• [2018-10-26 00:12] Validation started with lhcb-tdr-test#336
• [2018-10-26 00:13] Validation started with lhcb-dd4hep#39
• [2018-10-26 00:13] Validation started with lhcb-gaudi-head#2040
• [2018-10-26 07:39] Validation started with lhcb-tdr-test#337
• [2018-10-26 09:56] Validation started with lhcb-lcg-dev4#695
• [2018-10-26 14:48] Validation started with lhcb-lcg-dev4#696
• [2018-10-26 14:51] Validation started with lhcb-tdr-test#338
• [2018-10-27 00:06] Validation started with lhcb-lcg-dev4#697
• [2018-10-27 00:07] Validation started with lhcb-dd4hep#40
• [2018-10-27 00:09] Validation started with lhcb-lcg-dev3#691
• [2018-10-27 00:10] Validation started with lhcb-tdr-test#339
• [2018-10-27 00:13] Validation started with lhcb-sanitizers#46
• [2018-10-27 00:14] Validation started with lhcb-gaudi-head#2041
• [2018-10-27 09:48] Validation started with lhcb-lcg-dev3#692
• [2018-10-28 00:05] Validation started with lhcb-dd4hep#41
• [2018-10-28 00:06] Validation started with lhcb-gaudi-head#2042
• [2018-10-28 00:08] Validation started with lhcb-lcg-dev4#698
• [2018-10-28 00:10] Validation started with lhcb-lcg-dev3#693
• [2018-10-28 00:11] Validation started with lhcb-tdr-test#340
• [2018-10-28 00:11] Validation started with lhcb-sanitizers#47
• [2018-10-28 14:38] Validation started with lhcb-tdr-test#341
• [2018-10-29 00:05] Validation started with lhcb-lcg-dev3#694
• [2018-10-29 00:05] Validation started with lhcb-dd4hep#42
• [2018-10-29 00:06] Validation started with lhcb-lcg-dev4#699
• [2018-10-29 00:10] Validation started with lhcb-gaudi-head#2043
• [2018-10-29 00:11] Validation started with lhcb-sanitizers#48
• [2018-10-29 00:11] Validation started with lhcb-tdr-test#342
• [2018-10-30 00:05] Validation started with lhcb-lcg-dev4#700
• [2018-10-30 00:05] Validation started with lhcb-dd4hep#43
• [2018-10-30 00:08] Validation started with lhcb-lcg-dev3#695
• [2018-10-30 00:08] Validation started with lhcb-tdr-test#343
• [2018-10-30 00:09] Validation started with lhcb-gaudi-head#2044
• [2018-10-30 00:11] Validation started with lhcb-sanitizers#49
• [2018-10-31 00:06] Validation started with lhcb-lcg-dev4#701
• [2018-10-31 00:06] Validation started with lhcb-dd4hep#44
• [2018-10-31 00:08] Validation started with lhcb-lcg-dev3#696
• [2018-10-31 00:11] Validation started with lhcb-tdr-test#344
• [2018-10-31 00:14] Validation started with lhcb-gaudi-head#2045
• [2018-10-31 00:15] Validation started with lhcb-sanitizers#50
• [2018-10-31 11:42] Validation started with lhcb-lcg-dev3#697
• [2018-11-01 00:04] Validation started with lhcb-lcg-dev4#702
• [2018-11-01 00:05] Validation started with lhcb-dd4hep#45
• [2018-11-01 00:07] Validation started with lhcb-lcg-dev3#698
• [2018-11-01 00:10] Validation started with lhcb-tdr-test#345
• [2018-11-01 00:13] Validation started with lhcb-gaudi-head#2046
• [2018-11-01 00:16] Validation started with lhcb-sanitizers#51
• [2018-11-01 07:42] Validation started with lhcb-gaudi-head#2047

added 1 commit

• 2429f7b6 - check whether slot was already freed or not

Compare with previous version

added bug fix label

changed milestone to %v30r4

assigned to @leggett

note: maybe this is a better alternative as it communicates the double free to the caller, who can then decide what to do about it...

  StatusCode freeStore( size_t partition ) override
  {
    assert( partition < m_partitions.size() );
    auto prev = m_partitions[partition].with_lock( []( Partition& p ) { return std::exchange( p.eventNumber, -1 ); } );
    if ( UNLIKELY(prev == -1) ) return StatusCode::FAILURE; // double free?
    m_freeSlots.push( partition );
    return StatusCode::SUCCESS;
  }

I think it would be a good idea to find out why we're getting a double free, which I don't think should happen in normal running, and being notified that one is happening instead of sweeping it under the rug is a good thing.

added 1 commit

• 8197b778 - check whether slot was already freed or not

Compare with previous version

Agreed -- changed to check whether there is a double-free, and if so, return StatusCode::FAILURE.

added 1 commit

• 740826e2 - check whether slot was already freed or not

Compare with previous version

added 1 commit

• e35efc35 - check whether slot was already freed or not

Compare with previous version

approved this merge request

merged

mentioned in commit 9dc362f5