Fix some gcc8 warnings

Fix some gcc8 warnings:

GaudiHive:

• catch polymorphic exceptions by reference

GaudiProfiling:

• Avoid using sprintf with the same source and destination buffers
• Replace strncpy with memcpy
• Use sa_sigaction instead of sa_handler for the signal handler to avoid function pointer type mismatch

For the changes in GaudiProfiling it would be good if someone who actually uses this code cross-checks my changes (cc @rmatev). The amount of low-level string manipulations in that code is a bit scary.

• [2018-10-23 10:32] Validation started with lhcb-gaudi-merge#615
• [2018-10-24 00:11] Validation started with lhcb-dd4hep#37
• [2018-10-24 00:12] Validation started with lhcb-tdr-test#332
• [2018-10-24 00:13] Validation started with lhcb-lcg-dev3#688
• [2018-10-24 00:14] Validation started with lhcb-gaudi-head#2038
• [2018-10-24 00:19] Validation started with lhcb-lcg-dev4#692
• [2018-10-24 00:20] Validation started with lhcb-sanitizers#43
• [2018-10-24 10:12] Validation started with lhcb-tdr-test#333
• [2018-10-24 13:50] Validation started with lhcb-tdr-test#334
• [2018-10-25 00:06] Validation started with lhcb-dd4hep#38
• [2018-10-25 00:06] Validation started with lhcb-lcg-dev4#693
• [2018-10-25 00:09] Validation started with lhcb-lcg-dev3#689
• [2018-10-25 00:10] Validation started with lhcb-sanitizers#44
• [2018-10-25 00:11] Validation started with lhcb-tdr-test#335
• [2018-10-25 00:18] Validation started with lhcb-gaudi-head#2039
• [2018-10-26 00:12] Validation started with lhcb-sanitizers#45
• [2018-10-26 00:12] Validation started with lhcb-lcg-dev4#694
• [2018-10-26 00:12] Validation started with lhcb-lcg-dev3#690
• [2018-10-26 00:13] Validation started with lhcb-tdr-test#336
• [2018-10-26 00:13] Validation started with lhcb-dd4hep#39
• [2018-10-26 00:13] Validation started with lhcb-gaudi-head#2040
• [2018-10-26 07:39] Validation started with lhcb-tdr-test#337
• [2018-10-26 09:56] Validation started with lhcb-lcg-dev4#695
• [2018-10-26 14:48] Validation started with lhcb-lcg-dev4#696
• [2018-10-26 14:51] Validation started with lhcb-tdr-test#338
• [2018-10-27 00:06] Validation started with lhcb-lcg-dev4#697
• [2018-10-27 00:07] Validation started with lhcb-dd4hep#40
• [2018-10-27 00:09] Validation started with lhcb-lcg-dev3#691
• [2018-10-27 00:10] Validation started with lhcb-tdr-test#339
• [2018-10-27 00:13] Validation started with lhcb-sanitizers#46
• [2018-10-27 00:14] Validation started with lhcb-gaudi-head#2041
• [2018-10-27 09:48] Validation started with lhcb-lcg-dev3#692
• [2018-10-28 00:05] Validation started with lhcb-dd4hep#41
• [2018-10-28 00:06] Validation started with lhcb-gaudi-head#2042
• [2018-10-28 00:08] Validation started with lhcb-lcg-dev4#698
• [2018-10-28 00:10] Validation started with lhcb-lcg-dev3#693
• [2018-10-28 00:11] Validation started with lhcb-tdr-test#340
• [2018-10-28 00:11] Validation started with lhcb-sanitizers#47
• [2018-10-28 14:38] Validation started with lhcb-tdr-test#341
• [2018-10-29 00:05] Validation started with lhcb-dd4hep#42
• [2018-10-29 00:05] Validation started with lhcb-lcg-dev3#694
• [2018-10-29 00:06] Validation started with lhcb-lcg-dev4#699
• [2018-10-29 00:10] Validation started with lhcb-gaudi-head#2043
• [2018-10-29 00:11] Validation started with lhcb-sanitizers#48
• [2018-10-29 00:11] Validation started with lhcb-tdr-test#342
• [2018-10-30 00:05] Validation started with lhcb-lcg-dev4#700
• [2018-10-30 00:06] Validation started with lhcb-dd4hep#43
• [2018-10-30 00:08] Validation started with lhcb-lcg-dev3#695
• [2018-10-30 00:08] Validation started with lhcb-tdr-test#343
• [2018-10-30 00:09] Validation started with lhcb-gaudi-head#2044
• [2018-10-30 00:11] Validation started with lhcb-sanitizers#49
• [2018-10-31 00:06] Validation started with lhcb-lcg-dev4#701
• [2018-10-31 00:06] Validation started with lhcb-dd4hep#44
• [2018-10-31 00:08] Validation started with lhcb-lcg-dev3#696
• [2018-10-31 00:11] Validation started with lhcb-tdr-test#344
• [2018-10-31 00:14] Validation started with lhcb-gaudi-head#2045
• [2018-10-31 00:15] Validation started with lhcb-sanitizers#50

@fwinkl I don't really use or know the code, so I'm afraid I can't help

Thanks @rmatev. I wonder if anybody actually still uses this code at all. Otherwise we may just completely remove it...

approved this merge request

assigned to @clemenci

changed milestone to %v30r4

merged

mentioned in commit 9ba80894