remove m_event_context from `Algorithm`

This is meant as a quick fix for the non-reentrant copy of the eventcontext in Algorithm, in case !703 (merged) takes longer..
If this could be tested within the ATLAS codebase now, we could remove the m_eventcontext completely, also in the LegacyAlgorithmAdapter in !703 (merged).

built on top of !781 (merged)

unmarked as a Work In Progress

changed the description

• [2018-10-23 15:18] Validation started with lhcb-gaudi-merge#617
• [2018-10-24 10:05] Validation started with lhcb-gaudi-merge#619
• [2018-10-24 10:12] Validation started with lhcb-tdr-test#333
• [2018-10-24 13:50] Validation started with lhcb-tdr-test#334
• [2018-10-25 00:06] Validation started with lhcb-dd4hep#38
• [2018-10-25 00:06] Validation started with lhcb-lcg-dev4#693
• [2018-10-25 00:09] Validation started with lhcb-lcg-dev3#689
• [2018-10-25 00:11] Validation started with lhcb-sanitizers#44
• [2018-10-25 00:18] Validation started with lhcb-gaudi-head#2039
• [2018-10-26 00:12] Validation started with lhcb-sanitizers#45
• [2018-10-26 00:12] Validation started with lhcb-lcg-dev3#690
• [2018-10-26 00:13] Validation started with lhcb-tdr-test#336
• [2018-10-26 00:13] Validation started with lhcb-dd4hep#39
• [2018-10-26 00:13] Validation started with lhcb-gaudi-head#2040
• [2018-10-26 07:39] Validation started with lhcb-tdr-test#337
• [2018-10-26 09:56] Validation started with lhcb-lcg-dev4#695
• [2018-10-26 14:48] Validation started with lhcb-lcg-dev4#696
• [2018-10-26 14:51] Validation started with lhcb-tdr-test#338
• [2018-10-27 00:06] Validation started with lhcb-lcg-dev4#697
• [2018-10-27 00:07] Validation started with lhcb-dd4hep#40
• [2018-10-27 00:09] Validation started with lhcb-lcg-dev3#691
• [2018-10-27 00:10] Validation started with lhcb-tdr-test#339
• [2018-10-27 00:13] Validation started with lhcb-sanitizers#46
• [2018-10-27 00:14] Validation started with lhcb-gaudi-head#2041
• [2018-10-27 09:48] Validation started with lhcb-lcg-dev3#692
• [2018-10-28 00:05] Validation started with lhcb-dd4hep#41
• [2018-10-28 00:06] Validation started with lhcb-gaudi-head#2042
• [2018-10-28 00:08] Validation started with lhcb-lcg-dev4#698
• [2018-10-28 00:10] Validation started with lhcb-lcg-dev3#693
• [2018-10-28 00:11] Validation started with lhcb-tdr-test#340
• [2018-10-28 00:11] Validation started with lhcb-sanitizers#47
• [2018-10-28 14:38] Validation started with lhcb-tdr-test#341
• [2018-10-29 00:05] Validation started with lhcb-dd4hep#42
• [2018-10-29 00:05] Validation started with lhcb-lcg-dev3#694
• [2018-10-29 00:06] Validation started with lhcb-lcg-dev4#699
• [2018-10-29 00:10] Validation started with lhcb-gaudi-head#2043
• [2018-10-29 00:11] Validation started with lhcb-sanitizers#48
• [2018-10-29 00:11] Validation started with lhcb-tdr-test#342
• [2018-10-30 00:05] Validation started with lhcb-lcg-dev4#700
• [2018-10-30 00:06] Validation started with lhcb-dd4hep#43
• [2018-10-30 00:08] Validation started with lhcb-lcg-dev3#695
• [2018-10-30 00:08] Validation started with lhcb-tdr-test#343
• [2018-10-30 00:09] Validation started with lhcb-gaudi-head#2044
• [2018-10-30 00:11] Validation started with lhcb-sanitizers#49
• [2018-10-31 00:06] Validation started with lhcb-lcg-dev4#701
• [2018-10-31 00:06] Validation started with lhcb-dd4hep#44
• [2018-10-31 00:08] Validation started with lhcb-lcg-dev3#696
• [2018-10-31 00:11] Validation started with lhcb-tdr-test#344
• [2018-10-31 00:14] Validation started with lhcb-gaudi-head#2045
• [2018-10-31 00:15] Validation started with lhcb-sanitizers#50
• [2018-10-31 11:42] Validation started with lhcb-lcg-dev3#697
• [2018-11-01 00:04] Validation started with lhcb-lcg-dev4#702
• [2018-11-01 00:05] Validation started with lhcb-dd4hep#45
• [2018-11-01 00:07] Validation started with lhcb-lcg-dev3#698
• [2018-11-01 00:10] Validation started with lhcb-tdr-test#345
• [2018-11-01 00:13] Validation started with lhcb-gaudi-head#2046
• [2018-11-01 00:16] Validation started with lhcb-sanitizers#51
• [2018-11-01 07:43] Validation started with lhcb-gaudi-head#2047

to use the extension in the eventcontext, this copy needs to disappear for every algorithm that is run in LHCb, so unless we want to port every algorithm to Gaudi::Algorithm after merging !703 (merged), this needs to be included in ::Algorithm (in LegacyAlgorithmAdapter when the time comes)

mentioned in merge request lhcb/LHCb!1526 (closed)

changed the description

marked as a Work In Progress

breaks some avalancheScheduler tests with a segfault..
EDIT: this is taken care of in !781 (merged). cherry picked from there, seems to fix the tests in question..

added 3 commits

• 19f7cb29 - Fixed the segfault manifesting in TrigUpgradeTests
• b0233039 - Fixed formatting
• 0ebb81b0 - Fixed formatting

Compare with previous version

unmarked as a Work In Progress

changed the description

mentioned in merge request !786 (merged)

@leggett @clemenci how are we proceeding with !781 (merged) and this?

!781 (merged) should be merged asap as a bugfix, with the underlying issues to be addressed in a later refactoring.

changed milestone to %v30r4

assigned to @leggett

approved this merge request

added 77 commits

• 0ebb81b0...9dc362f5 - 76 commits from branch gaudi:master
• 76a8daf2 - remove m_event_context

Compare with previous version

approved this merge request

enabled an automatic merge when the pipeline for 76a8daf2 succeeds

merged

mentioned in commit 9a9601d6

mentioned in issue #47 (closed)

mentioned in commit clemenci/Gaudi@c8298411

mentioned in commit clemenci/Gaudi@b3a2276d

mentioned in merge request !770 (merged)

mentioned in commit clemenci/Gaudi@8b31fa70

mentioned in issue #29 (closed)