Message: Add option to print full event ID

Add the E format specifier to print the full EventIDBase of the event where the Message was emitted. E.g. the following

   MessageSvc.Format = "% F%40W%S%4W%s%e%7W%R%T %0W%M %E"

will result in [run,event,...] being appended to each message.

Also cleaned up some of the formatting code and its documentation.

• [2019-01-07 18:38] Validation started with lhcb-gaudi-merge#656
• [2019-01-08 00:04] Validation started with lhcb-lcg-dev4#772
• [2019-01-08 00:06] Validation started with lhcb-lcg-dev3#766
• [2019-01-08 00:06] Validation started with lhcb-dd4hep#114
• [2019-01-08 00:07] Validation started with lhcb-tdr-test#416
• [2019-01-08 00:07] Validation started with lhcb-sanitizers#119
• [2019-01-08 00:09] Validation started with lhcb-gaudi-head#2118
• [2019-01-09 00:04] Validation started with lhcb-lcg-dev4#773
• [2019-01-09 00:04] Validation started with lhcb-dd4hep#115
• [2019-01-09 00:05] Validation started with lhcb-tdr-test#417
• [2019-01-09 00:06] Validation started with lhcb-sanitizers#120
• [2019-01-09 00:06] Validation started with lhcb-lcg-dev3#767
• [2019-01-09 00:09] Validation started with lhcb-gaudi-head#2119
• [2019-01-10 00:04] Validation started with lhcb-sanitizers#121
• [2019-01-10 00:04] Validation started with lhcb-lcg-dev4#774
• [2019-01-10 00:05] Validation started with lhcb-dd4hep#116
• [2019-01-10 00:05] Validation started with lhcb-tdr-test#418
• [2019-01-10 00:05] Validation started with lhcb-lcg-dev3#768
• [2019-01-10 00:08] Validation started with lhcb-gaudi-head#2120
• [2019-01-10 08:45] Validation started with lhcb-gaudi-head#2121
• [2019-01-10 08:49] Validation started with lhcb-lcg-dev4#774
• [2019-01-11 00:04] Validation started with lhcb-dd4hep#117
• [2019-01-11 00:04] Validation started with lhcb-sanitizers#122
• [2019-01-11 00:06] Validation started with lhcb-lcg-dev3#769
• [2019-01-11 00:06] Validation started with lhcb-lcg-dev4#775
• [2019-01-11 00:10] Validation started with lhcb-gaudi-head#2122
• [2019-01-11 00:16] Validation started with lhcb-tdr-test#419
• [2019-01-12 00:03] Validation started with lhcb-lcg-dev3#770
• [2019-01-12 00:04] Validation started with lhcb-lcg-dev4#776
• [2019-01-12 00:05] Validation started with lhcb-sanitizers#123
• [2019-01-12 00:06] Validation started with lhcb-dd4hep#118
• [2019-01-12 00:06] Validation started with lhcb-tdr-test#420
• [2019-01-12 00:09] Validation started with lhcb-gaudi-head#2123
• [2019-01-13 00:03] Validation started with lhcb-dd4hep#119
• [2019-01-13 00:03] Validation started with lhcb-sanitizers#124
• [2019-01-13 00:04] Validation started with lhcb-lcg-dev4#777
• [2019-01-13 00:05] Validation started with lhcb-lcg-dev3#771
• [2019-01-13 00:06] Validation started with lhcb-gaudi-head#2124
• [2019-01-13 00:06] Validation started with lhcb-tdr-test#421
• [2019-01-14 00:04] Validation started with lhcb-lcg-dev4#778
• [2019-01-14 00:05] Validation started with lhcb-sanitizers#125
• [2019-01-14 00:05] Validation started with lhcb-lcg-dev3#772
• [2019-01-14 00:06] Validation started with lhcb-dd4hep#120
• [2019-01-14 00:06] Validation started with lhcb-gaudi-head#2125
• [2019-01-14 00:08] Validation started with lhcb-tdr-test#422
• [2019-01-14 11:11] Validation started with lhcb-gaudi-head#2126
• [2019-01-15 00:04] Validation started with lhcb-lcg-dev4#779
• [2019-01-15 00:04] Validation started with lhcb-lcg-dev3#773
• [2019-01-15 00:06] Validation started with lhcb-tdr-test#423
• [2019-01-15 00:06] Validation started with lhcb-sanitizers#126
• [2019-01-15 00:07] Validation started with lhcb-dd4hep#121
• [2019-01-15 00:07] Validation started with lhcb-gaudi-head#2127

I seem to remember @nnolte running into trouble with double-deletes when EventContext got copied when it has some extra payload... If so, I'd prefer it if EventContext would not be copyable but only movable... (as from first principles it represents a (collection of) resource(s))

I guess that must be related to the EventContext::setExtension feature. Maybe it's easier (and saves a few bytes) if I only copy the EventIDBase part of EventContext. That would be enough for the purpose of this MR.

AFAIR the problem was described in #47 (closed), and it was due to a non thread-safe copy in Algorithm::sysExecute().

yes, there shouldn't be an issue if the copy is accessed in a thread safe way.. however, with large extensions the copy may become expensive..

added 1 commit

• 406a33e0 - Message: Add option to print full event ID

Compare with previous version

changed the description

OK, so I changed to copying only EventIDBase, which is really all we need.

assigned to @clemenci

changed milestone to %v31r0

approved this merge request

merged

mentioned in commit 84a0eb81

mentioned in merge request atlas/athena!20414 (merged)