CPack changes for ATLAS

Moved most of the CPack setup code into a separate file, cmake/GaudiCPackSettings.cmake, which gets included by the project's main CMakeLists.txt file. In such a way that allows ATLAS to provide a modified file while building Gaudi.

Also made a minor update to cmake/cpack_install.cmake.

To be honest, I do not like the idea that if I set GAUDI_ATLAS=TRUE, then I'll not be able to configure the project anymore. It should be possible to compile Gaudi stand alone, even if with ATLAS defaults. Moreover, I've been changing the "CPack configuration" section only for ATLAS (LHCb does not use it), and I find it a bit silly to wrap it in a "if (NOT GAUDI_ATLAS)".

I prefer that we fine tune the configuration without using experiment specific flags.

One possibility could be to do something like:

find_file(_cpack_config GaudiCPackSettings.cmake)
if(_cpack_config)
  include(_cpack_config)
endif()

In this way you are free to override the cpack settings without setting an experiment specific flag and polluting the cmake configuration with calls to functions that do not exist in Gaudi.

Hi Marco,

That could work. We could just move all the code that's in GaudiProjectConfig.cmake, setting up CPack, to live in a file called GaudiCPackSettings.cmake. Then I'd just override this file in AtlasExternals. Should I prepare a merge request like that instead?

Cheers, Attila

That would be perfect, but no need to create a new merge request: just update the source branch of this one.

There is a build going on in our nightly system at the moment. But once that's done (or at least once Gaudi is checked out for it), I'll try. There's a first time for everything I guess... (I'm really a newbie with Git...)

Added 4 commits:

• 8d339592...eb658809 - 2 commits from branch gaudi:master
• d6982f00 - Merge remote branch 'upstream/master'
• a6093b6a - Changes proposed by Marco

Okay, tried to implement what we talked about. Does this look reasonable?

Good, I like it. Can you just update the merge request description, please?

Did you mean it like this? (I'm using GitLab with Gaudi for the first time...)

Milestone changed to v27r0

perfect... I just created the corresponding JIRA ticket (GAUDI-1165).

Status changed to merged

mentioned in commit 6e55dafa

Mentioned in commit jlingema/Gaudi@6e55dafa