Small fixes to toolchain

• Make sure we do not pick up Gaudi from LCG by mistake. Now that LCG releases (may) contain a version of Gaudi, we have to exclude it from the toolchain to avoid clashes.
• Fixed check for HEPTOOLS_VERSION environment variable
• More reliable detection of Intel Skylake processors (see lhcb-core/LbPlatformUtils!35 (merged))

CC: @mato

changed milestone to %v32r1

mentioned in commit lhcb-core/LbDevTools@94e00251

• [2019-06-26 16:00] Validation started with lhcb-gaudi-merge#785
• [2019-06-27 00:03] Validation started with lhcb-dd4hep#225
• [2019-06-27 00:04] Validation started with lhcb-sanitizers#289
• [2019-06-27 00:05] Validation started with lhcb-lcg-dev3#938
• [2019-06-27 00:07] Validation started with lhcb-tdr-test#590
• [2019-06-27 00:07] Validation started with lhcb-lcg-dev4#946
• [2019-06-27 00:08] Validation started with lhcb-soa-track#121
• [2019-06-27 00:09] Validation started with lhcb-test-throughput2#70
• [2019-06-27 00:10] Validation started with lhcb-gaudi-head#2299
• [2019-06-27 11:01] Validation started with lhcb-test-throughput2#71
• [2019-06-28 00:05] Validation started with lhcb-sanitizers#290
• [2019-06-28 00:05] Validation started with lhcb-lcg-dev3#939
• [2019-06-28 00:05] Validation started with lhcb-test-throughput2#72
• [2019-06-28 00:05] Validation started with lhcb-dd4hep#226
• [2019-06-28 00:06] Validation started with lhcb-lcg-dev4#947
• [2019-06-28 00:06] Validation started with lhcb-tdr-test#591
• [2019-06-28 00:08] Validation started with lhcb-soa-track#122
• [2019-06-28 00:10] Validation started with lhcb-gaudi-head#2300
• [2019-06-29 00:04] Validation started with lhcb-dd4hep#227
• [2019-06-29 00:04] Validation started with lhcb-lcg-dev4#948
• [2019-06-29 00:05] Validation started with lhcb-soa-track#123
• [2019-06-29 00:06] Validation started with lhcb-gaudi-head#2301
• [2019-06-29 00:07] Validation started with lhcb-sanitizers#291
• [2019-06-29 00:10] Validation started with lhcb-test-throughput2#73
• [2019-06-30 00:05] Validation started with lhcb-lcg-dev3#941
• [2019-06-30 00:05] Validation started with lhcb-gaudi-head#2302
• [2019-06-30 00:05] Validation started with lhcb-sanitizers#292
• [2019-06-30 00:06] Validation started with lhcb-tdr-test#593
• [2019-06-30 00:06] Validation started with lhcb-dd4hep#228
• [2019-06-30 00:06] Validation started with lhcb-test-throughput2#74
• [2019-06-30 00:07] Validation started with lhcb-lcg-dev4#949
• [2019-06-30 00:08] Validation started with lhcb-soa-track#124
• [2019-07-01 00:04] Validation started with lhcb-dd4hep#229
• [2019-07-01 00:04] Validation started with lhcb-lcg-dev3#942
• [2019-07-01 00:05] Validation started with lhcb-soa-track#125
• [2019-07-01 00:07] Validation started with lhcb-lcg-dev4#950
• [2019-07-01 00:07] Validation started with lhcb-tdr-test#594
• [2019-07-01 00:08] Validation started with lhcb-sanitizers#293
• [2019-07-01 00:08] Validation started with lhcb-gaudi-head#2303
• [2019-07-01 00:09] Validation started with lhcb-test-throughput2#75
• [2019-07-02 00:05] Validation started with lhcb-sanitizers#294
• [2019-07-02 00:05] Validation started with lhcb-lcg-dev4#951
• [2019-07-02 00:06] Validation started with lhcb-test-throughput2#76
• [2019-07-02 00:06] Validation started with lhcb-soa-track#126
• [2019-07-02 00:06] Validation started with lhcb-lcg-dev3#943
• [2019-07-02 00:07] Validation started with lhcb-dd4hep#230
• [2019-07-02 00:09] Validation started with lhcb-gaudi-head#2304
• [2019-07-02 00:10] Validation started with lhcb-tdr-test#595
• [2019-07-02 23:12] Validation started with lhcb-gaudi-head#2256
• [2019-07-03 00:04] Validation started with lhcb-dd4hep#231
• [2019-07-03 00:04] Validation started with lhcb-lcg-dev3#944
• [2019-07-03 00:06] Validation started with lhcb-lcg-dev4#952
• [2019-07-03 00:07] Validation started with lhcb-gaudi-head#2305
• [2019-07-03 00:08] Validation started with lhcb-sanitizers#295
• [2019-07-03 00:09] Validation started with lhcb-test-throughput2#77
• [2019-07-03 00:09] Validation started with lhcb-tdr-test#596
• [2019-07-03 00:20] Validation started with lhcb-run2-patches-dev4#1
• [2019-07-03 14:32] Validation started with lhcb-run2-patches-dev4#2
• [2019-07-04 00:04] Validation started with lhcb-lcg-dev4#953
• [2019-07-04 00:04] Validation started with lhcb-lcg-dev3#945
• [2019-07-04 00:05] Validation started with lhcb-sanitizers#296
• [2019-07-04 00:05] Validation started with lhcb-test-throughput2#78
• [2019-07-04 00:07] Validation started with lhcb-dd4hep#232
• [2019-07-04 00:07] Validation started with lhcb-gaudi-head#2306
• [2019-07-04 00:10] Validation started with lhcb-tdr-test#597
• [2019-07-04 00:13] Validation started with lhcb-run2-patches-dev4#3
• [2019-07-04 10:24] Validation started with lhcb-gaudi-head#2307
• [2019-07-04 11:22] Validation started with lhcb-run2-patches-dev4#4
• [2019-07-04 13:37] Validation started with lhcb-dd4hep#233
• [2019-07-05 00:04] Validation started with lhcb-dd4hep#234
• [2019-07-05 00:05] Validation started with lhcb-test-throughput2#79
• [2019-07-05 00:06] Validation started with lhcb-lcg-dev3#946
• [2019-07-05 00:07] Validation started with lhcb-tdr-test#598
• [2019-07-05 00:07] Validation started with lhcb-lcg-dev4#954
• [2019-07-05 00:08] Validation started with lhcb-sanitizers#297
• [2019-07-05 00:09] Validation started with lhcb-gaudi-head#2308
• [2019-07-05 00:16] Validation started with lhcb-run2-patches-dev4#5
• [2019-07-06 00:03] Validation started with lhcb-lcg-dev3#947
• [2019-07-06 00:04] Validation started with lhcb-lcg-dev4#955
• [2019-07-06 00:04] Validation started with lhcb-sanitizers#298
• [2019-07-06 00:05] Validation started with lhcb-dd4hep#235
• [2019-07-06 00:05] Validation started with lhcb-test-throughput2#80
• [2019-07-06 00:08] Validation started with lhcb-gaudi-head#2309
• [2019-07-06 00:08] Validation started with lhcb-tdr-test#599
• [2019-07-06 00:18] Validation started with lhcb-run2-patches-dev4#6
• [2019-07-07 00:05] Validation started with lhcb-gaudi-head#2310
• [2019-07-07 00:07] Validation started with lhcb-test-throughput2#81
• [2019-07-07 00:08] Validation started with lhcb-lcg-dev3#948
• [2019-07-07 00:08] Validation started with lhcb-dd4hep#236
• [2019-07-07 00:08] Validation started with lhcb-sanitizers#299
• [2019-07-07 00:10] Validation started with lhcb-tdr-test#600
• [2019-07-07 00:15] Validation started with lhcb-run2-patches-dev4#7
• [2019-07-08 00:03] Validation started with lhcb-dd4hep#237
• [2019-07-08 00:04] Validation started with lhcb-lcg-dev4#957
• [2019-07-08 00:05] Validation started with lhcb-sanitizers#300
• [2019-07-08 00:05] Validation started with lhcb-lcg-dev3#949
• [2019-07-08 00:09] Validation started with lhcb-test-throughput2#82
• [2019-07-08 00:09] Validation started with lhcb-gaudi-head#2311
• [2019-07-08 00:14] Validation started with lhcb-tdr-test#601
• [2019-07-08 00:19] Validation started with lhcb-run2-patches-dev4#8
• [2019-07-09 00:03] Validation started with lhcb-dd4hep#238
• [2019-07-09 00:05] Validation started with lhcb-sanitizers#301
• [2019-07-09 00:06] Validation started with lhcb-test-throughput2#83
• [2019-07-09 00:07] Validation started with lhcb-lcg-dev4#958
• [2019-07-09 00:07] Validation started with lhcb-tdr-test#602
• [2019-07-09 00:07] Validation started with lhcb-gaudi-head#2312
• [2019-07-09 00:16] Validation started with lhcb-run2-patches-dev4#9
• [2019-07-10 00:05] Validation started with lhcb-sanitizers#302
• [2019-07-10 00:05] Validation started with lhcb-dd4hep#239
• [2019-07-10 00:05] Validation started with lhcb-lcg-dev3#951
• [2019-07-10 00:06] Validation started with lhcb-test-throughput2#84
• [2019-07-10 00:07] Validation started with lhcb-gaudi-head#2313
• [2019-07-10 00:08] Validation started with lhcb-lcg-dev4#959
• [2019-07-10 00:10] Validation started with lhcb-tdr-test#603
• [2019-07-10 00:19] Validation started with lhcb-run2-patches-dev4#10
• [2019-07-11 00:04] Validation started with lhcb-lcg-dev4#960
• [2019-07-11 00:04] Validation started with lhcb-lcg-dev3#952
• [2019-07-11 00:05] Validation started with lhcb-gaudi-head#2314
• [2019-07-11 00:06] Validation started with lhcb-dd4hep#240
• [2019-07-11 00:08] Validation started with lhcb-tdr-test#604
• [2019-07-11 00:08] Validation started with lhcb-sanitizers#303
• [2019-07-11 00:09] Validation started with lhcb-test-throughput2#85
• [2019-07-11 00:18] Validation started with lhcb-run2-patches-dev4#11

mentioned in merge request lhcb-core/LbDevTools!64 (merged)

mentioned in commit lhcb-core/LbDevTools@7935f348

this change is because the same toolchain is also used downstream in LHCb projects?

Not strictly, the LHCb version is slightly adapted from this, but it might be needed here too.

!922 (closed) will make this irrelevant, but I'd like to have it in anyway.

added 2 commits

• f73bdec5 - Fix check of HEPTOOLS_VERSION env variable
• 23ca1ba9 - Do not check for 'xsaves' to detect Skylake architecture

Compare with previous version

resolved all discussions

changed title from Make sure we do not pick up Gaudi from LCG by mistake to Smalle fixes to toolchain

changed the description

added bug fix label

changed title from Smalle fixes to toolchain to Small fixes to toolchain

@roiser apart for the small hack for Gaudi from LCG, this now includes an important fix for our AVX512 builds.

assigned to @leggett and unassigned @roiser

approved this merge request

mentioned in commit 3f45ab10

merged