Skip to content
Snippets Groups Projects

Print counters in Gaudi::Algorithm::finalize

Merged Print counters in Gaudi::Algorithm::finalize
graven/Gaudi:algorithm-print-counters-during-finalize into master
1 unresolved thread
Merged Gerhard Raven requested to merge graven/Gaudi:algorithm-print-counters-during-finalize into master
1 unresolved thread

Merge request reports

Pipeline #959847 passed

Stage: build
    Stage: test

      Pipeline passed for 37e10244 on graven:algorithm-print-counters-during-finalize

      Approval is optional

      Merged by Marco ClemencicMarco Clemencic 5 years ago (Jul 16, 2019 8:05am UTC)

      Merge details

      • Changes merged into master with 022170ff.
      • Did not delete the source branch.

      Pipeline #979746 passed

      Stage: build
        Stage: test
          Stage: deploy

            Pipeline passed for 022170ff on master

            Activity

            Filter activity
            • Approvals
            • Assignees & reviewers
            • Comments (from bots)
            • Comments (from users)
            • Commits & branches
            • Edits
            • Labels
            • Lock status
            • Mentions
            • Merge request status
            • Tracking
          • L
            Software for LHCb @lhcbsoft ·
            Edited by Software for LHCb
          • Gerhard Raven added 1 commit

            added 1 commit

            • 08f64e33 - Print counters in Gaudi::Algorithm::finalize

            Compare with previous version

          • Marco Clemencic resolved all discussions

            resolved all discussions

          • Gerhard Raven added 1 commit

            added 1 commit

            • af237108 - Print counters in Gaudi::Algorithm::finalize

            Compare with previous version

          • Gerhard Raven added 1 commit

            added 1 commit

            • 6304526f - Print counters in Gaudi::Algorithm::finalize

            Compare with previous version

          • Gerhard Raven added 1 commit

            added 1 commit

            • 221cb9fb - Print counters in Gaudi::Algorithm::finalize

            Compare with previous version

          • Marco Clemencic resolved all discussions

            resolved all discussions

          • Gerhard Raven added 1 commit

            added 1 commit

            • 37e10244 - Print counters in Gaudi::Algorithm::finalize

            Compare with previous version

          • Gerhard Raven resolved all discussions

            resolved all discussions

          • Gerhard Raven unmarked as a Work In Progress

            unmarked as a Work In Progress

          • Marco Cattaneo
            Marco Cattaneo @cattanem started a thread on the diff
            • GaudiKernel/src/Lib/Algorithm.cpp
            576 576 sc = finalize();
            577 577 }
            578 578 if ( sc.isSuccess() ) {
            579
            580 if ( hasCountersToBePrinted() ) {
            581 auto& os = info() << "Counters:";
            • Marco Cattaneo
              Marco Cattaneo @cattanem ·
              Developer

              @clemenci This is not being recognised as counters printout in the nightlies log file post processing. I have the following diffs for an algorithm migrated from GaudiAlgorithm to Gaudi::Algorithm:

              < VeloClusterTrac...   INFO Counters:
---
> VeloClusterTrac...SUCCESS Number of counters : 2
>  |    Counter                                      |     #     |    sum     | mean/eff^* | rms/err^*  |     min     |     max     |

              And the nightlies log says CountersMismatch:

              Different set of algorithms in Counters
    Missing : VeloClusterTrac

              And Output Diff

              + VeloClusterTrac...   INFO Counters:
                Legend:
                -) reference file
                +) standard output of the test

              @sponce what is the signature that the log file comparison is looking for to recognise counters?

            • S
              Sebastien Ponce @sponce ·
              Developer

              The exact signature is : '^([^. ]*)[. ]+SUCCESS Number of counters : (\d+)$' And it then uses the number given to parse the next lines. So indeed the new output is not supported.

            • C
              Marco Clemencic @clemenci ·
              Owner

              I think we can replace SUCCESS with (SUCCESS|INFO), but we have to keep the number of counters then.

            • Please register or sign in to reply
          • Marco Cattaneo mentioned in commit lhcb/Rec@f9697861

            mentioned in commit lhcb/Rec@f9697861

          • Marco Cattaneo mentioned in merge request lhcb/Brunel!844 (merged)

            mentioned in merge request lhcb/Brunel!844 (merged)

          • Marco Clemencic mentioned in merge request !946 (merged)

            mentioned in merge request !946 (merged)

          • Marco Clemencic mentioned in merge request lhcb/LHCb!2032 (merged)

            mentioned in merge request lhcb/LHCb!2032 (merged)

          • C
            Marco Clemencic @clemenci ·
            Owner

            I extended this MR with !946 (merged), where I change the printout to be

            VeloClusterTrac...   INFO Number of counters : 2

            and added lhcb/LHCb!2032 (merged) to accept both SUCCESS and INFO levels (once lhcb-gaudi-merge#793 demonstrates it works I'll unWIP the LHCb MR).

          • L
            Software for LHCb @lhcbsoft ·
            Edited by Software for LHCb
          • Marco Clemencic merged

            merged

          • Marco Cattaneo mentioned in merge request lhcb/Rec!1629 (merged)

            mentioned in merge request lhcb/Rec!1629 (merged)

          • Marco Cattaneo mentioned in commit lhcb/Brunel@0ee10643

            mentioned in commit lhcb/Brunel@0ee10643

          • Marco Cattaneo mentioned in commit lhcb/Rec@6e07c11c

            mentioned in commit lhcb/Rec@6e07c11c

          • Marco Clemencic mentioned in commit lhcb-nightlies/Gaudi@022170ff

            mentioned in commit lhcb-nightlies/Gaudi@022170ff

            • Please register or sign in to reply