Fix propagation of GaudiSequencer RootInTES

Closes #94 (closed)

changed milestone to %v33r0

added 67 commits

• ed9d6f58...a7dfd950 - 66 commits from branch gaudi:master
• 0034a5cf - Add test to expose non-propagation of GaudiSequencer RootInTES

Compare with previous version

removed milestone

added 79 commits

• 0034a5cf...d2a7a306 - 78 commits from branch gaudi:master
• 1c987170 - Add test to expose non-propagation of GaudiSequencer RootInTES

Compare with previous version

added 11 commits

• 1c987170...8de22c80 - 9 commits from branch gaudi:master
• 15126495 - Add test to expose non-propagation of GaudiSequencer RootInTES
• 98dc3cbb - Fix propagation of Context and RootInTES from GaudiSequencer to members

Compare with previous version

unmarked as a Work In Progress

assigned to @clemenci

added lhcb-gaudi-head label

changed milestone to %v33r1

added 1 commit

• 59e7af6d - Fix propagation of Context and RootInTES from GaudiSequencer to members

Compare with previous version

added 1 commit

• f2235b3a - Fix propagation of Context and RootInTES from GaudiSequencer to members

Compare with previous version

• [2020-02-28 00:04] Validation started with lhcb-gaudi-head#2543
• [2020-02-28 08:20] Validation started with lhcb-gaudi-head#2544
• [2020-02-29 00:08] Validation started with lhcb-gaudi-head#2545
• [2020-03-03 00:04] Validation started with lhcb-gaudi-head#2546
• [2020-03-04 00:04] Validation started with lhcb-gaudi-head#2547

changed title from Add test to expose non-propagation of GaudiSequencer RootInTES to Fix propagation of GaudiSequencer RootInTES

mentioned in commit 3468553f

merged

@jonrob I believe this MR is the cause of the failing Brunel test in https://lhcb-nightlies.web.cern.ch/logs/tests/nightly/lhcb-run2-patches/681/x86_64-centos7-gcc9-opt/Brunel/ - could you have a look (I'm not sure why this manifest itself only in the test sim08-oldrich, which you might want to drop on run2-patches)?

I'll take a more detailed look on Monday, but my guess is this only affects the oldrich tests as this runs the old pre-functional RICH reconstruction, which did rely on RootInTES. In the new functional reconstruction I actively avoid using this at all. So unless you foresee a need to keep testing the old RICH reco., I would vote for just dropping the test, unless I can see it is trivial to fix.

I agree to drop the test if it's not trivial to fix. But then we (you) should also remove from run2-patches the old RICH reco....

Yes, I agree.