Suppress printout of unused MsgCounter instances

Adds an implementation of toBePrinted for MsgCounter that means they are only printed if incremented at least once.

bool toBePrinted() const override { return this->value() > 0; }

@graven FYI

mentioned in merge request lhcb/Rec!1744 (merged)

see !995 (closed) ;-)

• [2019-11-07 18:13] Validation started with lhcb-gaudi-merge#850
• [2019-11-08 00:04] Validation started with lhcb-gaudi-head#2443
• [2019-11-08 13:14] Validation started with lhcb-gaudi-head#2444
• [2019-11-09 00:05] Validation started with lhcb-lcg-dev3#1077
• [2019-11-09 00:05] Validation started with lhcb-dd4hep#377
• [2019-11-09 00:05] Validation started with lhcb-sanitizers#426
• [2019-11-09 00:05] Validation started with lhcb-test-throughput2#209
• [2019-11-09 00:06] Validation started with lhcb-tdr-test#730
• [2019-11-09 00:07] Validation started with lhcb-lcg-dev4#1089
• [2019-11-09 00:08] Validation started with lhcb-gaudi-head#2445
• [2019-11-09 00:10] Validation started with lhcb-gaudi-head-py3#225
• [2019-11-09 00:14] Validation started with lhcb-run2-patches-dev4#137
• [2019-11-09 15:01] Validation started with lhcb-gaudi-head#2446
• [2019-11-10 00:09] Validation started with lhcb-dd4hep#379
• [2019-11-10 00:10] Validation started with lhcb-sanitizers#428
• [2019-11-10 00:10] Validation started with lhcb-test-throughput2#211
• [2019-11-10 00:12] Validation started with lhcb-lcg-dev3#1079
• [2019-11-10 00:12] Validation started with lhcb-gaudi-head#2448
• [2019-11-10 00:12] Validation started with lhcb-gaudi-head-py3#227
• [2019-11-10 00:13] Validation started with lhcb-lcg-dev4#1091
• [2019-11-10 00:13] Validation started with lhcb-tdr-test#732
• [2019-11-10 00:17] Validation started with lhcb-run2-patches-dev4#139
• [2019-11-10 00:26] Validation started with lhcb-coverity#480
• [2019-11-11 09:00] Validation started with lhcb-lcg-test#9
• [2019-11-11 09:05] Validation started with lhcb-lcg-dev4#1092
• [2019-11-11 09:05] Validation started with lhcb-lcg-dev3#1080
• [2019-11-11 09:06] Validation started with lhcb-gaudi-head#2449
• [2019-11-11 09:07] Validation started with lhcb-sanitizers#429
• [2019-11-11 09:08] Validation started with lhcb-dd4hep#381
• [2019-11-11 09:08] Validation started with lhcb-test-throughput2#212
• [2019-11-11 09:09] Validation started with lhcb-gaudi-head-py3#228
• [2019-11-11 09:10] Validation started with lhcb-run2-patches-dev4#140
• [2019-11-11 09:12] Validation started with lhcb-tdr-test#733
• [2019-11-11 14:13] Validation started with lhcb-test-throughput2#213

resolved all threads

mentioned in merge request !995 (closed)

approved this merge request

mentioned in merge request lhcb/Rec!1772 (closed)

Does one of you have the rights to assign a label? Adding this will break all references so we should update them before moving forward.

added code cleanup label

added lhcb-gaudi-head label and removed code cleanup label

added code cleanup label

mentioned in merge request lhcb/Rec!1781 (merged)

mentioned in merge request lhcb/Brunel!910 (merged)

mentioned in merge request lhcb/Moore!295 (merged)

added all-slots label and removed lhcb-gaudi-head label

@clemenci It would be good to get this MR reviewed and merged quickly.

resolved all threads

@clemenci here is the ping.

assigned to @clemenci

changed milestone to %v33r0

merged

mentioned in commit 10829bfd

resolved all threads

mentioned in issue #99 (closed)