PixelCoralClientUtils+InDetCoolCoralClientUtils: Fix cppcheck warnings.

See merge request atlas/athena!36410

SubDetectorEnvelopes+SimHelpers+G4AtlasInterfaces: Enable thread-safety checking.

See merge request atlas/athena!36412

GeoMaterial2G4+Geo2G4: Add missing const qualifiers.

See merge request atlas/athena!36411

RecAlgs: Migrate JobOptsDumperAlg to IOptionsSvc

See merge request atlas/athena!36409

AthAnalysisBaseComps: Migrate to IOptionsSvc

See merge request atlas/athena!36408

changes moved into PhysicsP1

See merge request atlas/athena!36359

Remove ATLAS_NOT_THREAD_SAFE ITrackSummaryTool methods

See merge request atlas/athena!36413

RingerSelectorTools+PATCore: Split off AcceptInfo/AcceptData into a separate library.

See merge request atlas/athena!36327

Scott Snyder authored 4 years ago and Walter Lampl committed 4 years ago

RingerSelectorToolsEnumDict is loaded during configuration, and cannot
depend on Athena libraries or we may see failures with loading converters.
It depends on PATCore, which used to have minimal dependencies, but now
depends on AthenaBaseComps.

The pieces we need from PATCore were split into a separate library,
so depend on that instead.

Also clean up the cmake file.

GSF : since the constents GSF and ForwardGSF Fitter are parts of the same class, merge the .cxx

See merge request atlas/athena!36383

Ensure all clients can connect to SharedWriter even in short jobs.

See merge request atlas/athena!36334

tauRecTools: drop pileup-corrected tau ID variable

See merge request atlas/athena!36391

Trigger config loading - schema tracing and result reporting

See merge request atlas/athena!36313

MagFieldElements : Finalise moving of inline methods from .h  to .icc

See merge request atlas/athena!36340

Move CSC Cluster container creation from tool to algorithm

See merge request atlas/athena!36275

Savanna Shaw authored 4 years ago and Walter Lampl committed 4 years ago

Moving the creation of the CSC cluster container from th ThresholdClusterBuilder tool to the algorithm that calls the tools. This is largely motivated by keeping the Run 2 trigger (where we need to write to the same container more than once per event) producing correct results (so we can validate the Run 3 trigger) without needing to create a separate non-thread safe tool. This required a few changes:

- Move the WriteHandle creation/recording from the CscThresholdClusterBuilderTool to the algorithm (CscThresholdClusterBuilder), and pass the output container to the tool to be filled
- Also removed the output creation/recording from the PeakThresholdClusterBuilderTool (this tool isn't in use at the moment, but in the future it can be used in the same way as the CscThresholdClusterBuilderTool)
- Added the WriteHandle creation/recording to the trigger algorithms before we call the cluster builder tool, and since we can run this more than once per event, we need to retrieve the collection from the event store if we've already recorded the container once:
 -- For L2MuonSA: we only run this when we want to do the decoding from inside the L2 SA algorithms/tools, which only happens in the Run 2 trigger system. For the Run 3 trigger the cluster building is done with the rest of the decoding outside of this code, so the clusters will just be accessed with a ReadHandle as usual.
 -- For TrigMuonEF: removed the reading in of the cluster container, since we produce the container within the same tool now (this runs only as part of the Run 2 trigger system).

cling (not clang > 7) : Has issues  with the templated "vector_size" when using the GCC  vector extensions.

See merge request atlas/athena!36384

Add more RNN vars to the tau trig monitoring

See merge request atlas/athena!36218

GSFCombinedMaterialEffects simplify scattering effects

See merge request atlas/athena!36373

add nullptr check for TrackParticle in MuonCreatorTool

Closes ATLASRECTS-5574

See merge request atlas/athena!36416

Enable thread-safety checking.

Enable thread-safety checking.
Add a couple missing const keywords.

Enable thread-safety checking.

Treat return from GetMaterialPropertiesTable() as const.
Needed to go with thread-safety fixes in GeoModelUtilities.

Treat return from GetMaterialPropertiesTable() as const.
Needed to go with thread-safety fixes in GeoModelUtilities.

 - Pass class instances by class reference, not by value.
 - Prefer preincrement to postincrement for iterators.
 - Remove redundant comparison.
 

Prefer preincrement to postincrement for iterators.

Migrate `AthAnalysisHelper` to `IOptionsSvc`. Probably code should be
cleaned up further to better match the new interface...

GeoModelInterfaces: Enable thread-safety static checker.

See merge request atlas/athena!36336

MaterialInteraction: Move large methods to .cxx from header

See merge request atlas/athena!36370

PerfMonAna: Fix ROOT batch mode

Closes ATR-22025

See merge request atlas/athena!36397

TRT_RawDataByteStreamCnv: threading fixes

See merge request atlas/athena!36378

InDetSimEvent: Thread-safety cleanup.

See merge request atlas/athena!36379

TRT_Cabling: Thread-safety cleanup.

See merge request atlas/athena!36338