Peter Van Gemmeren authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Fix some const correctness for IPC/MP tools

Extend AuxTypeVectorFactory to handle non-default allocators.

Mostly for testing --- should not normally be used.

Vakhtang Tsulaia authored 2 years ago and Atlas Nightlybuild committed 2 years ago

PerfMonComps: Update the handling of the end of the event loop in PerfMonMTSvc

Closes ATEAM-872

See merge request atlas/athena!58889

(cherry picked from commit a7d6699b)

b3347696 Use EndEvtLoop incident instead of AthMasterSeq:Stop to signal the end of the...

Scott Snyder authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

AthContainers: Extending AuxTypeVector for custom allocators.

Extend AuxTypeVector / AuxTypeVectorHolder to handle non-default
memory allocators.

Mark Hodgkinson authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Make useMuonTopoClusters depend only on ProductionStep enum.
Users can no longer set this.

Use EndEvtLoop incident instead of AthMasterSeq:Stop to signal the end of the event loop if it's ever fired

Replace the `class K` template parameter in all auto-declaring HandleKey
property constructors with plain `std::string`. We don't ever use
anything else as SG key and this resolves ambiguities in case other
constructor types are defined (see !58618 for discussion).

Scott Snyder authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

CxxUtils: Implement stall() for aarch64.

On aarch64, stall() should emit a YIELD instruction.

Scott Snyder authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

DataModelTestDataCommon: Testing alternate allocators.

Test the use of alternate vector allocators for static variables.

Add test for Read/WriteDecorHandleKey.

When reading/writing decorations from/on a container one requires
a VarHandleKey for the container and a DecorHandleKey for the
decoration, which usually leads to duplication of the container name:

```
SG::WriteHandleKey<MyCont> m_key{this, "Key", "MyCont"};
SG::WriteDecorHandleKey<MyCont> m_decorKey{this, "DecorKey", "MyCont.MyDecor"};
```

This can now be avoided by passing the "parent container" in the
constructor:
```
SG::WriteDecorHandleKey<MyCont> m_decorKey{this, "DecorKey", m_key, "MyDecor"};
```

Rafal Bielski authored 2 years ago and Edson Carquin Lopez committed 2 years ago

Implement unit testing for RegionSelector to ensure self-contained CA config

John Derek Chapman authored 2 years ago and Frank Winklmeier committed 2 years ago

Use EventID::event_number_t rather than EventID::number_type for event numbers

This is to allow event numbers larger than INT_MAX to be treated correctly by the
EventLoopMgr classes. There may still be other places where inconsistent types
are used for event numbers, but this is at least a start.

Thread-delivery has been the default since athenaMT. Also replace
`boost` with `std`.

Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

AthContainers: Extending to allow for custom allocators.

Extend AuxDataTraits to allow for containers with custom allocators.

John Derek Chapman authored 2 years ago and Frank Winklmeier committed 2 years ago

HGTD_DigitizationTool should use the m_vetoThisBarcode property rather than crazyParticleBarcode directly

Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

RootUtils: Fix a deadlock.

In DsoRootLock, don't try to take the root core mutex for the Xrd libraries;
otherwise, we can get a deadlock.

Need to get a real fix for this...

See ATEAM-849.

Peter Sherwood authored 2 years ago and Edson Carquin Lopez committed 2 years ago

Trigger jet monitoring: for express jobs monitor only if chain caused event to enter the express stream.

Rebase: master->22.0

Control/AthenaMonitoring/src/AthMonitorAlgorithm.cxx
	If the express stream  job flag is set, if trigger chains are being monitored,
	check that the chain caused the event to enter the express stream

Reconstruction/Jet/JetMonitoring/python/JetMonitoringConfig.py
	Add the express stream job flag to the JetMonAlgSpec dictionary.
	The value defaults to False

Trigger/TrigMonitoring/TrigJetMonitoring/python/TrigJetMonitorAlgorithm.py
	Set the value of the express	stream job flag	 in the JetMonAlgSpec dictionary
	according to the value of inputFlags.Common.doExpressProcessing.

Walter Lampl authored 2 years ago and Julien Maurer committed 2 years ago

Methods to drop components from a ComponentAccumulator instance

Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

AthContainers: Testing alternate allocators.

Test the use of alternate vector allocators for static variables.

Add dictionaries for vectors using polymorphic_allocator.

Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

AthOnnxruntimeUtils: Fix clang warning.

Check return value from onnx function.

Code cleanup

Andrii Verbytskyi authored 2 years ago and Frank Winklmeier committed 2 years ago

Cleanup comments

Needed to change ExpressionEvaluation to use TSMethodCall.

AthExAlgWithFPE is supposed to generate a FPE by division by zero.
But for this to work reliably, we must be sure the compiler cannot see
the division by zero at compile time.
Move the actual division to a separate compilation unit.

Fixes test failure in AthenaConfiguration in the clang build.

Add methods to ClassName to retrieve parsed template arguments.

Allow the usage of `path==None` also for online monitoring. This check
was only ever meant for the HLT to ensure developers specify an explicit
path (e.g. EXPERT). But for other online monitoring (e.g.
GlobalMonitoring) no such restriction should exist. Rather than
complicating the logic even further, remove this check. If someone were
to forget to specify the `path` in the HLT, the histogram would simply
not appear in the output.

Fixes ATR-26666 and ATLLONECAL-436.

Alaettin Serhan Mete authored 2 years ago and Adam Edward Barton committed 2 years ago

Support event augmentation in CA-based jobs

In case of a `ConstDataVector` set the type to the underlying
`DataVector` to make this accessible via the `THolder`.

Peter Sherwood authored 2 years ago and Adam Edward Barton committed 2 years ago

AthMonitorAlgorithm  - add a flag to be set if Alg is running in an the express stream

This is a preliminary commit. The express stream is added, but not yet used.

Adding an attribute to AthMonitorAlgorithm, bit not rebuilding the
derived Algorithms (which occur in many packages) causes a run time failure.

Once the new version of the AthMonitorAlgorithm is built, adding the use of
the attribute (and testing the new code) can be submiited in a future merge request.

Scott Snyder authored 2 years ago and Tadej Novak committed 2 years ago

AthContainers: Supporting custom allocators.

Update to allow for custom allocators on the vectors holding
auxiliary data.  Mostly just adding an additional template parameter
for the allocator.

Atlas Nightlybuild authored 2 years ago and Julien Maurer committed 2 years ago

Delete internal data of ComponentAccumulator before launching the c++ application

Merge branch 'cleanCA' into 'master'

Delete internal data of ComponentAccumulator before launching the c++ application

See merge request atlas/athena!58198

(cherry picked from commit 7f3a16ef)

18069918 Delete internal data of ComponentAccumulator before launching the c++ application
a2c7c7c1 EventInfoCnv_test.py, BeamEffectsAlgConfig.py: Don't use ComponentAccumulator after running it
d9d991ad ISF_FastCaloSimServicesTestHelpers.py: Don't use ComponentAccumulator after running it