Peter Van Gemmeren authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Fix some const correctness for IPC/MP tools

For TMemFiles, Write() file onOpen to register with server and avoid relying on first flush for event data

Andrii Verbytskyi authored 2 years ago and Frank Winklmeier committed 2 years ago

Cleanup comments

Peter Van Gemmeren authored 2 years ago and Frank Winklmeier committed 2 years ago

For Event Augmentation with SharedWriter, fix building FriendTree index

Alaettin Serhan Mete authored 2 years ago and Adam Edward Barton committed 2 years ago

Support event augmentation in CA-based jobs

Tadej Novak authored 2 years ago and Atlas Nightlybuild committed 2 years ago

Improve cachability of ComponentAccumulator returned by IOVDbSvcCfg

See merge request !58206

(cherry picked from commit 2d0130e6)

523e9b43 AccumulatorCache: Improve debug output
4f5ec717 slightly refactor IOVDbSvcCfg to improve cachability
f169cfe5 TriggerJobOpts/Modifiers.py: Lock flag container before calling CAtoGlobalWrapper
0d748df5 append folder list

Walter Lampl authored 2 years ago and Tadej Novak committed 2 years ago

Improve cachability of ComponentAccumulator returned by IOVDbSvcCfg

John Derek Chapman authored 2 years ago and Julien Maurer committed 2 years ago

Workaround for CA-based ReSimulation jobs

This ensures that the conditions run number is available during the
initialization again. The CA-based configuration behaviour is now the
same as the legacy configuration. Further debugging is required to see
if this is correct in the case of variable beam spot simulation.
Should fix ATLASSIM-6113.

Peter Van Gemmeren authored 2 years ago and Tadej Novak committed 2 years ago

Enhancements for EventAugmentaion, fix some storage settings, add friend tree and build index.
This will _not_ yet work with SharedWriter (and TMemFile)

John Derek Chapman authored 2 years ago and Tadej Novak committed 2 years ago

Workaround for CA-based ReSimulation jobs

This ensures that the conditions run number is available during the
initialization again. The CA-based configuration behaviour is now the
same as the legacy configuration. Further debugging is required to see
if this is correct in the case of variable beam spot simulation.
Should fix ATLASSIM-6113.

Andrii Verbytskyi authored 2 years ago and Tadej Novak committed 2 years ago

Remove the CLHEP_HepMC.h as it contains non-existing include files

Mikhail Mineev authored 2 years ago and Tadej Novak committed 2 years ago

Update for CREST API 3

Walter Lampl authored 2 years ago and Atlas Nightlybuild committed 2 years ago

Fail on ROOT write Error.

See merge request atlas/athena!55979

(cherry picked from commit 866d0cf8)

cea24da5 Fail on ROOT write Error.
4bcdd035 Merge remote-tracking branch 'upstream/master' into AthenaIO_PollDbWrite_Error
4faf947f Propagate ERROR when disconnecting Database
b2182374 Merge remote-tracking branch 'upstream/master' into AthenaIO_PollDbWrite_Error
5d420ba7 Check for open database, not existing...
a22b58ed Merge remote-tracking branch 'upstream/master' into AthenaIO_PollDbWrite_Error
24d59f83 Raising ROOT write error all the way to Gaudi, which still swallows it :(

Remove the `ERROR_LEVEL` option in `RootDomain` to avoid modifying
global ROOT variables. Move the only use of this feature into the
application level (`SimpleUtilityBase`).

Enable thread-checker.

Remove the unused `ASYNC_PREFETCHING` and `ABORT_LEVEL` options to avoid
modifying ROOT globals.

Peter Van Gemmeren authored 2 years ago and Walter Lampl committed 2 years ago

Fail on ROOT write Error.

The entire package is already enabled in the thread-checker.

`PoolSvc::createCollection` was marked as not thread-safe due to the use
of the `pool::CollectionFactory` singleton. Use the general PoolSvc
mutex to protect access to it and mark it as safe.

Also lock when calling `registerPFN` on the catalog as it is not clear
to me if the context-specific persistency lock is good enough.

Finally remove some unnecessary mutable, thread-checker annotations and
update link dependencies.

Suppress warning due to unavoidable `const_cast` in `identifier()`.

`ImplicitCollectionIterator` is not thread-safe due to the use of the
`mutable` `m_rowBuffer`. This also makes `ImplicitCollection` not
thread-safe (strictly speaking only the `newQuery` method).

- const fixes for `BranchInfo`
- mark some const_casts as safe
- remove const-violating implementation of non-const
  `RootAuxDynStore::getData`

Shaun Roe authored 2 years ago and Walter Lampl committed 2 years ago

23.0-cppcheck-RootStorageSvc

The `getOption` implementations call non-const methods on the file. Make
the method non-const to avoid thread-checker warnings.

The implementation of `getOption` in `RootDatabase` calls several
non-const `TFile` methods. Make it non-const to avoid thread-checker
warnings.

Tadej Novak authored 2 years ago and Atlas Nightlybuild committed 2 years ago

Fix setting of maximum ROOT output buffer sizes when relying on auto-flush (ie no SharedWriter)

See merge request atlas/athena!57881

(cherry picked from commit a7ab6df2)

0fbad005 Fix setting of maximum ROOT output buffer sizes when relying on auto-flush (ie no SharedWriter)

Peter Van Gemmeren authored 2 years ago and Tadej Novak committed 2 years ago

Fix setting of maximum ROOT output buffer sizes when relying on auto-flush (ie no SharedWriter)

Shaun Roe authored 2 years ago and Tadej Novak committed 2 years ago

Crest development: change server url

Shaun Roe authored 2 years ago and Tadej Novak committed 2 years ago

23.0-cppcheck-ImplicitCollection

    
Uninitialized variables.

David Richard Shope authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Add a check if AthenaMP is available before usage in MSM

Shaun Roe authored 2 years ago and Tadej Novak committed 2 years ago

IOVDbFolder - Relegate folder description printout to DEBUG level

Tadej Novak authored 2 years ago and Atlas Nightlybuild committed 2 years ago

AthenaPoolExampleAlgorithms: Fix thread-safety checker warnings.

See merge request atlas/athena!57487

(cherry picked from commit 38dca6f4)

2776e58f AthenaPoolExampleAlgorithms: Fix thread-safety checker warnings.

Scott Snyder authored 2 years ago and Tadej Novak committed 2 years ago

AthenaPoolExampleAlgorithms: Fix thread-safety checker warnings.

Fix some new thread-safety checker warnings.

Enable thread-safety checking.