Andrii Verbytskyi authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Use prefix increment operator as suggested by cppcheck

John Derek Chapman authored 2 years ago and Frank Winklmeier committed 2 years ago

HGTD_DigitizationTool should use the m_vetoThisBarcode property rather than crazyParticleBarcode directly

Selaiman Ridouani authored 2 years ago and Frank Winklmeier committed 2 years ago

Rename indexes of ID in the HGTD_GmxInterface

Selaiman Ridouani authored 2 years ago and Adam Edward Barton committed 2 years ago

New HGTD detector tool to building the passive material

Valentina Raskina authored 2 years ago and Adam Edward Barton committed 2 years ago

Revert "added a tool for the holes on track search in ITk"

This reverts commit c64ac4b492d5de0d0662a246e0856cad937bc1e7.

Nicholas Styles authored 2 years ago and Tadej Novak committed 2 years ago

Upgrade support for geometry building from .sqlite files

Christos Anastopoulos authored 2 years ago and Tadej Novak committed 2 years ago

TSOS: keep FitQualityOnsurface as value. Re-organise constructors

David Richard Shope authored 2 years ago and Tadej Novak committed 2 years ago

Fix out-of-bounds (debug) error in HGTD GeoModel

Need to include header for TrackingGeometry rather than forward declaring it
if we're using it with conditions handles.  Otherwise,
CondCont<Trk::TrackingGeometry> is defined inconsistently,
leading to a ODR violation

Christos Anastopoulos authored 2 years ago and Adam Edward Barton committed 2 years ago

ATLASRECTS-7249, ATLASRECTS-7251 , make clear where the remaining issues are for ATLASRECTS-7246

Christos Anastopoulos authored 2 years ago and Frank Winklmeier committed 2 years ago

ATLASRECTS-7253 : MuonTrackingGeometry seemingly can become safe

Christos Anastopoulos authored 2 years ago and Frank Winklmeier committed 2 years ago

ATLASRECTS-7248 : Detached tracking volume const fixes

Christos Anastopoulos authored 2 years ago and Frank Winklmeier committed 2 years ago

TrackingVolumeManipulator,TrackingVolumeHelper, TrackingVolumeCreator make safe. start on Geometry builders

TrackingVolumeManipulator,TrackingVolumeHelper, TrackingVolumeCreator make safe. start on Geometry builders

Christos Anastopoulos authored 2 years ago and Frank Winklmeier committed 2 years ago

In various places we were declaring TrackingVolumes as const, and then we were manipulating them later on in the call chain.

We do no need to create new Tracking Volumes as const as a starting point. Especially if the next step is manipulate/fill them by passing them to relevant tools ....

So the proper idea seems to be (done in other MT related migrations) :

* Let's create them as non-const
* manipulate/ add to them/ glue them together,
* when we are done access them later on `as const` via proper `const correct` interfaces.

This MR is step 0, the basic prequisite for cleaning up of all the helpers/processors etc etc. It avoids a few `const_cast` and marks back some methods as `THREAD_SAFE` already.

Christos Anastopoulos authored 2 years ago and Johannes Elmsheuser committed 2 years ago

TrackingVolumeCreator::CreateTrackingVolume  rm un-needed const leading eventually to const_cast

Christos Anastopoulos authored 2 years ago and Johannes Elmsheuser committed 2 years ago

ILayerBuilder,ILayerProvide uneeded const . Similar changes to MR 47538 47499 (for the Cond) but for the service ones since they are still around

John Derek Chapman authored 2 years ago and Peter Berta committed 2 years ago

Rename CA-based configuration modules for Simulation/Digitization package + minor syntax for for LArDigitizationConfig

Valentina Raskina authored 2 years ago and Tadej Novak committed 2 years ago

Added the handles to the HGTD reco decorations

Valentina Raskina authored 2 years ago and Frank Winklmeier committed 2 years ago

Fix for storing HGTD RDO collection(ATLSWUPGR-155)

Alexander Leopold authored 2 years ago and Frank Winklmeier committed 2 years ago

Improve robustness of HGTD_IterativeExtensionTool

Nicholas Styles authored 2 years ago and Walter Lampl committed 2 years ago

fix for HGTD surfaces not being found (ATLSWUPGR-158)

Walter Lampl authored 2 years ago and Atlas Nightlybuild committed 2 years ago

TrkDetDescrInterfaces, etc: Propagate TrackingGeometry conditions dependencies.

See merge request atlas/athena!55294

(cherry picked from commit af3912e6)

47c9bc07 TrkDetDescrInterfaces: Propagate TrackingGeometry conditions dependencies.
df11e625 CaloTrackingGeometry: Propagate TrackingGeometry conditions dependencies.
ca1fc204 HGTD_TrackingGeometry: Propagate TrackingGeometry conditions dependencies.
fccdb7e3 InDetTrackingGeometry: Propagate TrackingGeometry conditions dependencies.
05be8815 MuonTrackingGeometry: Propagate TrackingGeometry conditions dependencies.
39ca9e8e TrkDetDescrTools: Propagate TrackingGeometry conditions dependencies.
3a5353e2 TrackingGeometryCondAlg: Propagate TrackingGeometry conditions dependencies.

Scott Snyder authored 2 years ago and Walter Lampl committed 2 years ago

TrkDetDescrInterfaces: Propagate TrackingGeometry conditions dependencies.

Update TrackingGeometry conditions builder interfaces to pass around
a WriteCondHandle rather than ranges, and call addDependency on the handle
rather than explicitly intersecting ranges.  This allows the
conditions container to collect dependency information as well
as computing the IOV ranges.

Also change to returning unique_ptr where it makes sense.

See ATLASRECTS-7087.

Alexander Leopold authored 2 years ago and Walter Lampl committed 2 years ago

Removing unnecessary warnings in HGTD::ClusterTruthTool

Selaiman Ridouani authored 2 years ago and Adam Edward Barton committed 2 years ago

Change indexes name in HGTD GeoModelXML

Frank Winklmeier authored 2 years ago and Julien Maurer committed 2 years ago

RecExCommon: remove workaround in B-tagging configuration

Remove `configurableRun3Behavior` workaround in RecExCommon.

Relates to ATLASRECTS-6635.

Christos Anastopoulos authored 2 years ago and Julien Maurer committed 2 years ago

Cond Algorithms non-reentrant VI

Enable the thread-checker. Explicitly pass the pulse waveform instead of
storing it in a mutable member.

Passing the `MessageSvc` pointer is no longer necessary for
`AthMessaging`.