Don't use std::move for a return value.

Andrii Verbytskyi authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Prefer prefix ++/-- operators for non-primitive types as suggested by cppcheck

Affected packages:
* Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
* Reconstruction/Jet/JetRecConfig
* PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss

Prefer to initialize data members in an initialization list.

Remove unneeded thread-safety annotation.

Unused variables.

John Derek Chapman authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Ensure that GenEvent barcodes attribute is filled after GenEvent copy constructor is called.

Christos Anastopoulos authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Surface move virtual method from the .icc to the .cxx

Joshua Falco Beirer authored 2 years ago and Peter Berta committed 2 years ago

Manual sweep of !58821 to 22.0

fix for void operator delete(void*, std::size_t)' called on unallocated object 'inputPar' [-Wfree-nonheap-object]

John Derek Chapman authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Fix cppcheck warnings in CaloSamplingFraction package

Should be in the include directory.

`Geo2G4STParameterisation` is not used by default. Nevertheless make the
rotation matrix thread-local in case this code ever gets used. See
discussion on !58732.

Andrii Verbytskyi authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Use HepMC functions from AtlasHepMC/MagicNumbers.h for selection

Christos Anastopoulos authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

ISF AdditionalConfigLegacy try to avoid code duplication

Mainly just mark the `Build` methods all the way up to
`Geo2G4Svc::initialize` as not thread-safe. Some code cleanup on the
way.

Suppress thread-checker warnings.

John Derek Chapman authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Initial implementation of CA-based configuration for Fast Pixel, SCT and TRT Digitization. Some clean-up of properties

Christos Anastopoulos authored 2 years ago and Frank Winklmeier committed 2 years ago

Use ServiceHandle for the TGSvc, rm unused variables , cleanup

- make `CustomMonopoleFactory` const
- use atomics for counters
- suppress some unavoidable const_cast warnings due to restrictions by
  Geant4 interfaces

Make `G4ProessHelper` const by removing unused code and passing
references explicitly instead of relying on member variables.

Remove the `Pythia8ForDecays` singleton and instead use an instance of
this class in `RHadronPythiaDecayer`.

- remove unnecessary const casts
- avoid statics
- mark some unavoidable const cast as safe

William Axel Leight authored 2 years ago and Julien Maurer committed 2 years ago

Add script for running tracking on pileup RDO files

This script runs ID tracking on pileup RDO files to create tracks that are be used when running track overlay.
The tracks and associated PRDs are saved into the RDO file.

John Derek Chapman authored 2 years ago and Frank Winklmeier committed 2 years ago

HGTD_DigitizationTool should use the m_vetoThisBarcode property rather than crazyParticleBarcode directly

Vakhtang Tsulaia authored 2 years ago and Frank Winklmeier committed 2 years ago

Static version of the CaloDetDescrManager

There are a handful of clients which need to get access to the CaloDetDescrManager
at initialize(), prior to alignment corrections are applied to it.
Specifically for these clients the following has been introduced:

1. CALO_DDMANAGER_NOALIGN_KEY constant in CaloDetDescrManager.h

The clients first try to retrieve the manager with this key from Detector Store,
and in case of absence build such a manage by themselves, and record it in
the Detector Store

2. buildCaloDetDescrNoAlign() function in CaloDetDescrBuilder.h

As the name suggests, this is the function which needs to be used by the clients
for building a non-misalignemd CaloDD manager

This MR is a follow up to the discussion in ATLASRECTS-5012

Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

G4UserActions: Fix cppcheck warnings.

Fix cppcheck warnings.

Frank Winklmeier authored 2 years ago and Atlas Nightlybuild committed 2 years ago

Updating FastChain ART tests

See merge request atlas/athena!58334

(cherry picked from commit 6b8629fb)

479b4a7e Updating FastChain ART tests: adding new tests with Track-overlay and using...
a30cc85f Moving other FastChain ART tests to RAWtoALL
c779d32b Removing art-include: 22.0-mc20/Athena
d6853649 Adding Track-overlay tests without simulation

Martina Javurkova authored 2 years ago and Frank Winklmeier committed 2 years ago

Updating FastChain ART tests: adding new tests with Track-overlay and using RAWtoALL for reconstruction

John Derek Chapman authored 2 years ago and Julien Maurer committed 2 years ago

Manual sweep of !58187 from master to 22.0: Protect against FPEs in TFCSEnergyAndHitGAN::fillEnergy method (ATLASSIM-6117)

Merge branch 'ATLFAST3debug_22.0' into 'master'

Protect against FPEs in TFCSEnergyAndHitGAN::fillEnergy method (ATLASSIM-6117)

See merge request atlas/athena!58187

(cherry picked from commit 15ff51f8)

b745da68 Protect against FPEs in TFCSEnergyAndHitGAN::fillEnergy method (ATLASSIM-6117)

John Derek Chapman authored 2 years ago and Frank Winklmeier committed 2 years ago

Address Thread-checker warnings in `Charginos`, `Gauginos` and `Sleptons` packages