- Dec 04, 2022
-
-
TileG4DetDescr: Remove package. This package has thread-unsafe code, and does not appear to be used for anything. Just remove it.
-
Update TileCosmicView.C: Passing the result of c_str() to a stream is slow and redundant.
-
- Dec 01, 2022
-
-
TileMonitoring: Add channels with masked negative energy and bad quality to DMU errors plot Tile DQ Frag monitoring algorithm has been updated to: - add new histograms with number of masked negative energies below threshold per partition; - add properties with thresholds for negative energies for normal and E cells; - add channels with masked negative energy and bad quality to DMU errors plot. MBTS, E4', disconnected channels or channels with bad DQ status are exluded.
-
scott snyder authored
Constructors of Gaudi components should not print output.
-
Prefer prefix ++/-- operators for non-primitive types as suggested by cppcheck
-
- Nov 29, 2022
-
-
scott snyder authored
Prefer to initialize data members in an initialization list.
-
Frank Winklmeier authoredTo avoid corrupt Pool catalogues, run CA tests in private working directory. Also remove redundant timeout setting and use `noerror.sh` as post-processing.
-
- Nov 25, 2022
-
-
Removing dependence on external tools installed on AFS
-
- Nov 11, 2022
-
-
TileDetDescr: Use AthMessaging. Update TileDetDescrManager to use AthMessaging. Fixes in passing a (one-time) memory leak.
-
TileSimAlgs: Fix potential conflict between tests. Give each test a unique output file name, to prevent collisions among them.
-
- Nov 09, 2022
-
-
TileByteStream: Update unpacking of Tile digits received via FELIX TileROD_Decoder has been updated to introduce special function to be used to fill Tile digits collection in the case they are received via FELIX, and to update function used to decode Frag 6 data. Tile digits bytestream converter has been updated to use this new function to fill Tile digits collection if client requests the data received via FELIX, which is determined by name of Tile digits container.
-
- Nov 04, 2022
-
-
Walter Lampl authoredFPEAndCoreDumpConfig: Protect against the absence of AthenaAuditors in some projects
-
- Nov 01, 2022
-
-
MinBiasScintillator: Fix cppcheck warning. Prefer to initialize members in an initializer list.
-
- Oct 27, 2022
-
-
TileSimUtils: Fix cppcheck warnings. Prefer to use range-for.
-
TileGeoG4SD: Fix cppcheck warnings. Prefer to initialize members in an initialization list.
-
- Oct 24, 2022
-
-
TileMonitoring: Update monitoring Tile digits received via FELIX Tile felix digits monitoring algorithm which will be used to monitor digits received via FELIX has been updated to fix calculation of RMS for digits and to add possibility to specify Frag IDs of modules which should be monitorred. New-style (ComponentAccumulator based) confiuration for Tile felix digits monitoring algorithm has been added. Test for Tile felix digits monitoring algorithm has been added.
-
- Oct 20, 2022
-
-
Tadej Novak authored
-
- Oct 18, 2022
-
-
TileMonitoring: Update script to run online Tile monitoring Script to run Tile monitoring has been modified: - conditions and geometry have been updated for Run 3 - stream names to be monitorred in online has been specified explicitely to avoid problems with TLA where there are no Tile information - order of monitoring algorithm in serial mode has been fixed to run data corruption monitoring after creation of cells where event info can be updated with Tile info/errors. Monitoring of energy and time differences in cell between PMTs have been switched on for online.
-
- Oct 14, 2022
-
-
scott snyder authored
Uninitialized variables.
-
- Oct 10, 2022
-
-
TileCalibAlgs: Fix thread-checker warnings in Laser default calibration tool (ATLASRECTS-7308) TileLaserDefaultCalibTool has been updated to remove static variables to fix thread-checker warnings.
-
- Oct 03, 2022
-
-
Fixing size and position of special D4 cells in TileCal See merge request atlas/athena!57195 (cherry picked from commit 4e330a87) 590078ef Fixing size and position of special D4 cells
-
Fixing size and position of special D4 cells in TileCal
-
- Oct 01, 2022
-
-
Remove IOV Callback from TagInfoMgr Removed the use of the IOVSvc callback as it is not thread-safe. Now relying solely on incidents (begin run/file) Also removed DataHandles use to not trigger gccchecker thread safety errors (see ATEAM-855)
-
- Sep 30, 2022
-
-
Frank Winklmeier authored
Mark all legacy DQ monitoring tools as not thread-safe. Relates to ATLASRECTS-7259.
-
- Sep 28, 2022
-
-
TileByteStream: Fix test configuration. Update for changes in tile configuration: need to disable Geant4 version check. Update reference files. Fixes test failure in master.
-
TileByteStream: Fix Tile raw channel and L2 writing into bytestream See merge request atlas/athena!57016
-
TileByteStream: Fix old-style configuration of TileHid2RESrcIDCondAlg (ATR-26346) See merge request atlas/athena!57013
-
Convert TileHid2RESrcID into conditions object for HLT (ATLASRECTS-7291, ATR-21656) See merge request !56863
-
- Sep 27, 2022
-
-
23.0-cppcheck-TileByteStream
-
TileByteStream: Fix Tile raw channel and L2 writing into bytestream
-
TileByteStream: Fix old-style configuration of TileHid2RESrcIDCondAlg (ATR-26346) Old-style configuration of TileHid2RESrcIDCondAlg conditions algorithm has been fixed to produce TileHid2RESrcID conditions object with correct name.
-
- Sep 23, 2022
-
-
TileByteStream: Fix clang warning. Unused private data member.
-
- Sep 22, 2022
-
-
Clean-up in TileGeoModel
-
- Sep 21, 2022
-
-
Convert TileHid2RESrcID into conditions object for HLT (ATLASRECTS-7291, ATR-21656) Since TileHid2RESrcID depends on run number it has been converted into conditions object. New conditions algorithm (TileHid2RESrcIDCondAlg) to produce TileHid2RESrcID conditions object has been added. Configuration and test for TileHid2RESrcIDCondAlg conditions algorithm have been added. Tile region selection algorithm (RegSelCondAlg_Tile) has been updated to use TileHid2RESrcID conditions object and to remove artificial dependency on LArOnOffIdMap conditions object. Test for RegSelCondAlg_Tile algorithm has been added. All Tile byte steam tools have been updated to use TileHid2RESrcID conditions object instead of using the same object from TileROD_Decoder. TrigCaloDataAccessSvc service and the corresponding configuration have been updated to use TileHid2RESrcID conditions object instead of using the same object from TileROD_Decoder. New and old style JO configurations for production of transient BS or writing BS have been updated to configure TileHid2RESrcIDCondAlg conditions algorithm. RegSelToolConfig has been updated accordingly to configure correctly Tile region selection algorithm.
-
- Sep 19, 2022
-
-
cosmetic changes in TileDetDescr package - use the same C++ indent style in all files
-
Back-port of TileGeoModel from master to rel 22
-
Update Tile TMDB Hist intervals for CIS, LAS and PHY runs
-
TileRawUtils: Fix cppcheck warnings. Prefer to initialize class members in an initialization list.
-
- Sep 15, 2022
-
-
Tadej Novak authored
-
- Sep 14, 2022
-
-
Update Tile TMDB Hist intervals for CIS, LAS and PHY runs
-
